honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bare warnings on RollupJobTests (#50633) (#50677) 

Silences some ugly warnings.
This commit is contained in:
Nik Everett 2020-01-06 14:03:30 -05:00 committed by GitHub
parent 926c0aa74c
commit 1b28af489f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/rollup/job/RollupJobTests.java
View File

@ -6,9 +6,7 @@
package org.elasticsearch.xpack.core.rollup.job; package org.elasticsearch.xpack.core.rollup.job;
import org.elasticsearch.cluster.Diff; import org.elasticsearch.cluster.Diff;
import org.elasticsearch.cluster.Diffable;
import org.elasticsearch.common.io.stream.Writeable; import org.elasticsearch.common.io.stream.Writeable;
import org.elasticsearch.common.xcontent.ToXContent;
import org.elasticsearch.common.xcontent.XContentParser; import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.test.AbstractDiffableSerializationTestCase; import org.elasticsearch.test.AbstractDiffableSerializationTestCase;
import org.elasticsearch.xpack.core.rollup.ConfigTestHelpers; import org.elasticsearch.xpack.core.rollup.ConfigTestHelpers;
@ -18,24 +16,24 @@ import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
public class RollupJobTests extends AbstractDiffableSerializationTestCase { public class RollupJobTests extends AbstractDiffableSerializationTestCase<RollupJob> {
@Override @Override
protected Writeable.Reader<Diff> diffReader() { protected Writeable.Reader<Diff<RollupJob>> diffReader() {
return RollupJob::readJobDiffFrom; return RollupJob::readJobDiffFrom;
} }
@Override @Override
protected ToXContent doParseInstance(XContentParser parser) throws IOException { protected RollupJob doParseInstance(XContentParser parser) throws IOException {
return RollupJob.fromXContent(parser); return RollupJob.fromXContent(parser);
} }
@Override @Override
protected Writeable.Reader instanceReader() { protected Writeable.Reader<RollupJob> instanceReader() {
return RollupJob::new; return RollupJob::new;
} }
@Override @Override
protected Writeable createTestInstance() { protected RollupJob createTestInstance() {
if (randomBoolean()) { if (randomBoolean()) {
return new RollupJob(ConfigTestHelpers.randomRollupJobConfig(random()), null); return new RollupJob(ConfigTestHelpers.randomRollupJobConfig(random()), null);
} }
@ -49,8 +47,7 @@ public class RollupJobTests extends AbstractDiffableSerializationTestCase {
} }
@Override @Override
protected Diffable makeTestChanges(Diffable testInstance) { protected RollupJob makeTestChanges(RollupJob other) {
RollupJob other = (RollupJob) testInstance;
if (randomBoolean()) { if (randomBoolean()) {
if (other.getHeaders().isEmpty()) { if (other.getHeaders().isEmpty()) {
Map<String, String> headers = new HashMap<>(1); Map<String, String> headers = new HashMap<>(1);