honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid dumping the heap in Painless tests (#44782) 

Well, we have a test here that intentionally causes an OutOfMemoryError,
to ensure that Painless handles it (I still strongly disagree with doing
this). This causes two things to happen: an OutOfMemoryError to be
dumped to the console, and the heap to be dumped to disk. This makes it
look like we had an OutOfMemoryError while running tests, and the tests
did not fail properly. This commit changes the tests configuration so
that we suppress the heap dump, which also causes the OutOfMemoryError
to no longer be dumped to the console.
This commit is contained in:
Jason Tedor 2019-07-24 00:04:00 -07:00
parent 4c77d5e2c7
commit 1e9c505e95
No known key found for this signature in database
GPG Key ID: FA89F05560F16BC5
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/lang-painless/build.gradle
View File

@ -41,7 +41,8 @@ dependencyLicenses {
} }
test { test {
jvmArgs '-XX:-OmitStackTraceInFastThrow' // in WhenThingsGoWrongTests we intentionally generate an out of memory error, this prevents the heap from being dumped to disk
jvmArgs '-XX:-OmitStackTraceInFastThrow', '-XX:-HeapDumpOnOutOfMemoryError'
} }
/* Build Javadoc for the Java classes in Painless's public API that are in the /* Build Javadoc for the Java classes in Painless's public API that are in the