Merge pull request #16413 from nik9000/line_length_suppress

Fail build for lines longer than 140 characters
2016-02-04 16:45:54 -05:00 · 2016-02-04 16:45:54 -05:00 · 1f5cfd0a76
parent 4b7885969a 7a2947a4ee
commit 1f5cfd0a76
2 changed files with 1708 additions and 2 deletions
--- a/buildSrc/src/main/resources/checkstyle.xml
+++ b/buildSrc/src/main/resources/checkstyle.xml
@ -11,11 +11,12 @@
  </module>

  <module name="TreeWalker">
-    <!-- ~3500 violations
+    <!-- Its our official line length! See checkstyle_suppressions.xml for the files that don't pass this. For now we
+      suppress the check there but enforce it everywhere else. This prevents the list from getting longer even if it is
+      unfair. -->
    <module name="LineLength">
      <property name="max" value="140"/>
    </module>
-    -->

    <module name="AvoidStarImport" />
    <!-- Doesn't pass but we could make it pass pretty quick.
--- a/buildSrc/src/main/resources/checkstyle_suppressions.xml
+++ b/buildSrc/src/main/resources/checkstyle_suppressions.xml