Remove assemble from build task when assemble removed

Removes the `assemble` task from the `build` task when we have
removed `assemble` from the project. We removed `assemble` from
projects that aren't published so our releases will be faster. But
That broke CI because CI builds with `gradle precommit build` and,
it turns out, that `build` includes `check` and `assemble`. With
this change CI will only run `check` for projects without an
`assemble`.

benchmarks/build.gradle

@@ -34,7 +34,9 @@ apply plugin: 'com.github.johnrengelman.shadow'
 // have the shadow plugin provide the runShadow task
 apply plugin: 'application'
 
-tasks.remove(assemble) // Not published so no need to assemble
+// Not published so no need to assemble
+tasks.remove(assemble)
+build.dependsOn.remove('assemble')
 
 archivesBaseName = 'elasticsearch-benchmarks'
 mainClassName = 'org.openjdk.jmh.Main'

build.gradle

@@ -429,6 +429,7 @@ gradle.projectsEvaluated {
       Task assemble = project.tasks.findByName('assemble')
       if (assemble) {
         project.tasks.remove(assemble)
+        project.build.dependsOn.remove('assemble')
       }
     }
   }

buildSrc/src/main/groovy/org/elasticsearch/gradle/doc/DocsTestPlugin.groovy

@@ -34,6 +34,7 @@ public class DocsTestPlugin extends RestTestPlugin {
         super.apply(project)
         // Docs are published separately so no need to assemble
         project.tasks.remove(project.assemble)
+        project.build.dependsOn.remove('assemble')
         Map<String, String> defaultSubstitutions = [
             /* These match up with the asciidoc syntax for substitutions but
              * the values may differ. In particular {version} needs to resolve

client/benchmark/build.gradle

@@ -37,7 +37,9 @@ apply plugin: 'application'
 
 group = 'org.elasticsearch.client'
 
-tasks.remove(assemble) // Not published so no need to assemble
+// Not published so no need to assemble
+tasks.remove(assemble)
+build.dependsOn.remove('assemble')
 
 archivesBaseName = 'client-benchmarks'
 mainClassName = 'org.elasticsearch.client.benchmark.BenchmarkMain'

client/client-benchmark-noop-api-plugin/build.gradle

@@ -27,7 +27,9 @@ esplugin {
   classname 'org.elasticsearch.plugin.noop.NoopPlugin'
 }
 
-tasks.remove(assemble) // Not published so no need to assemble
+// Not published so no need to assemble
+tasks.remove(assemble)
+build.dependsOn.remove('assemble')
 
 compileJava.options.compilerArgs << "-Xlint:-cast,-deprecation,-rawtypes,-try,-unchecked"
 

distribution/bwc/build.gradle

@@ -49,7 +49,9 @@ if (project.name == 'bwc-stable-snapshot') {
 
 if (enabled) {
   apply plugin: 'distribution'
-  tasks.remove(assemble) // Not published so no need to assemble
+  // Not published so no need to assemble
+  tasks.remove(assemble)
+  build.dependsOn.remove('assemble')
 
   def (String major, String minor, String bugfix) = bwcVersion.split('\\.')
   def (String currentMajor, String currentMinor, String currentBugfix) = version.split('\\.')

plugins/examples/build.gradle

@@ -4,6 +4,7 @@ gradle.projectsEvaluated {
     Task assemble = project.tasks.findByName('assemble')
     if (assemble) {
       project.tasks.remove(assemble)
+      project.build.dependsOn.remove('assemble')
     }
   }
 }

plugins/jvm-example/build.gradle

@@ -21,7 +21,9 @@ esplugin {
   description 'Demonstrates all the pluggable Java entry points in Elasticsearch'
   classname 'org.elasticsearch.plugin.example.JvmExamplePlugin'
 }
-tasks.remove(assemble) // Not published so no need to assemble
+// Not published so no need to assemble
+tasks.remove(assemble)
+build.dependsOn.remove('assemble')
 
 // no unit tests
 test.enabled = false

test/fixtures/example-fixture/build.gradle

@@ -19,4 +19,6 @@
 
 apply plugin: 'elasticsearch.build'
 test.enabled = false
-tasks.remove(assemble) // Not published so no need to assemble
+// Not published so no need to assemble
+tasks.remove(assemble)
+build.dependsOn.remove('assemble')