honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix PolicyStatsTests mutateInstance (#34835) 

through randomization, there is a chance that the mutateInstance
for PolicyStatsTests does not actually mutate the original object.
This PR aims to fix this
This commit is contained in:
Tal Levy 2018-10-25 07:24:54 -07:00 committed by GitHub
parent 0b26f8b14c
commit 21b9b024c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/PolicyStatsTests.java
View File

@ -38,10 +38,10 @@ public class PolicyStatsTests extends AbstractWireSerializingTestCase<PolicyStat
switch (between(0, 1)) { switch (between(0, 1)) {
case 0: case 0:
phaseStats = new HashMap<>(instance.getPhaseStats()); phaseStats = new HashMap<>(instance.getPhaseStats());
phaseStats.put(randomAlphaOfLengthBetween(1, 20), PhaseStatsTests.createRandomInstance()); phaseStats.put(randomAlphaOfLengthBetween(21, 25), PhaseStatsTests.createRandomInstance());
break; break;
case 1: case 1:
indicesManaged = randomIntBetween(1, 50); indicesManaged = randomIntBetween(11, 50);
break; break;
default: default:
throw new AssertionError("Illegal randomisation branch"); throw new AssertionError("Illegal randomisation branch");

2
x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/indexlifecycle/PolicyStatsTests.java
View File

@ -39,7 +39,7 @@ public class PolicyStatsTests extends AbstractWireSerializingTestCase<PolicyStat
switch (between(0, 1)) { switch (between(0, 1)) {
case 0: case 0:
phaseStats = new HashMap<>(phaseStats); phaseStats = new HashMap<>(phaseStats);
phaseStats.put(randomAlphaOfLength(10), PhaseStatsTests.randomPhaseStats()); phaseStats.put(randomAlphaOfLength(11), PhaseStatsTests.randomPhaseStats());
break; break;
case 1: case 1:
numberIndicesManaged += randomIntBetween(1, 10); numberIndicesManaged += randomIntBetween(1, 10);