honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-08 22:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Print output when the name checker IT fails (#31660)

Browse Source
This commit is contained in:
Alpar Torok 2018-06-28 17:58:24 +03:00 committed by GitHub
parent 3fce13fd28
commit 304316ac3b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
buildSrc/src/test/java/org/elasticsearch/gradle/precommit/NamingConventionsTaskIT.java
View File

@ -17,7 +17,8 @@ public class NamingConventionsTaskIT extends GradleIntegrationTestCase {
.build(); .build();
assertEquals(TaskOutcome.SUCCESS, result.task(":hello").getOutcome()); assertEquals(TaskOutcome.SUCCESS, result.task(":hello").getOutcome());
assertTrue(result.getOutput().contains("build plugin can be applied")); String output = result.getOutput();
assertTrue(output, output.contains("build plugin can be applied"));
} }
public void testNameCheckFailsAsItShould() { public void testNameCheckFailsAsItShould() {
@ -29,6 +30,7 @@ public class NamingConventionsTaskIT extends GradleIntegrationTestCase {
assertNotNull("task did not run", result.task(":namingConventions")); assertNotNull("task did not run", result.task(":namingConventions"));
assertEquals(TaskOutcome.FAILED, result.task(":namingConventions").getOutcome()); assertEquals(TaskOutcome.FAILED, result.task(":namingConventions").getOutcome());
String output = result.getOutput();
for (String line : Arrays.asList( for (String line : Arrays.asList(
"Found inner classes that are tests, which are excluded from the test runner:", "Found inner classes that are tests, which are excluded from the test runner:",
"* org.elasticsearch.test.NamingConventionsCheckInMainIT$InternalInvalidTests", "* org.elasticsearch.test.NamingConventionsCheckInMainIT$InternalInvalidTests",
@ -38,8 +40,8 @@ public class NamingConventionsTaskIT extends GradleIntegrationTestCase {
"Not all subclasses of UnitTestCase match the naming convention. Concrete classes must end with [Tests]:", "Not all subclasses of UnitTestCase match the naming convention. Concrete classes must end with [Tests]:",
"* org.elasticsearch.test.WrongName")) { "* org.elasticsearch.test.WrongName")) {
assertTrue( assertTrue(
"expected: '" + line + "' but it was not found in the output", "expected: '" + line + "' but it was not found in the output:\n" + output,
result.getOutput().contains(line) output.contains(line)
); );
} }
} }
@ -54,6 +56,7 @@ public class NamingConventionsTaskIT extends GradleIntegrationTestCase {
assertNotNull("task did not run", result.task(":namingConventions")); assertNotNull("task did not run", result.task(":namingConventions"));
assertEquals(TaskOutcome.FAILED, result.task(":namingConventions").getOutcome()); assertEquals(TaskOutcome.FAILED, result.task(":namingConventions").getOutcome());
String output = result.getOutput();
for (String line : Arrays.asList( for (String line : Arrays.asList(
"Classes ending with [Tests] or [IT] or extending [UnitTestCase] must be in src/test/java:", "Classes ending with [Tests] or [IT] or extending [UnitTestCase] must be in src/test/java:",
"* org.elasticsearch.test.NamingConventionsCheckBadClasses$DummyInterfaceTests", "* org.elasticsearch.test.NamingConventionsCheckBadClasses$DummyInterfaceTests",
@ -63,8 +66,8 @@ public class NamingConventionsTaskIT extends GradleIntegrationTestCase {
"* org.elasticsearch.test.NamingConventionsCheckBadClasses$WrongNameTheSecond", "* org.elasticsearch.test.NamingConventionsCheckBadClasses$WrongNameTheSecond",
"* org.elasticsearch.test.NamingConventionsCheckBadClasses$WrongName")) { "* org.elasticsearch.test.NamingConventionsCheckBadClasses$WrongName")) {
assertTrue( assertTrue(
"expected: '" + line + "' but it was not found in the output", "expected: '" + line + "' but it was not found in the output:\n"+output,
result.getOutput().contains(line) output.contains(line)
); );
} }
} }