don't throw exceptions from ctor, guice is hell

plugins/repository-hdfs/src/main/java/org/elasticsearch/repositories/hdfs/HdfsRepository.java

@@ -55,38 +55,50 @@ public class HdfsRepository extends BlobStoreRepository implements FileContextFa
 
     public final static String TYPE = "hdfs";
 
-    private final HdfsBlobStore blobStore;
     private final BlobPath basePath;
     private final ByteSizeValue chunkSize;
     private final boolean compress;
     private final RepositorySettings repositorySettings;
+    private final ThreadPool threadPool;
+    private final String path;
     private FileContext fc;
+    private HdfsBlobStore blobStore;
 
     @Inject
     public HdfsRepository(RepositoryName name, RepositorySettings repositorySettings, IndexShardRepository indexShardRepository, ThreadPool threadPool) throws IOException {
         super(name.getName(), repositorySettings, indexShardRepository);
 
         this.repositorySettings = repositorySettings;
+        this.threadPool = threadPool;
 
-        String path = repositorySettings.settings().get("path", settings.get("path"));
+        path = repositorySettings.settings().get("path", settings.get("path"));
+
+
+        this.basePath = BlobPath.cleanPath();
+        this.chunkSize = repositorySettings.settings().getAsBytesSize("chunk_size", settings.getAsBytesSize("chunk_size", null));
+        this.compress = repositorySettings.settings().getAsBoolean("compress", settings.getAsBoolean("compress", false));
+    }
+    
+    @Override
+    protected void doStart() {
+        // get configuration
         if (path == null) {
             throw new IllegalArgumentException("no 'path' defined for hdfs snapshot/restore");
         }
-
+        try {
-        // get configuration
+            fc = getFileContext();
-        fc = getFileContext();
+            Path hdfsPath = SecurityUtils.execute(fc, new FcCallback<Path>() {
-        Path hdfsPath = SecurityUtils.execute(fc, new FcCallback<Path>() {
+                @Override
-            @Override
+                public Path doInHdfs(FileContext fc) throws IOException {
-            public Path doInHdfs(FileContext fc) throws IOException {
+                    return fc.makeQualified(new Path(path));
-                return fc.makeQualified(new Path(path));
+                }
-            }
+            });
-        });
+            logger.debug("Using file-system [{}] for URI [{}], path [{}]", fc.getDefaultFileSystem(), fc.getDefaultFileSystem().getUri(), hdfsPath);
-        this.basePath = BlobPath.cleanPath();
+            blobStore = new HdfsBlobStore(settings, this, hdfsPath, threadPool);
-
+        } catch (IOException e) {
-        logger.debug("Using file-system [{}] for URI [{}], path [{}]", fc.getDefaultFileSystem(), fc.getDefaultFileSystem().getUri(), hdfsPath);
+            throw new RuntimeException(e);
-        blobStore = new HdfsBlobStore(settings, this, hdfsPath, threadPool);
+        }
-        this.chunkSize = repositorySettings.settings().getAsBytesSize("chunk_size", settings.getAsBytesSize("chunk_size", null));
+        super.doStart();
-        this.compress = repositorySettings.settings().getAsBoolean("compress", settings.getAsBoolean("compress", false));
     }
 
     // as the FileSystem is long-lived and might go away, make sure to check it before it's being used.

plugins/repository-hdfs/src/test/resources/rest-api-spec/test/hdfs_repository/20_repository.yaml

@@ -10,7 +10,7 @@
           body:
             type: hdfs
             settings:
-              uri: "hdfs://localhost:36909"
+              uri: "hdfs://localhost:40737"
               path: "foo/bar"
 
     # Get repository

plugins/repository-hdfs/src/test/resources/rest-api-spec/test/hdfs_repository/30_snapshot.yaml

@@ -12,7 +12,7 @@ setup:
         body:
           type: hdfs
           settings:
-            uri: "hdfs://localhost:36909"
+            uri: "hdfs://localhost:40737"
             path: "foo/bar"
 
   - do:

plugins/repository-hdfs/src/test/resources/rest-api-spec/test/hdfs_repository/40_restore.yaml

@@ -12,7 +12,7 @@ setup:
         body:
           type: hdfs
           settings:
-            uri: "hdfs://localhost:36909"
+            uri: "hdfs://localhost:40737"
             path: "foo/bar"
 
   - do: