From 327f44e05108558f74276748baa2a8d5a917db96 Mon Sep 17 00:00:00 2001
From: Jay Modi <jaymode@users.noreply.github.com>
Date: Tue, 14 May 2019 16:29:18 -0400
Subject: [PATCH] Concurrent tests wait for threads to be ready (#42083)

This change updates tests that use a CountDownLatch to synchronize the
running of threads when testing concurrent operations so that we ensure
the thread has been fully created and run by the scheduler. Previously,
these tests used a latch with a value of 1 and the test thread counted
down while the threads performing concurrent operations just waited.
This change updates the value of the latch to be 1 + the number of
threads. Each thread counts down and then waits. This means that each
thread has been constructed and has started running. All threads will
have a common start point now.
---
 .../elasticsearch/common/util/concurrent/CountDownTests.java   | 3 ++-
 .../elasticsearch/common/util/concurrent/KeyedLockTests.java   | 3 ++-
 .../org/elasticsearch/common/util/concurrent/RunOnceTests.java | 3 ++-
 .../org/elasticsearch/node/ResponseCollectorServiceTests.java  | 3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/server/src/test/java/org/elasticsearch/common/util/concurrent/CountDownTests.java b/server/src/test/java/org/elasticsearch/common/util/concurrent/CountDownTests.java
index 1a32064fe7d..46021344fb7 100644
--- a/server/src/test/java/org/elasticsearch/common/util/concurrent/CountDownTests.java
+++ b/server/src/test/java/org/elasticsearch/common/util/concurrent/CountDownTests.java
@@ -34,12 +34,13 @@ public class CountDownTests extends ESTestCase {
         final AtomicInteger count = new AtomicInteger(0);
         final CountDown countDown = new CountDown(scaledRandomIntBetween(10, 1000));
         Thread[] threads = new Thread[between(3, 10)];
-        final CountDownLatch latch = new CountDownLatch(1);
+        final CountDownLatch latch = new CountDownLatch(1 + threads.length);
         for (int i = 0; i < threads.length; i++) {
             threads[i] = new Thread() {
 
                 @Override
                 public void run() {
+                    latch.countDown();
                     try {
                         latch.await();
                     } catch (InterruptedException e) {
diff --git a/server/src/test/java/org/elasticsearch/common/util/concurrent/KeyedLockTests.java b/server/src/test/java/org/elasticsearch/common/util/concurrent/KeyedLockTests.java
index e50e205ff13..2160052619c 100644
--- a/server/src/test/java/org/elasticsearch/common/util/concurrent/KeyedLockTests.java
+++ b/server/src/test/java/org/elasticsearch/common/util/concurrent/KeyedLockTests.java
@@ -45,8 +45,8 @@ public class KeyedLockTests extends ESTestCase {
         for (int i = 0; i < names.length; i++) {
             names[i] = randomRealisticUnicodeOfLengthBetween(10, 20);
         }
-        CountDownLatch startLatch = new CountDownLatch(1);
         int numThreads = randomIntBetween(3, 10);
+        final CountDownLatch startLatch = new CountDownLatch(1 + numThreads);
         AcquireAndReleaseThread[] threads = new AcquireAndReleaseThread[numThreads];
         for (int i = 0; i < numThreads; i++) {
             threads[i] = new AcquireAndReleaseThread(startLatch, connectionLock, names, counter, safeCounter);
@@ -157,6 +157,7 @@ public class KeyedLockTests extends ESTestCase {
 
         @Override
         public void run() {
+            startLatch.countDown();
             try {
                 startLatch.await();
             } catch (InterruptedException e) {
diff --git a/server/src/test/java/org/elasticsearch/common/util/concurrent/RunOnceTests.java b/server/src/test/java/org/elasticsearch/common/util/concurrent/RunOnceTests.java
index e833edc9d56..a41d37be215 100644
--- a/server/src/test/java/org/elasticsearch/common/util/concurrent/RunOnceTests.java
+++ b/server/src/test/java/org/elasticsearch/common/util/concurrent/RunOnceTests.java
@@ -45,9 +45,10 @@ public class RunOnceTests extends ESTestCase {
         final RunOnce runOnce = new RunOnce(counter::incrementAndGet);
 
         final Thread[] threads = new Thread[between(3, 10)];
-        final CountDownLatch latch = new CountDownLatch(1);
+        final CountDownLatch latch = new CountDownLatch(1 + threads.length);
         for (int i = 0; i < threads.length; i++) {
             threads[i] = new Thread(() -> {
+                latch.countDown();
                 try {
                     latch.await();
                 } catch (InterruptedException e) {
diff --git a/server/src/test/java/org/elasticsearch/node/ResponseCollectorServiceTests.java b/server/src/test/java/org/elasticsearch/node/ResponseCollectorServiceTests.java
index 5fedfa7869e..7ac254f9948 100644
--- a/server/src/test/java/org/elasticsearch/node/ResponseCollectorServiceTests.java
+++ b/server/src/test/java/org/elasticsearch/node/ResponseCollectorServiceTests.java
@@ -77,9 +77,10 @@ public class ResponseCollectorServiceTests extends ESTestCase {
     public void testConcurrentAddingAndRemoving() throws Exception {
         String[] nodes = new String[] {"a", "b", "c", "d"};
 
-        final CountDownLatch latch = new CountDownLatch(1);
+        final CountDownLatch latch = new CountDownLatch(5);
 
         Runnable f = () -> {
+            latch.countDown();
             try {
                 latch.await();
             } catch (InterruptedException e) {