honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-03-01 16:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make RestSearchAction#parseSearchXXX(RestRequest) public

Browse Source 
When building a plugin with a new search endpoint, you need to parse the request as a searchRequest.

Methods exist in RestSearchAction class but are private.

We will modify them to be public static. This applies to:

* `RestSearchAction#parseSearchRequest(RestRequest)`
* `RestSearchAction#parseSearchSource(RestRequest)`

 Closes #3499.
This commit is contained in:
David Pilato 2013-08-13 17:05:21 +02:00
parent e111a7da62
commit 328608f55f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/org/elasticsearch/rest/action/search/RestSearchAction.java
View File

@ -68,7 +68,7 @@ public class RestSearchAction extends BaseRestHandler {
public void handleRequest(final RestRequest request, final RestChannel channel) { public void handleRequest(final RestRequest request, final RestChannel channel) {
SearchRequest searchRequest; SearchRequest searchRequest;
try { try {
searchRequest = parseSearchRequest(request); searchRequest = RestSearchAction.parseSearchRequest(request);
searchRequest.listenerThreaded(false); searchRequest.listenerThreaded(false);
SearchOperationThreading operationThreading = SearchOperationThreading.fromString(request.param("operation_threading"), null); SearchOperationThreading operationThreading = SearchOperationThreading.fromString(request.param("operation_threading"), null);
if (operationThreading != null) { if (operationThreading != null) {
@ -118,7 +118,7 @@ public class RestSearchAction extends BaseRestHandler {
}); });
} }
private SearchRequest parseSearchRequest(RestRequest request) { public static SearchRequest parseSearchRequest(RestRequest request) {
String[] indices = RestActions.splitIndices(request.param("index")); String[] indices = RestActions.splitIndices(request.param("index"));
SearchRequest searchRequest = new SearchRequest(indices); SearchRequest searchRequest = new SearchRequest(indices);
// get the content, and put it in the body // get the content, and put it in the body
@ -150,7 +150,7 @@ public class RestSearchAction extends BaseRestHandler {
return searchRequest; return searchRequest;
} }
private SearchSourceBuilder parseSearchSource(RestRequest request) { public static SearchSourceBuilder parseSearchSource(RestRequest request) {
SearchSourceBuilder searchSourceBuilder = null; SearchSourceBuilder searchSourceBuilder = null;
String queryString = request.param("q"); String queryString = request.param("q");
if (queryString != null) { if (queryString != null) {