honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SQL: Upgrade JDBC CSV library (elastic/x-pack-elasticsearch#2907) 

Upgrades JDBC CSV library to v1.0.34. This version contains a fix for autodetection of column types, which was broken before in tr-TR locale.

relates elastic/x-pack-elasticsearch#2813

Original commit: elastic/x-pack-elasticsearch@a9b94d2969
This commit is contained in:
Igor Motov 2017-11-07 11:11:43 -05:00 committed by GitHub
parent de33803d85
commit 330fdc19c3
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qa/sql/build.gradle
View File

@ -19,7 +19,7 @@ dependencies {
transitive = false
}
}
compile "net.sourceforge.csvjdbc:csvjdbc:1.0.31"
compile "net.sourceforge.csvjdbc:csvjdbc:1.0.34"
runtime "com.h2database:h2:1.4.194"
// used for running debug tests
runtime 'org.antlr:antlr4-runtime:4.5.3'
@ -115,7 +115,7 @@ subprojects {
transitive = false
}
}
testRuntime("net.sourceforge.csvjdbc:csvjdbc:1.0.31") {
testRuntime("net.sourceforge.csvjdbc:csvjdbc:1.0.34") {
transitive = false
}
testRuntime("com.h2database:h2:1.4.194") {

3
qa/sql/src/main/java/org/elasticsearch/xpack/qa/sql/jdbc/CsvSpecTestCase.java
View File

@ -102,9 +102,6 @@ public abstract class CsvSpecTestCase extends SpecBaseIntegrationTestCase {
String header = bufferedReader.readLine();
if (!header.contains(":")) {
// No type information in headers, no need to parse columns - trigger auto-detection
// TODO: Remove when type autodetection in JDBC CSV is fixed
// See https://sourceforge.net/p/csvjdbc/discussion/56965/thread/6a910831/ for more info
fail("The autodetection of types in JDBC CSV is currently broken. Please specify explicit types");
return new Tuple<>(expectedResults,"");
}
try (StringWriter writer = new StringWriter()) {