[Monitoring] Make Exporters Async (#35765)

This changes the exporter code -- most notably the `http` exporter --
to use async operations throughout the resource management and bulk
initialization code (the bulk indexing of monitoring documents was
already async).

As part of this change, this does change one semi-core aspect of the
`HttpResource` class in that it will no longer block all concurrent calls
until the first call completes with
`HttpResource::checkAndPublishIfDirty`.
Now, any parallel attempts to check the resources will be skipped until
the first call completes (success or failure). While this is a technical
change, it has very little practical impact because the existing behavior
was either quick success (then every blocked request processed) or
each request timed out and failed anyway, thus being effectively
skipped (and a burden on the system).

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/MonitoringFeatureSet.java

@@ -75,7 +75,7 @@ public class MonitoringFeatureSet implements XPackFeatureSet {
             return null;
         }
         Map<String, Object> usage = new HashMap<>();
-        for (Exporter exporter : exporters) {
+        for (Exporter exporter : exporters.getEnabledExporters()) {
             if (exporter.config().enabled()) {
                 String type = exporter.config().type();
                 int count = (Integer) usage.getOrDefault(type, 0);

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/MonitoringService.java

@@ -20,7 +20,6 @@ import org.elasticsearch.common.util.concurrent.AbstractRunnable;
 import org.elasticsearch.threadpool.ThreadPool;
 import org.elasticsearch.xpack.core.monitoring.exporter.MonitoringDoc;
 import org.elasticsearch.xpack.monitoring.collector.Collector;
-import org.elasticsearch.xpack.monitoring.exporter.Exporter;
 import org.elasticsearch.xpack.monitoring.exporter.Exporters;
 
 import java.io.Closeable;
@@ -174,14 +173,7 @@ public class MonitoringService extends AbstractLifecycleComponent {
     protected void doClose() {
         logger.debug("monitoring service is closing");
         monitor.close();
-
+        exporters.close();
-        for (Exporter exporter : exporters) {
-            try {
-                exporter.close();
-            } catch (Exception e) {
-                logger.error((Supplier<?>) () -> new ParameterizedMessage("failed to close exporter [{}]", exporter.name()), e);
-            }
-        }
         logger.debug("monitoring service closed");
     }
 

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/Exporter.java

@@ -5,6 +5,7 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter;
 
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.cluster.service.ClusterService;
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Setting.Property;
@@ -93,17 +94,18 @@ public abstract class Exporter implements AutoCloseable {
     }
 
     /**
-     * Opens up a new export bulk. May return {@code null} indicating this exporter is not ready
+     * Opens up a new export bulk.
-     * yet to export the docs
+     *
+     * @param listener Returns {@code null} to indicate that this exporter is not ready to export the docs.
      */
-    public abstract ExportBulk openBulk();
+    public abstract void openBulk(ActionListener<ExportBulk> listener);
 
     protected final boolean isClosed() {
         return closed.get();
     }
 
     @Override
-    public void close() throws Exception {
+    public void close() {
         if (closed.compareAndSet(false, true)) {
             doClose();
         }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/Exporters.java

@@ -17,7 +17,10 @@ import org.elasticsearch.common.component.Lifecycle;
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.settings.SettingsException;
+import org.elasticsearch.common.util.concurrent.AtomicArray;
+import org.elasticsearch.common.util.concurrent.CountDown;
 import org.elasticsearch.common.util.concurrent.ThreadContext;
+import org.elasticsearch.gateway.GatewayService;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.xpack.monitoring.exporter.http.HttpExporter;
 import org.elasticsearch.xpack.core.monitoring.exporter.MonitoringDoc;
@@ -27,7 +30,6 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
@@ -36,7 +38,7 @@ import java.util.concurrent.atomic.AtomicReference;
 
 import static java.util.Collections.emptyMap;
 
-public class Exporters extends AbstractLifecycleComponent implements Iterable<Exporter> {
+public class Exporters extends AbstractLifecycleComponent {
     private static final Logger logger = LogManager.getLogger(Exporters.class);
 
     private final Settings settings;
@@ -90,9 +92,13 @@ public class Exporters extends AbstractLifecycleComponent implements Iterable<Ex
         return exporters.get().get(name);
     }
 
-    @Override
+    /**
-    public Iterator<Exporter> iterator() {
+     * Get all enabled {@linkplain Exporter}s.
-        return exporters.get().values().iterator();
+     *
+     * @return Never {@code null}. Can be empty if none are enabled.
+     */
+    public Collection<Exporter> getEnabledExporters() {
+        return exporters.get().values();
     }
 
     static void closeExporters(Logger logger, Map<String, Exporter> exporters) {
@@ -105,31 +111,6 @@ public class Exporters extends AbstractLifecycleComponent implements Iterable<Ex
         }
     }
 
-    ExportBulk openBulk() {
-        final ClusterState state = clusterService.state();
-
-        if (ClusterState.UNKNOWN_UUID.equals(state.metaData().clusterUUID()) || state.version() == ClusterState.UNKNOWN_VERSION) {
-            logger.trace("skipping exporters because the cluster state is not loaded");
-            return null;
-        }
-
-        List<ExportBulk> bulks = new ArrayList<>();
-        for (Exporter exporter : this) {
-            try {
-                ExportBulk bulk = exporter.openBulk();
-                if (bulk == null) {
-                    logger.debug("skipping exporter [{}] as it is not ready yet", exporter.name());
-                } else {
-                    bulks.add(bulk);
-                }
-            } catch (Exception e) {
-                logger.error(
-                        (Supplier<?>) () -> new ParameterizedMessage("exporter [{}] failed to open exporting bulk", exporter.name()), e);
-            }
-        }
-        return bulks.isEmpty() ? null : new ExportBulk.Compound(bulks, threadContext);
-    }
-
     Map<String, Exporter> initExporters(Settings settings) {
         Set<String> singletons = new HashSet<>();
         Map<String, Exporter> exporters = new HashMap<>();
@@ -180,38 +161,81 @@ public class Exporters extends AbstractLifecycleComponent implements Iterable<Ex
         return exporters;
     }
 
+    /**
+     * Wrap every {@linkplain Exporter}'s {@linkplain ExportBulk} in a {@linkplain ExportBulk.Compound}.
+     *
+     * @param listener {@code null} if no exporters are ready or available.
+     */
+    void wrapExportBulk(final ActionListener<ExportBulk> listener) {
+        final ClusterState state = clusterService.state();
+
+        // wait until we have a usable cluster state
+        if (state.blocks().hasGlobalBlock(GatewayService.STATE_NOT_RECOVERED_BLOCK) ||
+            ClusterState.UNKNOWN_UUID.equals(state.metaData().clusterUUID()) ||
+            state.version() == ClusterState.UNKNOWN_VERSION) {
+            logger.trace("skipping exporters because the cluster state is not loaded");
+
+            listener.onResponse(null);
+            return;
+        }
+
+        final Map<String, Exporter> exporterMap = exporters.get();
+        final AtomicArray<ExportBulk> accumulatedBulks = new AtomicArray<>(exporterMap.size());
+        final CountDown countDown = new CountDown(exporterMap.size());
+
+        int i = 0;
+
+        // get every exporter's ExportBulk and, when they've all responded, respond with a wrapped version
+        for (final Exporter exporter : exporterMap.values()) {
+            exporter.openBulk(
+                new AccumulatingExportBulkActionListener(exporter.name(), i++, accumulatedBulks, countDown, threadContext, listener));
+        }
+    }
+
     /**
      * Exports a collection of monitoring documents using the configured exporters
      */
-    public void export(Collection<MonitoringDoc> docs, ActionListener<Void> listener) throws ExportException {
+    public void export(final Collection<MonitoringDoc> docs, final ActionListener<Void> listener) throws ExportException {
         if (this.lifecycleState() != Lifecycle.State.STARTED) {
             listener.onFailure(new ExportException("Export service is not started"));
         } else if (docs != null && docs.size() > 0) {
-            final ExportBulk bulk = openBulk();
+            wrapExportBulk(ActionListener.wrap(bulk -> {
-
+                if (bulk != null) {
-            if (bulk != null) {
+                    doExport(bulk, docs, listener);
-                final AtomicReference<ExportException> exceptionRef = new AtomicReference<>();
+                } else {
-                try {
+                    listener.onResponse(null);
-                    bulk.add(docs);
-                } catch (ExportException e) {
-                    exceptionRef.set(e);
-                } finally {
-                    bulk.close(lifecycleState() == Lifecycle.State.STARTED, ActionListener.wrap(r -> {
-                        if (exceptionRef.get() == null) {
-                            listener.onResponse(null);
-                        } else {
-                            listener.onFailure(exceptionRef.get());
-                        }
-                    }, listener::onFailure));
                 }
-            } else {
+            }, listener::onFailure));
-                listener.onResponse(null);
-            }
         } else {
             listener.onResponse(null);
         }
     }
 
+    /**
+     * Add {@code docs} and send the {@code bulk}, then respond to the {@code listener}.
+     *
+     * @param bulk The bulk object to send {@code docs} through.
+     * @param docs The monitoring documents to send.
+     * @param listener Returns {@code null} when complete, or failure where relevant.
+     */
+    private void doExport(final ExportBulk bulk, final Collection<MonitoringDoc> docs, final ActionListener<Void> listener) {
+        final AtomicReference<ExportException> exceptionRef = new AtomicReference<>();
+
+        try {
+            bulk.add(docs);
+        } catch (ExportException e) {
+            exceptionRef.set(e);
+        } finally {
+            bulk.close(lifecycleState() == Lifecycle.State.STARTED, ActionListener.wrap(r -> {
+                if (exceptionRef.get() == null) {
+                    listener.onResponse(null);
+                } else {
+                    listener.onFailure(exceptionRef.get());
+                }
+            }, listener::onFailure));
+        }
+    }
+
     /**
      * Return all the settings of all the exporters, no matter if HTTP or Local
      */
@@ -221,4 +245,66 @@ public class Exporters extends AbstractLifecycleComponent implements Iterable<Ex
         settings.addAll(HttpExporter.getSettings());
         return settings;
     }
+
+    /**
+     * {@code AccumulatingExportBulkActionListener} allows us to asynchronously gather all of the {@linkplain ExportBulk}s that are
+     * ready, as associated with the enabled {@linkplain Exporter}s.
+     */
+    static class AccumulatingExportBulkActionListener implements ActionListener<ExportBulk> {
+
+        private final String name;
+        private final int indexPosition;
+        private final AtomicArray<ExportBulk> accumulatedBulks;
+        private final CountDown countDown;
+        private final ActionListener<ExportBulk> delegate;
+        private final ThreadContext threadContext;
+
+        AccumulatingExportBulkActionListener(final String name,
+                                             final int indexPosition, final AtomicArray<ExportBulk> accumulatedBulks,
+                                             final CountDown countDown,
+                                             final ThreadContext threadContext, final ActionListener<ExportBulk> delegate) {
+            this.name = name;
+            this.indexPosition = indexPosition;
+            this.accumulatedBulks = accumulatedBulks;
+            this.countDown = countDown;
+            this.threadContext = threadContext;
+            this.delegate = delegate;
+        }
+
+        @Override
+        public void onResponse(final ExportBulk exportBulk) {
+            if (exportBulk == null) {
+                logger.debug("skipping exporter [{}] as it is not ready yet", name);
+            } else {
+                accumulatedBulks.set(indexPosition, exportBulk);
+            }
+
+            delegateIfComplete();
+        }
+
+        @Override
+        public void onFailure(Exception e) {
+            logger.error((Supplier<?>) () -> new ParameterizedMessage("exporter [{}] failed to open exporting bulk", name), e);
+
+            delegateIfComplete();
+        }
+
+        /**
+         * Once all {@linkplain Exporter}'s have responded, whether it was success or failure, then this responds with all successful
+         * {@linkplain ExportBulk}s wrapped using an {@linkplain ExportBulk.Compound} wrapper.
+         */
+        void delegateIfComplete() {
+            if (countDown.countDown()) {
+                final List<ExportBulk> bulkList = accumulatedBulks.asList();
+
+                if (bulkList.isEmpty()) {
+                    delegate.onResponse(null);
+                } else {
+                    delegate.onResponse(new ExportBulk.Compound(bulkList, threadContext));
+                }
+            }
+        }
+
+    }
+
 }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/ClusterAlertHttpResource.java

@@ -13,6 +13,7 @@ import org.apache.http.entity.ContentType;
 import org.apache.http.entity.StringEntity;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.CheckedFunction;
@@ -79,34 +80,33 @@ public class ClusterAlertHttpResource extends PublishableHttpResource {
      * Determine if the current {@linkplain #watchId Watch} exists.
      */
     @Override
-    protected CheckResponse doCheck(final RestClient client) {
+    protected void doCheck(final RestClient client, final ActionListener<Boolean> listener) {
         // if we should be adding, then we need to check for existence
         if (isWatchDefined() && licenseState.isMonitoringClusterAlertsAllowed()) {
             final CheckedFunction<Response, Boolean, IOException> watchChecker =
                     (response) -> shouldReplaceClusterAlert(response, XContentType.JSON.xContent(), LAST_UPDATED_VERSION);
 
-            return versionCheckForResource(client, logger,
+            checkForResource(client, listener, logger,
-                                           "/_xpack/watcher/watch", watchId.get(), "monitoring cluster alert",
+                             "/_xpack/watcher/watch", watchId.get(), "monitoring cluster alert",
-                                           resourceOwnerName, "monitoring cluster",
+                             resourceOwnerName, "monitoring cluster",
-                                           watchChecker);
+                             GET_EXISTS, GET_DOES_NOT_EXIST,
+                             watchChecker, this::alwaysReplaceResource);
+        } else {
+            // if we should be deleting, then just try to delete it (same level of effort as checking)
+            deleteResource(client, listener, logger, "/_xpack/watcher/watch", watchId.get(),
+                           "monitoring cluster alert",
+                           resourceOwnerName, "monitoring cluster");
         }
-
-        // if we should be deleting, then just try to delete it (same level of effort as checking)
-        final boolean deleted = deleteResource(client, logger, "/_xpack/watcher/watch", watchId.get(),
-                                               "monitoring cluster alert",
-                                               resourceOwnerName, "monitoring cluster");
-
-        return deleted ? CheckResponse.EXISTS : CheckResponse.ERROR;
     }
 
     /**
      * Publish the missing {@linkplain #watchId Watch}.
      */
     @Override
-    protected boolean doPublish(final RestClient client) {
+    protected void doPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        return putResource(client, logger,
+        putResource(client, listener, logger,
-                           "/_xpack/watcher/watch", watchId.get(), this::watchToHttpEntity, "monitoring cluster alert",
+                    "/_xpack/watcher/watch", watchId.get(), this::watchToHttpEntity, "monitoring cluster alert",
-                           resourceOwnerName, "monitoring cluster");
+                    resourceOwnerName, "monitoring cluster");
     }
 
     /**

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporter.java

@@ -16,6 +16,7 @@ import org.apache.http.nio.conn.ssl.SSLIOSessionStrategy;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.elasticsearch.Version;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.client.RestClientBuilder;
 import org.elasticsearch.client.sniff.ElasticsearchNodesSniffer;
@@ -38,6 +39,7 @@ import org.elasticsearch.xpack.core.ssl.SSLConfiguration;
 import org.elasticsearch.xpack.core.ssl.SSLConfigurationSettings;
 import org.elasticsearch.xpack.core.ssl.SSLService;
 import org.elasticsearch.xpack.monitoring.exporter.ClusterAlertsUtil;
+import org.elasticsearch.xpack.monitoring.exporter.ExportBulk;
 import org.elasticsearch.xpack.monitoring.exporter.Exporter;
 import org.joda.time.format.DateTimeFormatter;
 
@@ -661,12 +663,8 @@ public class HttpExporter extends Exporter {
         }
     }
 
-    /**
+    @Override
-     * Determine if this {@link HttpExporter} is ready to use.
+    public void openBulk(final ActionListener<ExportBulk> listener) {
-     *
-     * @return {@code true} if it is ready. {@code false} if not.
-     */
-    boolean isExporterReady() {
         final boolean canUseClusterAlerts = config.licenseState().isMonitoringClusterAlertsAllowed();
 
         // if this changes between updates, then we need to add OR remove the watches
@@ -674,19 +672,16 @@ public class HttpExporter extends Exporter {
             resource.markDirty();
         }
 
-        // block until all resources are verified to exist
+        resource.checkAndPublishIfDirty(client, ActionListener.wrap((success) -> {
-        return resource.checkAndPublishIfDirty(client);
+            if (success) {
-    }
+                final String name = "xpack.monitoring.exporters." + config.name();
 
-    @Override
+                listener.onResponse(new HttpExportBulk(name, client, defaultParams, dateTimeFormatter, threadContext));
-    public HttpExportBulk openBulk() {
+            } else {
-        // block until all resources are verified to exist
+                // we're not ready yet, so keep waiting
-        if (isExporterReady()) {
+                listener.onResponse(null);
-            String name = "xpack.monitoring.exporters." + config.name();
+            }
-            return new HttpExportBulk(name, client, defaultParams, dateTimeFormatter, threadContext);
+        }, listener::onFailure));
-        }
-
-        return null;
     }
 
     @Override

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpResource.java

@@ -5,6 +5,7 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 
 import java.util.Objects;
@@ -83,7 +84,7 @@ public abstract class HttpResource {
      * Determine if the resource needs to be checked.
      *
      * @return {@code true} to indicate that the resource should block follow-on actions that require it.
-     * @see #checkAndPublish(RestClient)
+     * @see #checkAndPublish(RestClient, ActionListener)
      */
     public boolean isDirty() {
         return state.get() != State.CLEAN;
@@ -101,35 +102,22 @@ public abstract class HttpResource {
      * <p>
      * Expected usage:
      * <pre><code>
-     * if (resource.checkAndPublishIfDirty(client)) {
+     * resource.checkAndPublishIfDirty(client, ActionListener.wrap((success) -&gt; {
-     *     // use client with resources having been verified
+     *     if (success) {
-     * }
+     *         // use client with resources having been verified
+     *     }
+     * }, listener::onFailure);
      * </code></pre>
      *
      * @param client The REST client to make the request(s).
-     * @return {@code true} if the resource is available for use. {@code false} to stop.
+     * @param listener Returns {@code true} if the resource is available for use. {@code false} to stop.
      */
-    public final boolean checkAndPublishIfDirty(final RestClient client) {
+    public final void checkAndPublishIfDirty(final RestClient client, final ActionListener<Boolean> listener) {
-        final State state = this.state.get();
+        if (state.get() == State.CLEAN) {
-
+            listener.onResponse(true);
-        // get in line and wait until the check passes or fails if it's checking now, or start checking
+        } else {
-        return state == State.CLEAN || blockUntilCheckAndPublish(client);
+            checkAndPublish(client, listener);
-    }
+        }
-
-    /**
-     * Invoked by {@link #checkAndPublishIfDirty(RestClient)} to block incase {@link #checkAndPublish(RestClient)} is in the middle of
-     * {@linkplain State#CHECKING checking}.
-     * <p>
-     * Unlike {@link #isDirty()} and {@link #checkAndPublishIfDirty(RestClient)}, this is {@code synchronized} in order to prevent
-     * double-execution and it invokes {@link #checkAndPublish(RestClient)} if it's {@linkplain State#DIRTY dirty}.
-     *
-     * @param client The REST client to make the request(s).
-     * @return {@code true} if the resource is available for use. {@code false} to stop.
-     */
-    private synchronized boolean blockUntilCheckAndPublish(final RestClient client) {
-        final State state = this.state.get();
-
-        return state == State.CLEAN || (state == State.DIRTY && checkAndPublish(client));
     }
 
     /**
@@ -143,30 +131,30 @@ public abstract class HttpResource {
      * still be dirty at the end, but the success of it will still return based on the checks it ran.
      *
      * @param client The REST client to make the request(s).
-     * @return {@code true} if the resource is available for use. {@code false} to stop.
+     * @param listener Returns {@code true} if the resource is available for use. {@code false} to stop.
      * @see #isDirty()
      */
-    public final synchronized boolean checkAndPublish(final RestClient client) {
+    public final void checkAndPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        // we always check when asked, regardless of clean or dirty
+        // we always check when asked, regardless of clean or dirty, but we do not run parallel checks
-        state.set(State.CHECKING);
+        if (state.getAndSet(State.CHECKING) != State.CHECKING) {
-
+            doCheckAndPublish(client, ActionListener.wrap(success -> {
-        boolean success = false;
+                state.compareAndSet(State.CHECKING, success ? State.CLEAN : State.DIRTY);
-
+                listener.onResponse(success);
-        try {
+            }, e -> {
-            success = doCheckAndPublish(client);
+                state.compareAndSet(State.CHECKING, State.DIRTY);
-        } finally {
+                listener.onFailure(e);
-            state.compareAndSet(State.CHECKING, success ? State.CLEAN : State.DIRTY);
+            }));
+        } else {
+            listener.onResponse(false);
         }
-
-        return success;
     }
 
     /**
      * Perform whatever is necessary to check and publish this {@link HttpResource}.
      *
      * @param client The REST client to make the request(s).
-     * @return {@code true} if the resource is available for use. {@code false} to stop.
+     * @param listener Returns {@code true} if the resource is available for use. {@code false} to stop.
      */
-    protected abstract boolean doCheckAndPublish(RestClient client);
+    protected abstract void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener);
 
 }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/MultiHttpResource.java

@@ -5,8 +5,10 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import java.util.Iterator;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 
 import java.util.Collections;
@@ -38,6 +40,10 @@ public class MultiHttpResource extends HttpResource {
     public MultiHttpResource(final String resourceOwnerName, final List<? extends HttpResource> resources) {
         super(resourceOwnerName);
 
+        if (resources.isEmpty()) {
+            throw new IllegalArgumentException("[resources] cannot be empty");
+        }
+
         this.resources = Collections.unmodifiableList(resources);
     }
 
@@ -54,22 +60,34 @@ public class MultiHttpResource extends HttpResource {
      * Check and publish all {@linkplain #resources sub-resources}.
      */
     @Override
-    protected boolean doCheckAndPublish(RestClient client) {
+    protected void doCheckAndPublish(final RestClient client, final ActionListener<Boolean> listener) {
         logger.trace("checking sub-resources existence and publishing on the [{}]", resourceOwnerName);
 
-        boolean exists = true;
+        final Iterator<HttpResource> iterator = resources.iterator();
 
         // short-circuits on the first failure, thus marking the whole thing dirty
-        for (final HttpResource resource : resources) {
+        iterator.next().checkAndPublish(client, new ActionListener<Boolean>() {
-            if (resource.checkAndPublish(client) == false) {
+
-                exists = false;
+            @Override
-                break;
+            public void onResponse(final Boolean success) {
+                // short-circuit on the first failure
+                if (success && iterator.hasNext()) {
+                    iterator.next().checkAndPublish(client, this);
+                } else {
+                    logger.trace("all sub-resources exist [{}] on the [{}]", success, resourceOwnerName);
+
+                    listener.onResponse(success);
+                }
             }
-        }
 
-        logger.trace("all sub-resources exist [{}] on the [{}]", exists, resourceOwnerName);
+            @Override
+            public void onFailure(final Exception e) {
+                logger.trace("all sub-resources exist [false] on the [{}]", resourceOwnerName);
 
-        return exists;
+                listener.onFailure(e);
+            }
+
+        });
     }
 
 }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/PipelineHttpResource.java

@@ -10,6 +10,7 @@ import org.apache.http.entity.ByteArrayEntity;
 import org.apache.http.entity.ContentType;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.Nullable;
 import org.elasticsearch.common.unit.TimeValue;
@@ -58,21 +59,21 @@ public class PipelineHttpResource extends PublishableHttpResource {
      * Determine if the current {@linkplain #pipelineName pipeline} exists.
      */
     @Override
-    protected CheckResponse doCheck(final RestClient client) {
+    protected void doCheck(final RestClient client, final ActionListener<Boolean> listener) {
-        return versionCheckForResource(client, logger,
+        versionCheckForResource(client, listener, logger,
-                                       "/_ingest/pipeline", pipelineName, "monitoring pipeline",
+                                "/_ingest/pipeline", pipelineName, "monitoring pipeline",
-                                       resourceOwnerName, "monitoring cluster",
+                                resourceOwnerName, "monitoring cluster",
-                                       XContentType.JSON.xContent(), MonitoringTemplateUtils.LAST_UPDATED_VERSION);
+                                XContentType.JSON.xContent(), MonitoringTemplateUtils.LAST_UPDATED_VERSION);
     }
 
     /**
      * Publish the current {@linkplain #pipelineName pipeline}.
      */
     @Override
-    protected boolean doPublish(final RestClient client) {
+    protected void doPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        return putResource(client, logger,
+        putResource(client, listener, logger,
-                           "/_ingest/pipeline", pipelineName, this::pipelineToHttpEntity, "monitoring pipeline",
+                    "/_ingest/pipeline", pipelineName, this::pipelineToHttpEntity, "monitoring pipeline",
-                           resourceOwnerName, "monitoring cluster");
+                    resourceOwnerName, "monitoring cluster");
     }
 
     /**

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/PublishableHttpResource.java

@@ -9,13 +9,14 @@ import org.apache.http.HttpEntity;
 import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.message.ParameterizedMessage;
 import org.apache.logging.log4j.util.Supplier;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.ResponseException;
+import org.elasticsearch.client.ResponseListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.CheckedFunction;
 import org.elasticsearch.common.Nullable;
-import org.elasticsearch.common.collect.Tuple;
 import org.elasticsearch.common.unit.TimeValue;
 import org.elasticsearch.common.util.set.Sets;
 import org.elasticsearch.common.xcontent.XContent;
@@ -33,33 +34,11 @@ import java.util.stream.Collectors;
  * {@code PublishableHttpResource} represents an {@link HttpResource} that is a single file or object that can be checked <em>and</em>
  * published in the event that the check does not pass.
  *
- * @see #doCheck(RestClient)
+ * @see #doCheck(RestClient, ActionListener)
- * @see #doPublish(RestClient)
+ * @see #doPublish(RestClient, ActionListener)
  */
 public abstract class PublishableHttpResource extends HttpResource {
 
-    /**
-     * {@code CheckResponse} provides a ternary state for {@link #doCheck(RestClient)}.
-     */
-    public enum CheckResponse {
-
-        /**
-         * The check found the resource, so nothing needs to be published.
-         * <p>
-         * This can also be used to skip the publishing portion if desired.
-         */
-        EXISTS,
-        /**
-         * The check did not find the resource, so we need to attempt to publish it.
-         */
-        DOES_NOT_EXIST,
-        /**
-         * The check hit an unexpected exception that should block publishing attempts until it can check again.
-         */
-        ERROR
-
-    }
-
     /**
      * A value that will never match anything in the JSON response body, thus limiting it to "{}".
      */
@@ -142,56 +121,27 @@ public abstract class PublishableHttpResource extends HttpResource {
      * Perform whatever is necessary to check and publish this {@link PublishableHttpResource}.
      *
      * @param client The REST client to make the request(s).
-     * @return {@code true} if the resource is available for use. {@code false} to stop.
+     * @param listener Returns {@code true} if the resource is available for use. {@code false} to stop.
      */
     @Override
-    protected final boolean doCheckAndPublish(final RestClient client) {
+    protected final void doCheckAndPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        final CheckResponse check = doCheck(client);
+        doCheck(client, ActionListener.wrap(exists -> {
-
+            if (exists) {
-        // errors cause a dead-stop
+                // it already exists, so we can skip publishing it
-        return check != CheckResponse.ERROR && (check == CheckResponse.EXISTS || doPublish(client));
+                listener.onResponse(true);
+            } else {
+                doPublish(client, listener);
+            }
+        }, listener::onFailure));
     }
 
     /**
      * Determine if the current resource exists.
-     * <ul>
-     * <li>
-     *     {@link CheckResponse#EXISTS EXISTS} will <em>not</em> run {@link #doPublish(RestClient)} and mark this as <em>not</em> dirty.
-     * </li>
-     * <li>
-     *     {@link CheckResponse#DOES_NOT_EXIST DOES_NOT_EXIST} will run {@link #doPublish(RestClient)}, which determines the dirtiness.
-     * </li>
-     * <li>{@link CheckResponse#ERROR ERROR} will <em>not</em> run {@link #doPublish(RestClient)} and mark this as dirty.</li>
-     * </ul>
      *
      * @param client The REST client to make the request(s).
-     * @return Never {@code null}.
+     * @param listener Returns {@code true} if the resource already available to use. {@code false} otherwise.
      */
-    protected abstract CheckResponse doCheck(RestClient client);
+    protected abstract void doCheck(RestClient client, ActionListener<Boolean> listener);
-
-    /**
-     * Determine if the current {@code resourceName} exists at the {@code resourceBasePath} endpoint.
-     * <p>
-     * This provides the base-level check for any resource that does not need to care about its response beyond existence (and likely does
-     * not need to inspect its contents).
-     *
-     * @param client The REST client to make the request(s).
-     * @param logger The logger to use for status messages.
-     * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template").
-     * @param resourceName The name of the resource (e.g., "template123").
-     * @param resourceType The type of resource (e.g., "monitoring template").
-     * @param resourceOwnerName The user-recognizeable resource owner.
-     * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
-     * @return Never {@code null}.
-     */
-    protected CheckResponse simpleCheckForResource(final RestClient client, final Logger logger,
-                                                   final String resourceBasePath,
-                                                   final String resourceName, final String resourceType,
-                                                   final String resourceOwnerName, final String resourceOwnerType) {
-        return checkForResource(client, logger, resourceBasePath, resourceName, resourceType, resourceOwnerName, resourceOwnerType,
-                                GET_EXISTS, GET_DOES_NOT_EXIST)
-                    .v1();
-    }
 
     /**
      * Determine if the current {@code resourceName} exists at the {@code resourceBasePath} endpoint with a version greater than or equal
@@ -210,6 +160,7 @@ public abstract class PublishableHttpResource extends HttpResource {
      * </code></pre>
      *
      * @param client The REST client to make the request(s).
+     * @param listener Returns {@code true} if the resource was successfully published. {@code false} otherwise.
      * @param logger The logger to use for status messages.
      * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template").
      * @param resourceName The name of the resource (e.g., "template123").
@@ -218,73 +169,23 @@ public abstract class PublishableHttpResource extends HttpResource {
      * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
      * @param xContent The XContent used to parse the response.
      * @param minimumVersion The minimum version allowed without being replaced (expected to be the last updated version).
-     * @return Never {@code null}.
      */
-    protected CheckResponse versionCheckForResource(final RestClient client, final Logger logger,
+    protected void versionCheckForResource(final RestClient client,
-                                                    final String resourceBasePath,
+                                           final ActionListener<Boolean> listener,
-                                                    final String resourceName, final String resourceType,
+                                           final Logger logger,
-                                                    final String resourceOwnerName, final String resourceOwnerType,
+                                           final String resourceBasePath,
-                                                    final XContent xContent, final int minimumVersion) {
+                                           final String resourceName,
+                                           final String resourceType,
+                                           final String resourceOwnerName,
+                                           final String resourceOwnerType,
+                                           final XContent xContent,
+                                           final int minimumVersion) {
         final CheckedFunction<Response, Boolean, IOException> responseChecker =
-                (response) -> shouldReplaceResource(response, xContent, resourceName, minimumVersion);
+            (response) -> shouldReplaceResource(response, xContent, resourceName, minimumVersion);
 
-        return versionCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, resourceOwnerName, resourceOwnerType,
+        checkForResource(client, listener, logger,
-                                       responseChecker);
+                         resourceBasePath, resourceName, resourceType, resourceOwnerName, resourceOwnerType,
-    }
+                         GET_EXISTS, GET_DOES_NOT_EXIST, responseChecker, this::alwaysReplaceResource);
-
-    /**
-     * Determine if the current {@code resourceName} exists at the {@code resourceBasePath} endpoint with a version greater than or equal
-     * to the expected version.
-     * <p>
-     * This provides the base-level check for any resource that does not need to care about its response beyond existence (and likely does
-     * not need to inspect its contents).
-     * <p>
-     * This expects responses in the form of:
-     * <pre><code>
-     * {
-     *   "resourceName": {
-     *     "version": 6000002
-     *   }
-     * }
-     * </code></pre>
-     *
-     * @param client The REST client to make the request(s).
-     * @param logger The logger to use for status messages.
-     * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template").
-     * @param resourceName The name of the resource (e.g., "template123").
-     * @param resourceType The type of resource (e.g., "monitoring template").
-     * @param resourceOwnerName The user-recognizeable resource owner.
-     * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
-     * @param responseChecker Determine if the resource should be replaced given the response.
-     * @return Never {@code null}.
-     */
-    protected CheckResponse versionCheckForResource(final RestClient client, final Logger logger,
-                                                    final String resourceBasePath,
-                                                    final String resourceName, final String resourceType,
-                                                    final String resourceOwnerName, final String resourceOwnerType,
-                                                    final CheckedFunction<Response, Boolean, IOException> responseChecker) {
-        final Tuple<CheckResponse, Response> response =
-                checkForResource(client, logger, resourceBasePath, resourceName, resourceType, resourceOwnerName, resourceOwnerType,
-                                 GET_EXISTS, GET_DOES_NOT_EXIST);
-
-        final CheckResponse checkResponse = response.v1();
-
-        // if the template exists, then we also need to check its version
-        if (checkResponse == CheckResponse.EXISTS) {
-            try {
-                // replace the resource because the version is below what was required
-                if (responseChecker.apply(response.v2())) {
-                    return CheckResponse.DOES_NOT_EXIST;
-                }
-            } catch (IOException | RuntimeException e) {
-                logger.error((Supplier<?>) () -> new ParameterizedMessage("failed to parse [{}/{}] on the [{}]",
-                                                                          resourceBasePath, resourceName, resourceOwnerName), e);
-
-                return CheckResponse.ERROR;
-            }
-        }
-
-        return checkResponse;
     }
 
     /**
@@ -293,6 +194,7 @@ public abstract class PublishableHttpResource extends HttpResource {
      * This provides the base-level check for any resource that cares about existence and also its contents.
      *
      * @param client The REST client to make the request(s).
+     * @param listener Returns {@code true} if the resource was successfully published. {@code false} otherwise.
      * @param logger The logger to use for status messages.
      * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template"), if any.
      * @param resourceName The name of the resource (e.g., "template123").
@@ -301,76 +203,99 @@ public abstract class PublishableHttpResource extends HttpResource {
      * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
      * @param exists Response codes that represent {@code EXISTS}.
      * @param doesNotExist Response codes that represent {@code DOES_NOT_EXIST}.
-     * @return Never {@code null} pair containing the checked response and the returned response.
+     * @param responseChecker Returns {@code true} if the resource should be replaced.
-     *         The response will only ever be {@code null} if none was returned.
+     * @param doesNotExistResponseChecker Returns {@code true} if the resource should be replaced.
-     * @see #simpleCheckForResource(RestClient, Logger, String, String, String, String, String)
      */
-    protected Tuple<CheckResponse, Response> checkForResource(final RestClient client, final Logger logger,
+    protected void checkForResource(final RestClient client,
-                                                              final String resourceBasePath,
+                                    final ActionListener<Boolean> listener,
-                                                              final String resourceName, final String resourceType,
+                                    final Logger logger,
-                                                              final String resourceOwnerName, final String resourceOwnerType,
+                                    final String resourceBasePath,
-                                                              final Set<Integer> exists, final Set<Integer> doesNotExist) {
+                                    final String resourceName,
+                                    final String resourceType,
+                                    final String resourceOwnerName,
+                                    final String resourceOwnerType,
+                                    final Set<Integer> exists,
+                                    final Set<Integer> doesNotExist,
+                                    final CheckedFunction<Response, Boolean, IOException> responseChecker,
+                                    final CheckedFunction<Response, Boolean, IOException> doesNotExistResponseChecker) {
         logger.trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
 
-
         final Request request = new Request("GET", resourceBasePath + "/" + resourceName);
         addParameters(request);
         // avoid exists and DNE parameters from being an exception by default
         final Set<Integer> expectedResponseCodes = Sets.union(exists, doesNotExist);
         request.addParameter("ignore", expectedResponseCodes.stream().map(i -> i.toString()).collect(Collectors.joining(",")));
 
-        try {
+        client.performRequestAsync(request, new ResponseListener() {
-            final Response response = client.performRequest(request);
-            final int statusCode = response.getStatusLine().getStatusCode();
 
-            // checking the content is the job of whoever called this function by checking the tuple's response
+            @Override
-            if (exists.contains(statusCode)) {
+            public void onSuccess(final Response response) {
-                logger.debug("{} [{}] found on the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+                try {
+                    final int statusCode = response.getStatusLine().getStatusCode();
 
-                return new Tuple<>(CheckResponse.EXISTS, response);
+                    // checking the content is the job of whoever called this function by checking the tuple's response
-            } else if (doesNotExist.contains(statusCode)) {
+                    if (exists.contains(statusCode)) {
-                logger.debug("{} [{}] does not exist on the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+                        logger.debug("{} [{}] found on the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
 
-                return new Tuple<>(CheckResponse.DOES_NOT_EXIST, response);
+                        // if we should replace it -- true -- then the resource "does not exist" as far as the caller is concerned
-            } else {
+                        listener.onResponse(false == responseChecker.apply(response));
-                throw new ResponseException(response);
+
+                    } else if (doesNotExist.contains(statusCode)) {
+                        logger.debug("{} [{}] does not exist on the [{}] {}",
+                                     resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+
+                        // if we should replace it -- true -- then the resource "does not exist" as far as the caller is concerned
+                        listener.onResponse(false == doesNotExistResponseChecker.apply(response));
+                    } else {
+                        onFailure(new ResponseException(response));
+                    }
+                } catch (Exception e) {
+                    logger.error((Supplier<?>) () -> new ParameterizedMessage("failed to parse [{}/{}] on the [{}]",
+                                                                              resourceBasePath, resourceName, resourceOwnerName),
+                                 e);
+
+                    onFailure(e);
+                }
             }
-        } catch (final ResponseException e) {
-            final Response response = e.getResponse();
-            final int statusCode = response.getStatusLine().getStatusCode();
 
-            logger.error((Supplier<?>) () ->
+            @Override
-                    new ParameterizedMessage("failed to verify {} [{}] on the [{}] {} with status code [{}]",
+            public void onFailure(final Exception exception) {
-                                             resourceType, resourceName, resourceOwnerName, resourceOwnerType, statusCode),
+                if (exception instanceof ResponseException) {
-                    e);
+                    final Response response = ((ResponseException)exception).getResponse();
+                    final int statusCode = response.getStatusLine().getStatusCode();
 
-            // weirder failure than below; block responses just like other unexpected failures
+                    logger.error((Supplier<?>) () ->
-            return new Tuple<>(CheckResponse.ERROR, response);
+                                 new ParameterizedMessage("failed to verify {} [{}] on the [{}] {} with status code [{}]",
-        } catch (IOException | RuntimeException e) {
+                                                          resourceType, resourceName, resourceOwnerName, resourceOwnerType, statusCode),
-            logger.error((Supplier<?>) () ->
+                                 exception);
-                    new ParameterizedMessage("failed to verify {} [{}] on the [{}] {}",
+                } else {
-                                             resourceType, resourceName, resourceOwnerName, resourceOwnerType),
+                    logger.error((Supplier<?>) () ->
-                    e);
+                                 new ParameterizedMessage("failed to verify {} [{}] on the [{}] {}",
+                                                          resourceType, resourceName, resourceOwnerName, resourceOwnerType),
+                                 exception);
+                }
 
-            // do not attempt to publish the resource because we're in a broken state
+                listener.onFailure(exception);
-            return new Tuple<>(CheckResponse.ERROR, null);
+            }
-        }
+
+        });
     }
 
     /**
      * Publish the current resource.
      * <p>
-     * This is only invoked if {@linkplain #doCheck(RestClient) the check} fails.
+     * This is only invoked if {@linkplain #doCheck(RestClient, ActionListener) the check} fails.
      *
      * @param client The REST client to make the request(s).
-     * @return {@code true} if it exists.
+     * @param listener Returns {@code true} if the resource is available to use. Otherwise {@code false}.
      */
-    protected abstract boolean doPublish(RestClient client);
+    protected abstract void doPublish(RestClient client, ActionListener<Boolean> listener);
 
     /**
      * Upload the {@code resourceName} to the {@code resourceBasePath} endpoint.
      *
      * @param client The REST client to make the request(s).
+     * @param listener Returns {@code true} if the resource was successfully published. {@code false} otherwise.
      * @param logger The logger to use for status messages.
      * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template").
      * @param resourceName The name of the resource (e.g., "template123").
@@ -379,39 +304,49 @@ public abstract class PublishableHttpResource extends HttpResource {
      * @param resourceOwnerName The user-recognizeable resource owner.
      * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
      */
-    protected boolean putResource(final RestClient client, final Logger logger,
+    protected void putResource(final RestClient client,
-                                  final String resourceBasePath,
+                               final ActionListener<Boolean> listener,
-                                  final String resourceName, final java.util.function.Supplier<HttpEntity> body,
+                               final Logger logger,
-                                  final String resourceType,
+                               final String resourceBasePath,
-                                  final String resourceOwnerName, final String resourceOwnerType) {
+                               final String resourceName,
+                               final java.util.function.Supplier<HttpEntity> body,
+                               final String resourceType,
+                               final String resourceOwnerName,
+                               final String resourceOwnerType) {
         logger.trace("uploading {} [{}] to the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
 
-        boolean success = false;
 
         final Request request = new Request("PUT", resourceBasePath + "/" + resourceName);
         addParameters(request);
         request.setEntity(body.get());
 
-        try {
+        client.performRequestAsync(request, new ResponseListener() {
-            final Response response = client.performRequest(request);
-            final int statusCode = response.getStatusLine().getStatusCode();
 
-            // 200 or 201
+            @Override
-            if (statusCode == RestStatus.OK.getStatus() || statusCode == RestStatus.CREATED.getStatus()) {
+            public void onSuccess(final Response response) {
-                logger.debug("{} [{}] uploaded to the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+                final int statusCode = response.getStatusLine().getStatusCode();
 
-                success = true;
+                // 200 or 201
-            } else {
+                if (statusCode == RestStatus.OK.getStatus() || statusCode == RestStatus.CREATED.getStatus()) {
-                throw new RuntimeException("[" + resourceBasePath + "/" + resourceName + "] responded with [" + statusCode + "]");
+                    logger.debug("{} [{}] uploaded to the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+
+                    listener.onResponse(true);
+                } else {
+                    onFailure(new RuntimeException("[" + resourceBasePath + "/" + resourceName + "] responded with [" + statusCode + "]"));
+                }
             }
-        } catch (IOException | RuntimeException e) {
-            logger.error((Supplier<?>) () ->
-                    new ParameterizedMessage("failed to upload {} [{}] on the [{}] {}",
-                                             resourceType, resourceName, resourceOwnerName, resourceOwnerType),
-                    e);
-        }
 
-        return success;
+            @Override
+            public void onFailure(final Exception exception) {
+                logger.error((Supplier<?>) () ->
+                             new ParameterizedMessage("failed to upload {} [{}] on the [{}] {}",
+                                                      resourceType, resourceName, resourceOwnerName, resourceOwnerType),
+                             exception);
+
+                listener.onFailure(exception);
+            }
+
+        });
     }
 
     /**
@@ -422,48 +357,59 @@ public abstract class PublishableHttpResource extends HttpResource {
      * responses will result in {@code false} and logged failure.
      *
      * @param client The REST client to make the request(s).
+     * @param listener Returns {@code true} if it successfully deleted the item; <em>never</em> {@code false}.
      * @param logger The logger to use for status messages.
      * @param resourceBasePath The base path/endpoint to check for the resource (e.g., "/_template").
      * @param resourceName The name of the resource (e.g., "template123").
      * @param resourceType The type of resource (e.g., "monitoring template").
      * @param resourceOwnerName The user-recognizeable resource owner.
      * @param resourceOwnerType The type of resource owner being dealt with (e.g., "monitoring cluster").
-     * @return {@code true} if it successfully deleted the item; otherwise {@code false}.
      */
-    protected boolean deleteResource(final RestClient client, final Logger logger,
+    protected void deleteResource(final RestClient client,
-                                     final String resourceBasePath, final String resourceName,
+                                  final ActionListener<Boolean> listener,
-                                     final String resourceType,
+                                  final Logger logger,
-                                     final String resourceOwnerName, final String resourceOwnerType) {
+                                  final String resourceBasePath,
+                                  final String resourceName,
+                                  final String resourceType,
+                                  final String resourceOwnerName,
+                                  final String resourceOwnerType) {
         logger.trace("deleting {} [{}] from the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
 
-        boolean success = false;
+        final Request request = new Request("DELETE", resourceBasePath + "/" + resourceName);
-
-        Request request = new Request("DELETE", resourceBasePath + "/" + resourceName);
         addParameters(request);
+
         if (false == parameters.containsKey("ignore")) {
             // avoid 404 being an exception by default
             request.addParameter("ignore", Integer.toString(RestStatus.NOT_FOUND.getStatus()));
         }
 
-        try {
+        client.performRequestAsync(request, new ResponseListener() {
-            final Response response = client.performRequest(request);
-            final int statusCode = response.getStatusLine().getStatusCode();
 
-            // 200 or 404 (not found is just as good as deleting it!)
+            @Override
-            if (statusCode == RestStatus.OK.getStatus() || statusCode == RestStatus.NOT_FOUND.getStatus()) {
+            public void onSuccess(Response response) {
-                logger.debug("{} [{}] deleted from the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+                final int statusCode = response.getStatusLine().getStatusCode();
 
-                success = true;
+                // 200 or 404 (not found is just as good as deleting it!)
-            } else {
+                if (statusCode == RestStatus.OK.getStatus() || statusCode == RestStatus.NOT_FOUND.getStatus()) {
-                throw new RuntimeException("[" + resourceBasePath + "/" + resourceName + "] responded with [" + statusCode + "]");
+                    logger.debug("{} [{}] deleted from the [{}] {}", resourceType, resourceName, resourceOwnerName, resourceOwnerType);
+
+                    listener.onResponse(true);
+                } else {
+                    onFailure(new RuntimeException("[" + resourceBasePath + "/" + resourceName + "] responded with [" + statusCode + "]"));
+                }
             }
-        } catch (IOException | RuntimeException e) {
-            logger.error((Supplier<?>) () -> new ParameterizedMessage("failed to delete {} [{}] on the [{}] {}",
-                                                                      resourceType, resourceName, resourceOwnerName, resourceOwnerType),
-                         e);
-        }
 
-        return success;
+            @Override
+            public void onFailure(Exception exception) {
+                logger.error((Supplier<?>) () ->
+                             new ParameterizedMessage("failed to delete {} [{}] on the [{}] {}",
+                                                      resourceType, resourceName, resourceOwnerName, resourceOwnerType),
+                             exception);
+
+                listener.onFailure(exception);
+            }
+
+        });
     }
 
     /**
@@ -498,18 +444,27 @@ public abstract class PublishableHttpResource extends HttpResource {
             final Map<String, Object> resource = (Map<String, Object>) resources.get(resourceName);
             final Object version = resource != null ? resource.get("version") : null;
 
-            // if we don't have it (perhaps more fields were returned), then we need to replace it
+            // the version in the template is expected to include the alpha/beta/rc codes as well
             if (version instanceof Number) {
-                // the version in the template is expected to include the alpha/beta/rc codes as well
+                return ((Number) version).intValue() < minimumVersion;
-                return ((Number)version).intValue() < minimumVersion;
             }
         }
 
         return true;
     }
 
-    private void addParameters(Request request) {
+    /**
-        for (Map.Entry<String, String> param : parameters.entrySet()) {
+     * A useful placeholder for {@link CheckedFunction}s that want to always return {@code true}.
+     *
+     * @param response Unused.
+     * @return Always {@code true}.
+     */
+    protected boolean alwaysReplaceResource(final Response response) {
+        return true;
+    }
+
+    private void addParameters(final Request request) {
+        for (final Map.Entry<String, String> param : parameters.entrySet()) {
             request.addParameter(param.getKey(), param.getValue());
         }
     }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/TemplateHttpResource.java

@@ -10,6 +10,7 @@ import org.apache.http.entity.ContentType;
 import org.apache.http.entity.StringEntity;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.Nullable;
 import org.elasticsearch.common.unit.TimeValue;
@@ -61,21 +62,21 @@ public class TemplateHttpResource extends PublishableHttpResource {
      * @see MonitoringTemplateUtils#LAST_UPDATED_VERSION
      */
     @Override
-    protected CheckResponse doCheck(final RestClient client) {
+    protected void doCheck(final RestClient client, final ActionListener<Boolean> listener) {
-        return versionCheckForResource(client, logger,
+        versionCheckForResource(client, listener, logger,
-                                       "/_template", templateName, "monitoring template",
+                                "/_template", templateName, "monitoring template",
-                                       resourceOwnerName, "monitoring cluster",
+                                resourceOwnerName, "monitoring cluster",
-                                       XContentType.JSON.xContent(), MonitoringTemplateUtils.LAST_UPDATED_VERSION);
+                                XContentType.JSON.xContent(), MonitoringTemplateUtils.LAST_UPDATED_VERSION);
     }
 
     /**
      * Publish the missing {@linkplain #templateName template}.
      */
     @Override
-    protected boolean doPublish(final RestClient client) {
+    protected void doPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        return putResource(client, logger,
+        putResource(client, listener, logger,
-                           "/_template", templateName, this::templateToHttpEntity, "monitoring template",
+                    "/_template", templateName, this::templateToHttpEntity, "monitoring template",
-                           resourceOwnerName, "monitoring cluster");
+                    resourceOwnerName, "monitoring cluster");
     }
 
     /**

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/VersionHttpResource.java

@@ -10,8 +10,10 @@ import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.message.ParameterizedMessage;
 import org.apache.logging.log4j.util.Supplier;
 import org.elasticsearch.Version;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
+import org.elasticsearch.client.ResponseListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.xcontent.XContentHelper;
 import org.elasticsearch.common.xcontent.json.JsonXContent;
@@ -50,22 +52,33 @@ public class VersionHttpResource extends HttpResource {
      * If it does not, then there is nothing that can be done except wait until it does. There is no publishing aspect to this operation.
      */
     @Override
-    protected boolean doCheckAndPublish(final RestClient client) {
+    protected void doCheckAndPublish(final RestClient client, final ActionListener<Boolean> listener) {
         logger.trace("checking [{}] to ensure that it supports the minimum version [{}]", resourceOwnerName, minimumVersion);
 
-        try {
+        final Request request = new Request("GET", "/");
-            Request request = new Request("GET", "/");
+        request.addParameter("filter_path", "version.number");
-            request.addParameter("filter_path", "version.number");
-            return validateVersion(client.performRequest(request));
-        } catch (IOException | RuntimeException e) {
-            logger.error(
-                    (Supplier<?>)() ->
-                        new ParameterizedMessage("failed to verify minimum version [{}] on the [{}] monitoring cluster",
-                                                 minimumVersion, resourceOwnerName),
-                    e);
-        }
 
-        return false;
+        client.performRequestAsync(request, new ResponseListener() {
+            @Override
+            public void onSuccess(final Response response) {
+                try {
+                    // malformed responses can cause exceptions during validation
+                    listener.onResponse(validateVersion(response));
+                } catch (Exception e) {
+                    onFailure(e);
+                }
+            }
+
+            @Override
+            public void onFailure(final Exception exception) {
+                logger.error((Supplier<?>) () ->
+                             new ParameterizedMessage("failed to verify minimum version [{}] on the [{}] monitoring cluster",
+                                                      minimumVersion, resourceOwnerName),
+                             exception);
+
+                listener.onFailure(exception);
+            }
+        });
     }
 
     /**

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/http/WatcherExistsHttpResource.java

@@ -7,12 +7,11 @@ package org.elasticsearch.xpack.monitoring.exporter.http;
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.message.ParameterizedMessage;
+import org.elasticsearch.action.ActionListener;
-import org.apache.logging.log4j.util.Supplier;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.cluster.service.ClusterService;
-import org.elasticsearch.common.collect.Tuple;
+import org.elasticsearch.common.CheckedFunction;
 import org.elasticsearch.common.util.set.Sets;
 import org.elasticsearch.common.xcontent.XContent;
 import org.elasticsearch.common.xcontent.XContentHelper;
@@ -82,49 +81,33 @@ public class WatcherExistsHttpResource extends PublishableHttpResource {
      * Watcher. We do the same thing if the current node is not the elected master node.
      */
     @Override
-    protected CheckResponse doCheck(final RestClient client) {
+    protected void doCheck(final RestClient client, final ActionListener<Boolean> listener) {
         // only the master manages watches
         if (clusterService.state().nodes().isLocalNodeElectedMaster()) {
-            return checkXPackForWatcher(client);
+            checkXPackForWatcher(client, listener);
+        } else {
+            // not the elected master
+            listener.onResponse(true);
         }
-
-        // not the elected master
-        return CheckResponse.EXISTS;
     }
 
     /**
      * Reach out to the remote cluster to determine the usability of Watcher.
      *
      * @param client The REST client to make the request(s).
-     * @return Never {@code null}.
+     * @param listener Returns {@code true} to <em>skip</em> cluster alert creation. {@code false} to check/create them.
      */
-    private CheckResponse checkXPackForWatcher(final RestClient client) {
+    private void checkXPackForWatcher(final RestClient client, final ActionListener<Boolean> listener) {
-        final Tuple<CheckResponse, Response> response =
+        final CheckedFunction<Response, Boolean, IOException> responseChecker =
-                checkForResource(client, logger,
+            (response) -> canUseWatcher(response, XContentType.JSON.xContent());
-                                 "", "_xpack", "watcher check",
+        // use DNE to pretend that we're all set; it means that Watcher is unusable
-                                 resourceOwnerName, "monitoring cluster",
+        final CheckedFunction<Response, Boolean, IOException> doesNotExistChecker = (response) -> false;
-                                 GET_EXISTS,
-                                 Sets.newHashSet(RestStatus.NOT_FOUND.getStatus(), RestStatus.BAD_REQUEST.getStatus()));
 
-        final CheckResponse checkResponse = response.v1();
+        checkForResource(client, listener, logger,
-
+                         "", "_xpack", "watcher check",
-        // if the response succeeds overall, then we have X-Pack, but we need to inspect to verify Watcher existence
+                         resourceOwnerName, "monitoring cluster",
-        if (checkResponse == CheckResponse.EXISTS) {
+                         GET_EXISTS, Sets.newHashSet(RestStatus.NOT_FOUND.getStatus(), RestStatus.BAD_REQUEST.getStatus()),
-            try {
+                         responseChecker, doesNotExistChecker);
-                if (canUseWatcher(response.v2(), XContentType.JSON.xContent())) {
-                    return CheckResponse.DOES_NOT_EXIST;
-                }
-            } catch (final IOException | RuntimeException e) {
-                logger.error((Supplier<?>) () -> new ParameterizedMessage("failed to parse [_xpack] on the [{}]", resourceOwnerName), e);
-
-                return CheckResponse.ERROR;
-            }
-        } else if (checkResponse == CheckResponse.ERROR) {
-            return CheckResponse.ERROR;
-        }
-
-        // we return _exists_ to SKIP the work of putting Watches because WATCHER does not exist, so follow-on work cannot succeed
-        return CheckResponse.EXISTS;
     }
 
     /**
@@ -148,9 +131,7 @@ public class WatcherExistsHttpResource extends PublishableHttpResource {
             final Map<String, Object> watcher = (Map<String, Object>) features.get("watcher");
 
             // if Watcher is both available _and_ enabled, then we can use it; either being true is not sufficient
-            if (Boolean.TRUE == watcher.get("available") && Boolean.TRUE == watcher.get("enabled")) {
+            return Boolean.TRUE == watcher.get("available") && Boolean.TRUE == watcher.get("enabled");
-                return true;
-            }
         }
 
         return false;
@@ -160,7 +141,7 @@ public class WatcherExistsHttpResource extends PublishableHttpResource {
      * Add Watches to the remote cluster.
      */
     @Override
-    protected boolean doPublish(final RestClient client) {
+    protected void doPublish(final RestClient client, final ActionListener<Boolean> listener) {
-        return watches.checkAndPublish(client);
+        watches.checkAndPublish(client, listener);
     }
 }

x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/exporter/local/LocalExporter.java

@@ -31,7 +31,6 @@ import org.elasticsearch.common.regex.Regex;
 import org.elasticsearch.common.unit.TimeValue;
 import org.elasticsearch.common.util.concurrent.ThreadContext;
 import org.elasticsearch.common.xcontent.XContentType;
-import org.elasticsearch.gateway.GatewayService;
 import org.elasticsearch.index.IndexNotFoundException;
 import org.elasticsearch.ingest.IngestMetadata;
 import org.elasticsearch.ingest.PipelineConfiguration;
@@ -49,6 +48,7 @@ import org.elasticsearch.xpack.core.watcher.transport.actions.get.GetWatchRespon
 import org.elasticsearch.xpack.core.watcher.watch.Watch;
 import org.elasticsearch.xpack.monitoring.cleaner.CleanerService;
 import org.elasticsearch.xpack.monitoring.exporter.ClusterAlertsUtil;
+import org.elasticsearch.xpack.monitoring.exporter.ExportBulk;
 import org.elasticsearch.xpack.monitoring.exporter.Exporter;
 import org.joda.time.DateTime;
 import org.joda.time.DateTimeZone;
@@ -138,11 +138,12 @@ public class LocalExporter extends Exporter implements ClusterStateListener, Cle
     }
 
     @Override
-    public LocalBulk openBulk() {
+    public void openBulk(final ActionListener<ExportBulk> listener) {
         if (state.get() != State.RUNNING) {
-            return null;
+            listener.onResponse(null);
+        } else {
+            listener.onResponse(resolveBulk(clusterService.state(), false));
         }
-        return resolveBulk(clusterService.state(), false);
     }
 
     @Override
@@ -161,13 +162,6 @@ public class LocalExporter extends Exporter implements ClusterStateListener, Cle
             return null;
         }
 
-        if (clusterState.blocks().hasGlobalBlock(GatewayService.STATE_NOT_RECOVERED_BLOCK)) {
-            // wait until the gateway has recovered from disk, otherwise we think may not have .monitoring-es-
-            // indices but they may not have been restored from the cluster state on disk
-            logger.debug("waiting until gateway has recovered from disk");
-            return null;
-        }
-
         // List of templates
         final Map<String, String> templates = Arrays.stream(MonitoringTemplateUtils.TEMPLATE_IDS)
                 .collect(Collectors.toMap(MonitoringTemplateUtils::templateName, MonitoringTemplateUtils::loadTemplate));

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/MonitoringFeatureSetTests.java

@@ -94,7 +94,7 @@ public class MonitoringFeatureSetTests extends ESTestCase {
                 exporterList.add(exporter);
             }
         }
-        when(exporters.iterator()).thenReturn(exporterList.iterator());
+        when(exporters.getEnabledExporters()).thenReturn(exporterList);
         when(monitoring.isMonitoringActive()).thenReturn(collectionEnabled);
 
         MonitoringFeatureSet featureSet = new MonitoringFeatureSet(Settings.EMPTY, monitoring, licenseState, exporters);

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/cleaner/AbstractIndicesCleanerTestCase.java

@@ -162,7 +162,7 @@ public abstract class AbstractIndicesCleanerTestCase extends MonitoringIntegTest
 
     protected CleanerService.Listener getListener() {
         Exporters exporters = internalCluster().getInstance(Exporters.class, internalCluster().getMasterName());
-        for (Exporter exporter : exporters) {
+        for (Exporter exporter : exporters.getEnabledExporters()) {
             if (exporter instanceof CleanerService.Listener) {
                 return (CleanerService.Listener) exporter;
             }

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/ExportersTests.java

@@ -8,6 +8,7 @@ package org.elasticsearch.xpack.monitoring.exporter;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Client;
 import org.elasticsearch.cluster.ClusterState;
+import org.elasticsearch.cluster.block.ClusterBlocks;
 import org.elasticsearch.cluster.metadata.MetaData;
 import org.elasticsearch.cluster.service.ClusterService;
 import org.elasticsearch.common.settings.ClusterSettings;
@@ -17,6 +18,7 @@ import org.elasticsearch.common.settings.SettingsException;
 import org.elasticsearch.common.util.concurrent.AbstractRunnable;
 import org.elasticsearch.common.util.concurrent.ThreadContext;
 import org.elasticsearch.common.xcontent.XContentBuilder;
+import org.elasticsearch.gateway.GatewayService;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.threadpool.ThreadPool;
@@ -50,6 +52,7 @@ import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.notNullValue;
 import static org.hamcrest.Matchers.nullValue;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 public class ExportersTests extends ESTestCase {
@@ -57,6 +60,7 @@ public class ExportersTests extends ESTestCase {
     private Map<String, Exporter.Factory> factories;
     private ClusterService clusterService;
     private ClusterState state;
+    private final ClusterBlocks blocks = mock(ClusterBlocks.class);
     private final MetaData metadata = mock(MetaData.class);
     private final XPackLicenseState licenseState = mock(XPackLicenseState.class);
     private ClusterSettings clusterSettings;
@@ -79,6 +83,7 @@ public class ExportersTests extends ESTestCase {
         clusterSettings = new ClusterSettings(Settings.EMPTY, settingsSet);
         when(clusterService.getClusterSettings()).thenReturn(clusterSettings);
         when(clusterService.state()).thenReturn(state);
+        when(state.blocks()).thenReturn(blocks);
         when(state.metaData()).thenReturn(metadata);
 
         // we always need to have the local exporter as it serves as the default one
@@ -210,6 +215,8 @@ public class ExportersTests extends ESTestCase {
     public void testExporterBlocksOnClusterState() {
         if (rarely()) {
             when(metadata.clusterUUID()).thenReturn(ClusterState.UNKNOWN_UUID);
+        } else if (rarely()) {
+            when(blocks.hasGlobalBlock(GatewayService.STATE_NOT_RECOVERED_BLOCK)).thenReturn(true);
         } else {
             when(state.version()).thenReturn(ClusterState.UNKNOWN_VERSION);
         }
@@ -223,7 +230,13 @@ public class ExportersTests extends ESTestCase {
 
         final Exporters exporters = new Exporters(settings.build(), factories, clusterService, licenseState, threadContext);
 
-        assertThat(exporters.openBulk(), nullValue());
+        // synchronously checks the cluster state
+        exporters.wrapExportBulk(ActionListener.wrap(
+            bulk -> assertThat(bulk, is(nullValue())),
+            e -> fail(e.getMessage())
+        ));
+
+        verify(state).blocks();
     }
 
     /**
@@ -284,7 +297,7 @@ public class ExportersTests extends ESTestCase {
         }
 
         assertThat(exceptions, empty());
-        for (Exporter exporter : exporters) {
+        for (Exporter exporter : exporters.getEnabledExporters()) {
             assertThat(exporter, instanceOf(CountingExporter.class));
             assertThat(((CountingExporter) exporter).getExportedCount(), equalTo(total));
         }
@@ -298,8 +311,8 @@ public class ExportersTests extends ESTestCase {
         }
 
         @Override
-        public ExportBulk openBulk() {
+        public void openBulk(final ActionListener<ExportBulk> listener) {
-            return mock(ExportBulk.class);
+            listener.onResponse(mock(ExportBulk.class));
         }
 
         @Override
@@ -318,19 +331,6 @@ public class ExportersTests extends ESTestCase {
         }
     }
 
-
-    static class MockFactory implements Exporter.Factory {
-
-        @Override
-        public Exporter create(Exporter.Config config) {
-            Exporter exporter = mock(Exporter.class);
-            when(exporter.name()).thenReturn(config.name());
-            when(exporter.openBulk()).thenReturn(mock(ExportBulk.class));
-            return exporter;
-        }
-
-    }
-
     static class CountingExporter extends Exporter {
 
         private static final AtomicInteger count = new AtomicInteger(0);
@@ -343,10 +343,11 @@ public class ExportersTests extends ESTestCase {
         }
 
         @Override
-        public ExportBulk openBulk() {
+        public void openBulk(final ActionListener<ExportBulk> listener) {
             CountingBulk bulk = new CountingBulk(config.type() + "#" + count.getAndIncrement(), threadContext);
             bulks.add(bulk);
-            return bulk;
+
+            listener.onResponse(bulk);
         }
 
         @Override

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/AbstractPublishableHttpResourceTestCase.java

@@ -11,18 +11,18 @@ import org.apache.http.RequestLine;
 import org.apache.http.StatusLine;
 import org.apache.http.entity.ContentType;
 import org.apache.http.entity.StringEntity;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.ResponseException;
+import org.elasticsearch.client.ResponseListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.Nullable;
 import org.elasticsearch.common.unit.TimeValue;
 import org.elasticsearch.common.util.set.Sets;
 import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.test.ESTestCase;
-import org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse;
 import org.mockito.ArgumentCaptor;
-import org.mockito.Mockito;
 
 import java.io.IOException;
 import java.util.Map;
@@ -30,11 +30,17 @@ import java.util.Set;
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
 
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.mockBooleanActionListener;
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.whenPerformRequestAsyncWith;
 import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.GET_DOES_NOT_EXIST;
 import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.GET_EXISTS;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.instanceOf;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyBoolean;
+import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.when;
 import static org.mockito.Mockito.verify;
 
@@ -48,96 +54,102 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
     protected final TimeValue masterTimeout = randomFrom(TimeValue.timeValueMinutes(5), TimeValue.MINUS_ONE, null);
 
     protected final RestClient client = mock(RestClient.class);
+    protected final ActionListener<Boolean> listener = mockBooleanActionListener();
 
     /**
-     * Perform {@link PublishableHttpResource#doCheck(RestClient) doCheck} against the {@code resource} and assert that it returns
+     * Perform {@link PublishableHttpResource#doCheck(RestClient, ActionListener) doCheck} against the {@code resource} and assert that it
-     * {@code EXISTS} given a {@link RestStatus} that is {@link RestStatus#OK}.
+     * returns {@code onResponse(false)} given a {@link RestStatus} that is not {@link RestStatus#OK}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
      * @param resourceName The resource name (e.g., the template or pipeline name).
      */
-    protected void assertCheckExists(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName)
+    protected void assertCheckDoesNotExist(final PublishableHttpResource resource,
-            throws IOException {
+                                           final String resourceBasePath,
-        doCheckWithStatusCode(resource, resourceBasePath, resourceName, successfulCheckStatus(), CheckResponse.EXISTS);
+                                           final String resourceName) {
+        doCheckWithStatusCode(resource, resourceBasePath, resourceName, notFoundCheckStatus(), false);
     }
 
     /**
-     * Perform {@link PublishableHttpResource#doCheck(RestClient) doCheck} against the {@code resource} and assert that it returns
+     * Perform {@link PublishableHttpResource#doCheck(RestClient, ActionListener) doCheck} against the {@code resource} that throws an
-     * {@code DOES_NOT_EXIST} given a {@link RestStatus} that is not {@link RestStatus#OK}.
+     * exception and assert that it returns {@code onFailure}.
-     *
-     * @param resource The resource to execute.
-     * @param resourceBasePath The base endpoint (e.g., "/_template")
-     * @param resourceName The resource name (e.g., the template or pipeline name).
-     */
-    protected void assertCheckDoesNotExist(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName)
-            throws IOException {
-        doCheckWithStatusCode(resource, resourceBasePath, resourceName, notFoundCheckStatus(), CheckResponse.DOES_NOT_EXIST);
-    }
-
-    /**
-     * Perform {@link PublishableHttpResource#doCheck(RestClient) doCheck} against the {@code resource} that throws an exception and assert
-     * that it returns {@code ERROR}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
      * @param resourceName The resource name (e.g., the template or pipeline name).
      */
     protected void assertCheckWithException(final PublishableHttpResource resource,
-                                            final String resourceBasePath, final String resourceName)
+                                            final String resourceBasePath, final String resourceName) {
-            throws IOException {
+        assertCheckWithException(resource, getParameters(resource.getParameters()), resourceBasePath, resourceName);
+    }
+
+    /**
+     * Perform {@link PublishableHttpResource#doCheck(RestClient, ActionListener) doCheck} against the {@code resource} that throws an
+     * exception and assert that it returns {@code onFailure}.
+     *
+     * @param resource The resource to execute.
+     * @param expectedParameters The test-supplied parameters for the {@code Request}.
+     * @param resourceBasePath The base endpoint (e.g., "/_template")
+     * @param resourceName The resource name (e.g., the template or pipeline name).
+     */
+    protected void assertCheckWithException(final PublishableHttpResource resource,
+                                            final Map<String, String> expectedParameters,
+                                            final String resourceBasePath, final String resourceName) {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final ResponseException responseException = responseException("GET", endpoint, failedCheckStatus());
         final Exception e = randomFrom(new IOException("expected"), new RuntimeException("expected"), responseException);
 
-        Request request = new Request("GET", endpoint);
+        final Request request = new Request("GET", endpoint);
-        addParameters(request, getParameters(resource.getParameters()));
+        addParameters(request, expectedParameters);
-        when(client.performRequest(request)).thenThrow(e);
+        whenPerformRequestAsyncWith(client, request, e);
 
-        assertThat(resource.doCheck(client), is(CheckResponse.ERROR));
+        resource.doCheck(client, listener);
+
+        verifyListener(null);
     }
 
     /**
-     * Perform {@link PublishableHttpResource#doCheck(RestClient) doCheck} against the {@code resource}, expecting a {@code DELETE}, and
+     * Perform {@link PublishableHttpResource#doCheck(RestClient, ActionListener) doCheck} against the {@code resource}, expecting a
-     * assert that it returns {@code EXISTS} given a {@link RestStatus} that is {@link RestStatus#OK} or {@link RestStatus#NOT_FOUND}.
+     * {@code DELETE}, and assert that it returns {@code onResponse(true)} given a {@link RestStatus} that is {@link RestStatus#OK} or
+     * {@link RestStatus#NOT_FOUND}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
      * @param resourceName The resource name (e.g., the template or pipeline name).
      */
     protected void assertCheckAsDeleteExists(final PublishableHttpResource resource,
-                                             final String resourceBasePath, final String resourceName)
+                                             final String resourceBasePath, final String resourceName) {
-            throws IOException {
         final RestStatus status = randomFrom(successfulCheckStatus(), notFoundCheckStatus());
 
-        doCheckAsDeleteWithStatusCode(resource, resourceBasePath, resourceName, status, CheckResponse.EXISTS);
+        doCheckAsDeleteWithStatusCode(resource, resourceBasePath, resourceName, status, true);
     }
 
     /**
-     * Perform {@link PublishableHttpResource#doCheck(RestClient) doCheck} against the {@code resource} that throws an exception and assert
+     * Perform {@link PublishableHttpResource#doCheck(RestClient, ActionListener) doCheck} against the {@code resource} that throws an
-     * that it returns {@code ERRPR} when performing a {@code DELETE} rather than the more common {@code GET}.
+     * exception and assert that it returns {@code onFailure()} when performing a {@code DELETE} rather than the more common {@code GET}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
      * @param resourceName The resource name (e.g., the template or pipeline name).
      */
     protected void assertCheckAsDeleteWithException(final PublishableHttpResource resource,
-                                                    final String resourceBasePath, final String resourceName)
+                                                    final String resourceBasePath, final String resourceName) {
-            throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final ResponseException responseException = responseException("DELETE", endpoint, failedCheckStatus());
         final Exception e = randomFrom(new IOException("expected"), new RuntimeException("expected"), responseException);
 
-        Request request = new Request("DELETE", endpoint);
+        final Request request = new Request("DELETE", endpoint);
         addParameters(request, deleteParameters(resource.getParameters()));
-        when(client.performRequest(request)).thenThrow(e);
+        whenPerformRequestAsyncWith(client, request, e);
 
-        assertThat(resource.doCheck(client), is(CheckResponse.ERROR));
+        resource.doCheck(client, listener);
+
+        verifyListener(null);
     }
 
     /**
-     * Perform {@link PublishableHttpResource#doPublish(RestClient) doPublish} against the {@code resource} and assert that it returns
+     * Perform {@link PublishableHttpResource#doPublish(RestClient, ActionListener) doPublish} against the {@code resource} and assert that
-     * {@code true} given a {@link RestStatus} that is {@link RestStatus#OK} or {@link RestStatus#CREATED}.
+     * it returns {@code onResponse(true)} given a {@link RestStatus} that is {@link RestStatus#OK} or {@link RestStatus#CREATED}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
@@ -145,29 +157,13 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
      * @param bodyType The request body provider's type.
      */
     protected void assertPublishSucceeds(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
-                                         final Class<? extends HttpEntity> bodyType)
+                                         final Class<? extends HttpEntity> bodyType) {
-            throws IOException {
         doPublishWithStatusCode(resource, resourceBasePath, resourceName, bodyType, successfulPublishStatus(), true);
     }
 
     /**
-     * Perform {@link PublishableHttpResource#doPublish(RestClient) doPublish} against the {@code resource} and assert that it returns
+     * Perform {@link PublishableHttpResource#doPublish(RestClient, ActionListener) doPublish} against the {@code resource} that throws an
-     * {@code false} given a {@link RestStatus} that is neither {@link RestStatus#OK} or {@link RestStatus#CREATED}.
+     * exception and assert that it returns {@code onResponse(false)}.
-     *
-     * @param resource The resource to execute.
-     * @param resourceBasePath The base endpoint (e.g., "/_template")
-     * @param resourceName The resource name (e.g., the template or pipeline name).
-     * @param bodyType The request body provider's type.
-     */
-    protected void assertPublishFails(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
-                                      final Class<? extends HttpEntity> bodyType)
-            throws IOException {
-        doPublishWithStatusCode(resource, resourceBasePath, resourceName, bodyType, failedPublishStatus(), false);
-    }
-
-    /**
-     * Perform {@link PublishableHttpResource#doPublish(RestClient) doPublish} against the {@code resource} that throws an exception and
-     * assert that it returns {@code false}.
      *
      * @param resource The resource to execute.
      * @param resourceBasePath The base endpoint (e.g., "/_template")
@@ -175,16 +171,18 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
      */
     protected void assertPublishWithException(final PublishableHttpResource resource,
                                               final String resourceBasePath, final String resourceName,
-                                              final Class<? extends HttpEntity> bodyType)
+                                              final Class<? extends HttpEntity> bodyType) {
-            throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Exception e = randomFrom(new IOException("expected"), new RuntimeException("expected"));
 
-        when(client.performRequest(Mockito.any(Request.class))).thenThrow(e);
+        whenPerformRequestAsyncWith(client, e);
 
-        assertThat(resource.doPublish(client), is(false));
+        resource.doPublish(client, listener);
-        ArgumentCaptor<Request> request = ArgumentCaptor.forClass(Request.class);
+
-        verify(client).performRequest(request.capture());
+        verifyListener(null);
+
+        final ArgumentCaptor<Request> request = ArgumentCaptor.forClass(Request.class);
+        verify(client).performRequestAsync(request.capture(), any(ResponseListener.class));
         assertThat(request.getValue().getMethod(), is("PUT"));
         assertThat(request.getValue().getEndpoint(), is(endpoint));
         assertThat(request.getValue().getParameters(), is(resource.getParameters()));
@@ -219,63 +217,60 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
 
     protected void doCheckWithStatusCode(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
                                          final RestStatus status,
-                                         final CheckResponse expected)
+                                         final Boolean expected) {
-            throws IOException {
         doCheckWithStatusCode(resource, resourceBasePath, resourceName, status, expected, null);
     }
 
     protected void doCheckWithStatusCode(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
-                                         final RestStatus status, final CheckResponse expected, final HttpEntity entity)
+                                         final RestStatus status, final Boolean expected, final HttpEntity entity) {
-            throws IOException {
         doCheckWithStatusCode(resource, resourceBasePath, resourceName, status, GET_EXISTS, GET_DOES_NOT_EXIST, expected, entity);
     }
 
     protected void doCheckWithStatusCode(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
                                          final RestStatus status, final Set<Integer> exists, final Set<Integer> doesNotExist,
-                                         final CheckResponse expected)
+                                         final Boolean expected) {
-            throws IOException {
         doCheckWithStatusCode(resource, resourceBasePath, resourceName, status, exists, doesNotExist, expected, null);
     }
 
     protected void doCheckWithStatusCode(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
                                          final RestStatus status, final Set<Integer> exists, final Set<Integer> doesNotExist,
-                                         final CheckResponse expected, final HttpEntity entity)
+                                         final Boolean expected, final HttpEntity entity) {
-            throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("GET", endpoint, status, entity);
 
         doCheckWithStatusCode(resource, getParameters(resource.getParameters(), exists, doesNotExist), endpoint, expected, response);
     }
 
-    protected void doCheckWithStatusCode(final PublishableHttpResource resource, final String endpoint, final CheckResponse expected,
-                                         final Response response)
-            throws IOException {
-        doCheckWithStatusCode(resource, getParameters(resource.getParameters()), endpoint, expected, response);
-    }
-
     protected void doCheckWithStatusCode(final PublishableHttpResource resource, final Map<String, String> expectedParameters,
-                                         final String endpoint, final CheckResponse expected,
+                                         final String endpoint, final Boolean expected,
-                                         final Response response)
+                                         final Response response) {
-            throws IOException {
+        final Request request = new Request("GET", endpoint);
-        Request request = new Request("GET", endpoint);
         addParameters(request, expectedParameters);
-        when(client.performRequest(request)).thenReturn(response);
 
-        assertThat(resource.doCheck(client), is(expected));
+        whenPerformRequestAsyncWith(client, request, response);
+
+        resource.doCheck(client, listener);
+
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
+        verifyListener(expected);
     }
 
     private void doPublishWithStatusCode(final PublishableHttpResource resource, final String resourceBasePath, final String resourceName,
                                          final Class<? extends HttpEntity> bodyType,
                                          final RestStatus status,
-                                         final boolean expected)
+                                         final boolean errorFree) {
-            throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("GET", endpoint, status);
 
-        ArgumentCaptor<Request> request = ArgumentCaptor.forClass(Request.class);
+        whenPerformRequestAsyncWith(client, response);
-        when(client.performRequest(request.capture())).thenReturn(response);
+
+        resource.doPublish(client, listener);
+
+        verifyListener(errorFree ? true : null);
+
+        final ArgumentCaptor<Request> request = ArgumentCaptor.forClass(Request.class);
+        verify(client).performRequestAsync(request.capture(), any(ResponseListener.class));
 
-        assertThat(resource.doPublish(client), is(expected));
         assertThat(request.getValue().getMethod(), is("PUT"));
         assertThat(request.getValue().getEndpoint(), is(endpoint));
         assertThat(request.getValue().getParameters(), is(resource.getParameters()));
@@ -285,8 +280,7 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
     protected void doCheckAsDeleteWithStatusCode(final PublishableHttpResource resource,
                                                  final String resourceBasePath, final String resourceName,
                                                  final RestStatus status,
-                                                 final CheckResponse expected)
+                                                 final Boolean expected) {
-            throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("DELETE", endpoint, status);
 
@@ -294,14 +288,15 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
     }
 
     protected void doCheckAsDeleteWithStatusCode(final PublishableHttpResource resource,
-                                                 final String endpoint, final CheckResponse expected,
+                                                 final String endpoint, final Boolean expected,
-                                                 final Response response)
+                                                 final Response response) {
-            throws IOException {
+        final Request request = new Request("DELETE", endpoint);
-        Request request = new Request("DELETE", endpoint);
         addParameters(request, deleteParameters(resource.getParameters()));
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.doCheck(client), is(expected));
+        resource.doCheck(client, listener);
+
+        verifyListener(expected);
     }
 
     protected RestStatus successfulCheckStatus() {
@@ -381,77 +376,68 @@ public abstract class AbstractPublishableHttpResourceTestCase extends ESTestCase
         return parametersWithIgnore;
     }
 
-    protected HttpEntity entityForResource(final CheckResponse expected, final String resourceName, final int minimumVersion) {
+    protected HttpEntity entityForResource(final Boolean expected, final String resourceName, final int minimumVersion) {
-        HttpEntity entity = null;
+        if (expected == Boolean.FALSE) {
-
-        switch (expected) {
             // the version check is what is expected to cause it to be replaced
-            case DOES_NOT_EXIST:
+            final int olderVersion = minimumVersion - randomIntBetween(1, 10000);
-                final int olderVersion = minimumVersion - randomIntBetween(1, 10000);
 
-                entity = randomFrom(
+            return randomFrom(
-                    new StringEntity("{}", ContentType.APPLICATION_JSON),
+                new StringEntity("{}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"" + resourceName + "\":{}}", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"" + resourceName + "\":{}}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"" + resourceName + "\":{\"version\":\"123\"}}", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"" + resourceName + "\":{\"version\":\"123\"}}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"" + resourceName + "\":{\"version\":" + olderVersion + "}}", ContentType.APPLICATION_JSON)
+                new StringEntity("{\"" + resourceName + "\":{\"version\":" + olderVersion + "}}", ContentType.APPLICATION_JSON)
-                );
+            );
-                break;
+        } else if (expected == Boolean.TRUE) {
             // the version is there and it's exactly what we specify
-            case EXISTS:
+            return new StringEntity("{\"" + resourceName + "\":{\"version\":" + minimumVersion + "}}", ContentType.APPLICATION_JSON);
-                entity = new StringEntity("{\"" + resourceName + "\":{\"version\":" + minimumVersion + "}}", ContentType.APPLICATION_JSON);
+        } else { // expected = null, which is for malformed/failure
-                break;
             // malformed
-            case ERROR:
+            return randomFrom(
-                entity = randomFrom(
+                new StringEntity("{", ContentType.APPLICATION_JSON),
-                    new StringEntity("{", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"" + resourceName + "\":\"not an object\"}", ContentType.APPLICATION_JSON)
-                    new StringEntity("{\"" + resourceName + "\":\"not an object\"}", ContentType.APPLICATION_JSON)
+            );
-                );
-                break;
-            default:
-                fail("Unhandled/unknown CheckResponse");
         }
-
-        return entity;
     }
 
-    protected HttpEntity entityForClusterAlert(final CheckResponse expected, final int minimumVersion) {
+    protected HttpEntity entityForClusterAlert(final Boolean expected, final int minimumVersion) {
-        HttpEntity entity = null;
+        if (expected == Boolean.FALSE) {
-
-        switch (expected) {
             // the version check is what is expected to cause it to be replaced
-            case DOES_NOT_EXIST:
+            final int olderVersion = minimumVersion - randomIntBetween(1, 10000);
-                final int olderVersion = minimumVersion - randomIntBetween(1, 10000);
 
-                entity = randomFrom(
+            return randomFrom(
-                    new StringEntity("{}", ContentType.APPLICATION_JSON),
+                new StringEntity("{}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"metadata\":{}}", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"metadata\":{}}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":\"123\"}}}", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":\"123\"}}}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":" + olderVersion + "}}}}", ContentType.APPLICATION_JSON)
+                new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":" + olderVersion + "}}}}", ContentType.APPLICATION_JSON)
-                );
+            );
-                break;
+        } else if (expected == Boolean.TRUE) {
             // the version is there and it's exactly what we specify
-            case EXISTS:
+            return new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":" +
-                entity = new StringEntity("{\"metadata\":{\"xpack\":{\"version_created\":" +
+                                    minimumVersion + "}}}", ContentType.APPLICATION_JSON);
-                                          minimumVersion + "}}}", ContentType.APPLICATION_JSON);
+        } else { // expected == null, which is for malformed/failure
-                break;
             // malformed
-            case ERROR:
+            return randomFrom(
-                entity = randomFrom(
+                new StringEntity("{", ContentType.APPLICATION_JSON),
-                    new StringEntity("{", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"\"metadata\":\"not an object\"}", ContentType.APPLICATION_JSON),
-                    new StringEntity("{\"\"metadata\":\"not an object\"}", ContentType.APPLICATION_JSON),
+                new StringEntity("{\"\"metadata\":{\"xpack\":\"not an object\"}}", ContentType.APPLICATION_JSON)
-                    new StringEntity("{\"\"metadata\":{\"xpack\":\"not an object\"}}", ContentType.APPLICATION_JSON)
+            );
-                );
-                break;
-            default:
-                fail("Unhandled/unknown CheckResponse");
         }
-
-        return entity;
     }
 
-    protected void addParameters(Request request, Map<String, String> parameters) {
+    protected void addParameters(final Request request, final Map<String, String> parameters) {
         for (Map.Entry<String, String> param : parameters.entrySet()) {
             request.addParameter(param.getKey(), param.getValue());
         }
     }
+
+    protected void verifyListener(final Boolean expected) {
+        if (expected == null) {
+            verify(listener, never()).onResponse(anyBoolean());
+            verify(listener).onFailure(any(Exception.class));
+        } else {
+            verify(listener).onResponse(expected);
+            verify(listener, never()).onFailure(any(Exception.class));
+        }
+    }
+
 }

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/AsyncHttpResourceHelper.java

@@ -0,0 +1,117 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+package org.elasticsearch.xpack.monitoring.exporter.http;
+
+import java.util.List;
+import org.elasticsearch.action.ActionListener;
+import org.elasticsearch.client.Request;
+import org.elasticsearch.client.Response;
+import org.elasticsearch.client.ResponseListener;
+import org.elasticsearch.client.RestClient;
+import org.hamcrest.Matcher;
+import org.mockito.stubbing.Stubber;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.mock;
+
+class AsyncHttpResourceHelper {
+
+    @SuppressWarnings("unchecked")
+    static ActionListener<Boolean> mockBooleanActionListener() {
+        return mock(ActionListener.class);
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Response response) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onSuccess(response);
+            return null;
+        }).when(client).performRequestAsync(any(Request.class), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Matcher<Request> request, final Response response) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onSuccess(response);
+            return null;
+        }).when(client).performRequestAsync(argThat(request), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Matcher<Request> request, final List<Response> responses) {
+        if (responses.size() == 1) {
+            whenPerformRequestAsyncWith(client, request, responses.get(0));
+        } else if (responses.size() > 1) {
+            whenPerformRequestAsyncWith(client, request, responses.get(0), responses.subList(1, responses.size()), null);
+        }
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client,
+                                            final Matcher<Request> request,
+                                            final Response response,
+                                            final Exception exception) {
+        whenPerformRequestAsyncWith(client, request, response, null, exception);
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client,
+                                            final Matcher<Request> request,
+                                            final Response first,
+                                            final List<Response> responses,
+                                            final Exception exception) {
+        Stubber stub = doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onSuccess(first);
+            return null;
+        });
+
+        if (responses != null) {
+            for (final Response response : responses) {
+                stub.doAnswer(invocation -> {
+                    ((ResponseListener) invocation.getArguments()[1]).onSuccess(response);
+                    return null;
+                });
+            }
+        }
+
+        if (exception != null) {
+            stub.doAnswer(invocation -> {
+                ((ResponseListener) invocation.getArguments()[1]).onFailure(exception);
+                return null;
+            });
+        }
+
+        stub.when(client).performRequestAsync(argThat(request), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Request request, final Response response) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onSuccess(response);
+            return null;
+        }).when(client).performRequestAsync(eq(request), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Exception exception) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onFailure(exception);
+            return null;
+        }).when(client).performRequestAsync(any(Request.class), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Matcher<Request> request, final Exception exception) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onFailure(exception);
+            return null;
+        }).when(client).performRequestAsync(argThat(request), any(ResponseListener.class));
+    }
+
+    static void whenPerformRequestAsyncWith(final RestClient client, final Request request, final Exception exception) {
+        doAnswer(invocation -> {
+            ((ResponseListener)invocation.getArguments()[1]).onFailure(exception);
+            return null;
+        }).when(client).performRequestAsync(eq(request), any(ResponseListener.class));
+    }
+
+}

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/ClusterAlertHttpResourceTests.java

@@ -18,7 +18,6 @@ import org.elasticsearch.common.xcontent.XContent;
 import org.elasticsearch.common.xcontent.XContentType;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.xpack.monitoring.exporter.ClusterAlertsUtil;
-import org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse;
 
 import static org.hamcrest.Matchers.is;
 import static org.mockito.Mockito.mock;
@@ -62,10 +61,9 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
     public void testDoCheckGetWatchExists() throws IOException {
         when(licenseState.isMonitoringClusterAlertsAllowed()).thenReturn(true);
 
-        final HttpEntity entity = entityForClusterAlert(CheckResponse.EXISTS, minimumVersion);
+        final HttpEntity entity = entityForClusterAlert(true, minimumVersion);
 
-        doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(),
+        doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(), true, entity);
-                              CheckResponse.EXISTS, entity);
     }
 
     public void testDoCheckGetWatchDoesNotExist() throws IOException {
@@ -76,10 +74,9 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
             assertCheckDoesNotExist(resource, "/_xpack/watcher/watch", watchId);
         } else {
             // it does not exist because we need to replace it
-            final HttpEntity entity = entityForClusterAlert(CheckResponse.DOES_NOT_EXIST, minimumVersion);
+            final HttpEntity entity = entityForClusterAlert(false, minimumVersion);
 
-            doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(),
+            doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(), false, entity);
-                                  CheckResponse.DOES_NOT_EXIST, entity);
         }
     }
 
@@ -91,10 +88,9 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
             assertCheckWithException(resource, "/_xpack/watcher/watch", watchId);
         } else {
             // error because of a malformed response
-            final HttpEntity entity = entityForClusterAlert(CheckResponse.ERROR, minimumVersion);
+            final HttpEntity entity = entityForClusterAlert(null, minimumVersion);
 
-            doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(),
+            doCheckWithStatusCode(resource, "/_xpack/watcher/watch", watchId, successfulCheckStatus(), null, entity);
-                                  CheckResponse.ERROR, entity);
         }
     }
 
@@ -134,10 +130,6 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
         assertPublishSucceeds(resource, "/_xpack/watcher/watch", watchId, StringEntity.class);
     }
 
-    public void testDoPublishFalse() throws IOException {
-        assertPublishFails(resource, "/_xpack/watcher/watch", watchId, StringEntity.class);
-    }
-
     public void testDoPublishFalseWithException() throws IOException {
         assertPublishWithException(resource, "/_xpack/watcher/watch", watchId, StringEntity.class);
     }
@@ -153,9 +145,9 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
         expectThrows(IOException.class, () -> resource.shouldReplaceClusterAlert(response, xContent, randomInt()));
     }
 
-    public void testShouldReplaceClusterAlertThrowsExceptionForMalformedResponse() throws IOException {
+    public void testShouldReplaceClusterAlertThrowsExceptionForMalformedResponse() {
         final Response response = mock(Response.class);
-        final HttpEntity entity = entityForClusterAlert(CheckResponse.ERROR, randomInt());
+        final HttpEntity entity = entityForClusterAlert(null, randomInt());
         final XContent xContent = XContentType.JSON.xContent();
 
         when(response.getEntity()).thenReturn(entity);
@@ -166,7 +158,7 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
     public void testShouldReplaceClusterAlertReturnsTrueVersionIsNotExpected() throws IOException {
         final int minimumVersion = randomInt();
         final Response response = mock(Response.class);
-        final HttpEntity entity = entityForClusterAlert(CheckResponse.DOES_NOT_EXIST, minimumVersion);
+        final HttpEntity entity = entityForClusterAlert(false, minimumVersion);
         final XContent xContent = XContentType.JSON.xContent();
 
         when(response.getEntity()).thenReturn(entity);
@@ -180,7 +172,7 @@ public class ClusterAlertHttpResourceTests extends AbstractPublishableHttpResour
         final boolean shouldReplace = version < minimumVersion;
 
         final Response response = mock(Response.class);
-        final HttpEntity entity = entityForClusterAlert(CheckResponse.EXISTS, version);
+        final HttpEntity entity = entityForClusterAlert(true, version);
         final XContent xContent = XContentType.JSON.xContent();
 
         when(response.getEntity()).thenReturn(entity);

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporterIT.java

@@ -36,6 +36,7 @@ import org.elasticsearch.xpack.core.ssl.SSLService;
 import org.elasticsearch.xpack.monitoring.MonitoringTestUtils;
 import org.elasticsearch.xpack.monitoring.collector.indices.IndexRecoveryMonitoringDoc;
 import org.elasticsearch.xpack.monitoring.exporter.ClusterAlertsUtil;
+import org.elasticsearch.xpack.monitoring.exporter.ExportBulk;
 import org.elasticsearch.xpack.monitoring.exporter.Exporter;
 import org.elasticsearch.xpack.monitoring.test.MonitoringIntegTestCase;
 import org.joda.time.format.DateTimeFormat;
@@ -66,7 +67,6 @@ import static org.hamcrest.Matchers.containsInAnyOrder;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.instanceOf;
-import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
 import static org.hamcrest.Matchers.notNullValue;
 
@@ -116,7 +116,7 @@ public class HttpExporterIT extends MonitoringIntegTestCase {
                        .build();
     }
 
-    protected Settings.Builder baseSettings() {
+    private Settings.Builder baseSettings() {
         return Settings.builder()
                        .put("xpack.monitoring.exporters._http.type", "http")
                        .put("xpack.monitoring.exporters._http.host", getFormattedAddress(webServer))
@@ -295,7 +295,7 @@ public class HttpExporterIT extends MonitoringIntegTestCase {
     }
 
     public void testUnsupportedClusterVersion() throws Exception {
-        Settings settings = Settings.builder()
+        final Settings settings = Settings.builder()
                 .put("xpack.monitoring.exporters._http.type", "http")
                 .put("xpack.monitoring.exporters._http.host", getFormattedAddress(webServer))
                 .build();
@@ -311,7 +311,21 @@ public class HttpExporterIT extends MonitoringIntegTestCase {
 
         // ensure that the exporter is not able to be used
         try (HttpExporter exporter = createHttpExporter(settings)) {
-            assertThat(exporter.isExporterReady(), is(false));
+            final CountDownLatch awaitResponseAndClose = new CountDownLatch(1);
+
+            final ActionListener<ExportBulk> listener = ActionListener.wrap(
+                bulk -> {
+                    assertNull(bulk);
+
+                    awaitResponseAndClose.countDown();
+                },
+                e -> fail(e.getMessage())
+            );
+
+            exporter.openBulk(listener);
+
+            // wait for it to actually respond
+            assertTrue(awaitResponseAndClose.await(15, TimeUnit.SECONDS));
         }
 
         assertThat(webServer.requests(), hasSize(1));
@@ -549,7 +563,7 @@ public class HttpExporterIT extends MonitoringIntegTestCase {
         }
     }
 
-    private HttpExporter createHttpExporter(final Settings settings) throws Exception {
+    private HttpExporter createHttpExporter(final Settings settings) {
         final Exporter.Config config =
                 new Exporter.Config("_http", "http", settings, clusterService(), new XPackLicenseState(Settings.EMPTY));
 
@@ -561,34 +575,25 @@ public class HttpExporterIT extends MonitoringIntegTestCase {
         assertBusy(() -> assertThat(clusterService().state().version(), not(ClusterState.UNKNOWN_VERSION)));
 
         try (HttpExporter exporter = createHttpExporter(settings)) {
-            // the readiness check happens synchronously, so we don't need to busy-wait for it
-            assertThat("Exporter is not ready", exporter.isExporterReady(), is(true));
-
-            final HttpExportBulk bulk = exporter.openBulk();
-
-            assertThat("Bulk should never be null after the exporter is ready", bulk, notNullValue());
-
             final CountDownLatch awaitResponseAndClose = new CountDownLatch(2);
-            final ActionListener<Void> listener = new ActionListener<Void>() {
-                @Override
-                public void onResponse(Void response) {
-                    awaitResponseAndClose.countDown();
-                }
 
-                @Override
+            exporter.openBulk(ActionListener.wrap(exportBulk -> {
-                public void onFailure(Exception e) {
+                final HttpExportBulk bulk = (HttpExportBulk)exportBulk;
-                    fail(e.getMessage());
 
-                    awaitResponseAndClose.countDown();
+                assertThat("Bulk should never be null after the exporter is ready", bulk, notNullValue());
-                }
-            };
 
-            bulk.doAdd(docs);
+                final ActionListener<Void> listener = ActionListener.wrap(
-            bulk.doFlush(listener);
+                    ignored -> awaitResponseAndClose.countDown(),
-            bulk.doClose(listener);
+                    e -> fail(e.getMessage())
+                );
+
+                bulk.doAdd(docs);
+                bulk.doFlush(listener);
+                bulk.doClose(listener); // reusing the same listener, which is why we expect countDown x2
+            }, e -> fail("Failed to create HttpExportBulk")));
 
             // block until the bulk responds
-            awaitResponseAndClose.await(15, TimeUnit.SECONDS);
+            assertTrue(awaitResponseAndClose.await(15, TimeUnit.SECONDS));
         }
     }
 

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporterResourceTests.java

@@ -13,6 +13,7 @@ import org.elasticsearch.Version;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.ResponseException;
+import org.elasticsearch.client.ResponseListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.cluster.ClusterState;
 import org.elasticsearch.cluster.metadata.MetaData;
@@ -38,11 +39,11 @@ import java.util.stream.Collectors;
 import static org.elasticsearch.xpack.core.monitoring.exporter.MonitoringTemplateUtils.OLD_TEMPLATE_IDS;
 import static org.elasticsearch.xpack.core.monitoring.exporter.MonitoringTemplateUtils.PIPELINE_IDS;
 import static org.elasticsearch.xpack.core.monitoring.exporter.MonitoringTemplateUtils.TEMPLATE_IDS;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.DOES_NOT_EXIST;
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.whenPerformRequestAsyncWith;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.EXISTS;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.startsWith;
+import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.argThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
@@ -100,15 +101,20 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         assertThat("Not all watches are supplied", watchNames, hasSize(EXPECTED_WATCHES));
     }
 
-    public void testInvalidVersionBlocks() throws IOException {
+    public void awaitCheckAndPublish(final Boolean expected) {
-        final HttpEntity entity = new StringEntity("{\"version\":{\"number\":\"unknown\"}}", ContentType.APPLICATION_JSON);
+        resources.checkAndPublish(client, listener);
+
+        verifyListener(expected);
+    }
+
+    public void testInvalidVersionBlocks() {
+        final HttpEntity entity = new StringEntity("{\"version\":{\"number\":\"3.0.0\"}}", ContentType.APPLICATION_JSON);
 
         when(versionResponse.getEntity()).thenReturn(entity);
-        when(client.performRequest(argThat(new RequestMatcher(is("GET"), is("/")))))
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), is("/")), versionResponse);
-            .thenReturn(versionResponse);
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(false);
         // ensure it didn't magically become clean
         assertTrue(resources.isDirty());
 
@@ -116,7 +122,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testTemplateCheckBlocksAfterSuccessfulVersion() throws IOException {
+    public void testTemplateCheckBlocksAfterSuccessfulVersion() {
         final Exception exception = failureGetException();
         final boolean firstSucceeds = randomBoolean();
         int expectedGets = 1;
@@ -144,20 +150,18 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             final List<Response> otherResponses = getTemplateResponses(1, successful, unsuccessful);
 
             // last check fails implies that N - 2 publishes succeeded!
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_template/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_template/")),
-                .thenReturn(first, otherResponses.toArray(new Response[otherResponses.size()]))
+                                        first, otherResponses, exception);
-                .thenThrow(exception);
             whenSuccessfulPutTemplates(otherResponses.size() + 1);
 
             expectedGets += 1 + successful + unsuccessful;
             expectedPuts = (successfulFirst ? 0 : 1) + unsuccessful;
         } else {
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_template/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_template/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -167,7 +171,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testTemplatePublishBlocksAfterSuccessfulVersion() throws IOException {
+    public void testTemplatePublishBlocksAfterSuccessfulVersion() {
         final Exception exception = failurePutException();
         final boolean firstSucceeds = randomBoolean();
         int expectedGets = 1;
@@ -189,9 +193,8 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             whenGetTemplates(successful, unsuccessful + 2);
 
             // previous publishes must have succeeded
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_template/")),
-                    .thenReturn(firstSuccess, otherResponses.toArray(new Response[otherResponses.size()]))
+                                        firstSuccess, otherResponses, exception);
-                    .thenThrow(exception);
 
             // GETs required for each PUT attempt (first is guaranteed "unsuccessful")
             expectedGets += successful + unsuccessful + 1;
@@ -201,12 +204,11 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             // fail the check so that it has to attempt the PUT
             whenGetTemplates(0, 1);
 
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_template/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -216,7 +218,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testPipelineCheckBlocksAfterSuccessfulTemplates() throws IOException {
+    public void testPipelineCheckBlocksAfterSuccessfulTemplates() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final Exception exception = failureGetException();
@@ -242,9 +244,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             }
 
             // last check fails
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")), first, exception);
-                    .thenReturn(first)
-                    .thenThrow(exception);
             if (successfulFirst == false) {
                 whenSuccessfulPutPipelines(1);
             }
@@ -252,12 +252,11 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             expectedGets = EXPECTED_PIPELINES;
             expectedPuts = successfulFirst ? 0 : 1;
         } else {
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -269,7 +268,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testPipelinePublishBlocksAfterSuccessfulTemplates() throws IOException {
+    public void testPipelinePublishBlocksAfterSuccessfulTemplates() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final Exception exception = failurePutException();
@@ -289,9 +288,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             whenGetPipelines(0, 2);
 
             // previous publishes must have succeeded
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")), firstSuccess, exception);
-                    .thenReturn(firstSuccess)
-                    .thenThrow(exception);
 
             // GETs required for each PUT attempt (first is guaranteed "unsuccessful")
             expectedGets += 1;
@@ -301,12 +298,11 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             // fail the check so that it has to attempt the PUT
             whenGetPipelines(0, 1);
 
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -318,7 +314,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testWatcherCheckBlocksAfterSuccessfulPipelines() throws IOException {
+    public void testWatcherCheckBlocksAfterSuccessfulPipelines() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final int successfulGetPipelines = randomIntBetween(0, EXPECTED_PIPELINES);
@@ -332,11 +328,10 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         whenSuccessfulPutPipelines(unsuccessfulGetPipelines);
 
         // there's only one check
-        when(client.performRequest(argThat(new RequestMatcher(is("GET"), is("/_xpack")))))
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), is("/_xpack")), exception);
-                .thenThrow(exception);
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -349,7 +344,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testWatchCheckBlocksAfterSuccessfulWatcherCheck() throws IOException {
+    public void testWatchCheckBlocksAfterSuccessfulWatcherCheck() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final int successfulGetPipelines = randomIntBetween(0, EXPECTED_PIPELINES);
@@ -381,9 +376,8 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
                 final List<Response> otherResponses = getWatcherResponses(1, successful, unsuccessful);
 
                 // last check fails implies that N - 2 publishes succeeded!
-                when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/")))))
+                whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/")),
-                        .thenReturn(first, otherResponses.toArray(new Response[otherResponses.size()]))
+                                            first, otherResponses, exception);
-                        .thenThrow(exception);
                 whenSuccessfulPutWatches(otherResponses.size() + 1);
 
                 // +1 for the "first"
@@ -397,21 +391,19 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
                 // there is no form of an unsuccessful delete; only success or error
                 final List<Response> responses = successfulDeleteResponses(successful);
 
-                when(client.performRequest(argThat(new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/")))))
+                whenPerformRequestAsyncWith(client, new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/")),
-                        .thenReturn(responses.get(0), responses.subList(1, successful).toArray(new Response[successful - 1]))
+                                            responses.get(0), responses.subList(1, responses.size()), exception);
-                        .thenThrow(exception);
 
                 expectedGets += successful;
             }
         } else {
             final String method = validLicense ? "GET" : "DELETE";
 
-            when(client.performRequest(argThat(new RequestMatcher(is(method), startsWith("/_xpack/watcher/watch/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is(method), startsWith("/_xpack/watcher/watch/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -430,7 +422,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testWatchPublishBlocksAfterSuccessfulWatcherCheck() throws IOException {
+    public void testWatchPublishBlocksAfterSuccessfulWatcherCheck() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final int successfulGetPipelines = randomIntBetween(0, EXPECTED_PIPELINES);
@@ -462,9 +454,8 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             whenGetWatches(successful, unsuccessful + 2);
 
             // previous publishes must have succeeded
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")),
-                    .thenReturn(firstSuccess, otherResponses.toArray(new Response[otherResponses.size()]))
+                                        firstSuccess, otherResponses, exception);
-                    .thenThrow(exception);
 
             // GETs required for each PUT attempt (first is guaranteed "unsuccessful")
             expectedGets += successful + unsuccessful + 1;
@@ -474,12 +465,11 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             // fail the check so that it has to attempt the PUT
             whenGetWatches(0, 1);
 
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")))))
+            whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")), exception);
-                    .thenThrow(exception);
         }
 
         assertTrue(resources.isDirty());
-        assertFalse(resources.checkAndPublish(client));
+        awaitCheckAndPublish(null);
         // ensure it didn't magically become not-dirty
         assertTrue(resources.isDirty());
 
@@ -494,7 +484,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         verifyNoMoreInteractions(client);
     }
 
-    public void testSuccessfulChecksOnElectedMasterNode() throws IOException {
+    public void testSuccessfulChecksOnElectedMasterNode() {
         final int successfulGetTemplates = randomIntBetween(0, EXPECTED_TEMPLATES);
         final int unsuccessfulGetTemplates = EXPECTED_TEMPLATES - successfulGetTemplates;
         final int successfulGetPipelines = randomIntBetween(0, EXPECTED_PIPELINES);
@@ -522,7 +512,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         assertTrue(resources.isDirty());
 
         // it should be able to proceed!
-        assertTrue(resources.checkAndPublish(client));
+        awaitCheckAndPublish(true);
         assertFalse(resources.isDirty());
 
         verifyVersionCheck();
@@ -545,7 +535,7 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
     /**
      * If the node is not the elected master node, then it should never check Watcher or send Watches (Cluster Alerts).
      */
-    public void testSuccessfulChecksIfNotElectedMasterNode() throws IOException {
+    public void testSuccessfulChecksIfNotElectedMasterNode() {
         final ClusterState state = mockClusterState(false);
         final ClusterService clusterService = mockClusterService(state);
 
@@ -566,8 +556,10 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
 
         assertTrue(resources.isDirty());
 
-        // it should be able to proceed!
+        // it should be able to proceed! (note: we are not using the instance "resources" here)
-        assertTrue(resources.checkAndPublish(client));
+        resources.checkAndPublish(client, listener);
+
+        verifyListener(true);
         assertFalse(resources.isDirty());
 
         verifyVersionCheck();
@@ -601,13 +593,13 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
     }
 
     private Response successfulGetWatchResponse(final String watchId) {
-        final HttpEntity goodEntity = entityForClusterAlert(EXISTS, ClusterAlertsUtil.LAST_UPDATED_VERSION);
+        final HttpEntity goodEntity = entityForClusterAlert(true, ClusterAlertsUtil.LAST_UPDATED_VERSION);
 
         return response("GET", "/_xpack/watcher/watch/" + watchId, successfulCheckStatus(), goodEntity);
     }
     private Response unsuccessfulGetWatchResponse(final String watchId) {
         if (randomBoolean()) {
-            final HttpEntity badEntity = entityForClusterAlert(DOES_NOT_EXIST, ClusterAlertsUtil.LAST_UPDATED_VERSION);
+            final HttpEntity badEntity = entityForClusterAlert(false, ClusterAlertsUtil.LAST_UPDATED_VERSION);
 
             return response("GET", "/_xpack/watcher/watch/" + watchId, successfulCheckStatus(), badEntity);
         }
@@ -616,14 +608,14 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
     }
 
     private Response successfulGetResourceResponse(final String resourcePath, final String resourceName) {
-        final HttpEntity goodEntity = entityForResource(EXISTS, resourceName, MonitoringTemplateUtils.LAST_UPDATED_VERSION);
+        final HttpEntity goodEntity = entityForResource(true, resourceName, MonitoringTemplateUtils.LAST_UPDATED_VERSION);
 
         return response("GET", resourcePath + resourceName, successfulCheckStatus(), goodEntity);
     }
 
     private Response unsuccessfulGetResourceResponse(final String resourcePath, final String resourceName) {
         if (randomBoolean()) {
-            final HttpEntity badEntity = entityForResource(DOES_NOT_EXIST, resourceName, MonitoringTemplateUtils.LAST_UPDATED_VERSION);
+            final HttpEntity badEntity = entityForResource(false, resourceName, MonitoringTemplateUtils.LAST_UPDATED_VERSION);
 
             return response("GET", resourcePath + resourceName, successfulCheckStatus(), badEntity);
         }
@@ -704,65 +696,40 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
         return responses;
     }
 
-    private void whenValidVersionResponse() throws IOException {
+    private void whenValidVersionResponse() {
         final HttpEntity entity = new StringEntity("{\"version\":{\"number\":\"" + Version.CURRENT + "\"}}", ContentType.APPLICATION_JSON);
 
         when(versionResponse.getEntity()).thenReturn(entity);
-        when(client.performRequest(argThat(new RequestMatcher(is("GET"), is("/")))))
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), is("/")), versionResponse);
-                .thenReturn(versionResponse);
     }
 
-    private void whenGetTemplates(final int successful, final int unsuccessful) throws IOException {
+    private void whenGetTemplates(final int successful, final int unsuccessful) {
         final List<Response> gets = getTemplateResponses(0, successful, unsuccessful);
 
-        if (gets.size() == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_template/")), gets);
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_template/")))))
-                    .thenReturn(gets.get(0));
-        } else {
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_template/")))))
-                    .thenReturn(gets.get(0), gets.subList(1, gets.size()).toArray(new Response[gets.size() - 1]));
-        }
     }
 
-    private void whenSuccessfulPutTemplates(final int successful) throws IOException {
+    private void whenSuccessfulPutTemplates(final int successful) {
         final List<Response> successfulPuts = successfulPutResponses(successful);
 
         // empty is possible if they all exist
-        if (successful == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_template/")), successfulPuts);
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/")))))
-                    .thenReturn(successfulPuts.get(0));
-        } else if (successful > 1) {
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/")))))
-                    .thenReturn(successfulPuts.get(0), successfulPuts.subList(1, successful).toArray(new Response[successful - 1]));
-        }
     }
 
-    private void whenGetPipelines(final int successful, final int unsuccessful) throws IOException {
+    private void whenGetPipelines(final int successful, final int unsuccessful) {
         final List<Response> gets = getPipelineResponses(0, successful, unsuccessful);
 
-        if (gets.size() == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")), gets);
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")))))
-                    .thenReturn(gets.get(0));
-        } else {
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/")))))
-                    .thenReturn(gets.get(0), gets.subList(1, gets.size()).toArray(new Response[gets.size() - 1]));
-        }
     }
 
-    private void whenSuccessfulPutPipelines(final int successful) throws IOException {
+    private void whenSuccessfulPutPipelines(final int successful) {
         final List<Response> successfulPuts = successfulPutResponses(successful);
 
         // empty is possible if they all exist
-        if (successful == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")), successfulPuts);
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")))))
-                    .thenReturn(successfulPuts.get(0));
-        } else if (successful > 1) {
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/")))))
-                    .thenReturn(successfulPuts.get(0), successfulPuts.subList(1, successful).toArray(new Response[successful - 1]));
-        }
     }
 
-    private void whenWatcherCanBeUsed(final boolean validLicense) throws IOException {
+    private void whenWatcherCanBeUsed(final boolean validLicense) {
         final MetaData metaData = mock(MetaData.class);
 
         when(state.metaData()).thenReturn(metaData);
@@ -774,12 +741,10 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
                 new StringEntity("{\"features\":{\"watcher\":{\"enabled\":true,\"available\":true}}}", ContentType.APPLICATION_JSON);
         final Response successfulGet = response("GET", "_xpack", successfulCheckStatus(), entity);
 
-        // empty is possible if they all exist
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), is("/_xpack")), successfulGet);
-        when(client.performRequest(argThat(new RequestMatcher(is("GET"), is("/_xpack")))))
-                .thenReturn(successfulGet);
     }
 
-    private void whenWatcherCannotBeUsed() throws IOException {
+    private void whenWatcherCannotBeUsed() {
         final Response response;
         if (randomBoolean()) {
             final HttpEntity entity = randomFrom(
@@ -793,90 +758,71 @@ public class HttpExporterResourceTests extends AbstractPublishableHttpResourceTe
             response = response("GET", "_xpack", notFoundCheckStatus());
         }
 
-        // empty is possible if they all exist
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), is("/_xpack")), response);
-        when(client.performRequest(argThat(new RequestMatcher(is("GET"), is("/_xpack")))))
-                .thenReturn(response);
     }
 
-    private void whenGetWatches(final int successful, final int unsuccessful) throws IOException {
+    private void whenGetWatches(final int successful, final int unsuccessful) {
         final List<Response> gets = getWatcherResponses(0, successful, unsuccessful);
 
-        if (gets.size() == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/")), gets);
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(gets.get(0));
-        } else {
-            when(client.performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(gets.get(0), gets.subList(1, gets.size()).toArray(new Response[gets.size() - 1]));
-        }
     }
 
-    private void whenSuccessfulPutWatches(final int successful) throws IOException {
+    private void whenSuccessfulPutWatches(final int successful) {
         final List<Response> successfulPuts = successfulPutResponses(successful);
 
         // empty is possible if they all exist
-        if (successful == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")), successfulPuts);
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(successfulPuts.get(0));
-        } else if (successful > 1) {
-            when(client.performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(successfulPuts.get(0), successfulPuts.subList(1, successful).toArray(new Response[successful - 1]));
-        }
     }
 
-    private void whenSuccessfulDeleteWatches(final int successful) throws IOException {
+    private void whenSuccessfulDeleteWatches(final int successful) {
         final List<Response> successfulDeletes = successfulDeleteResponses(successful);
 
         // empty is possible if they all exist
-        if (successful == 1) {
+        whenPerformRequestAsyncWith(client, new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/")), successfulDeletes);
-            when(client.performRequest(argThat(new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(successfulDeletes.get(0));
-        } else if (successful > 1) {
-            when(client.performRequest(argThat(new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/")))))
-                    .thenReturn(successfulDeletes.get(0), successfulDeletes.subList(1, successful).toArray(new Response[successful - 1]));
-        }
     }
 
-    private void verifyVersionCheck() throws IOException {
+    private void verifyVersionCheck() {
-        verify(client).performRequest(argThat(new RequestMatcher(is("GET"), is("/"))));
+        verify(client).performRequestAsync(argThat(new RequestMatcher(is("GET"), is("/"))), any(ResponseListener.class));
     }
 
-    private void verifyGetTemplates(final int called) throws IOException {
+    private void verifyGetTemplates(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_template/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("GET"), startsWith("/_template/"))), any(ResponseListener.class));
     }
 
-    private void verifyPutTemplates(final int called) throws IOException {
+    private void verifyPutTemplates(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("PUT"), startsWith("/_template/"))), any(ResponseListener.class));
     }
 
-    private void verifyGetPipelines(final int called) throws IOException {
+    private void verifyGetPipelines(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("GET"), startsWith("/_ingest/pipeline/"))), any(ResponseListener.class));
     }
 
-    private void verifyPutPipelines(final int called) throws IOException {
+    private void verifyPutPipelines(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("PUT"), startsWith("/_ingest/pipeline/"))), any(ResponseListener.class));
     }
 
-    private void verifyWatcherCheck() throws IOException {
+    private void verifyWatcherCheck() {
-        verify(client).performRequest(argThat(new RequestMatcher(is("GET"), is("/_xpack"))));
+        verify(client).performRequestAsync(argThat(new RequestMatcher(is("GET"), is("/_xpack"))), any(ResponseListener.class));
     }
 
-    private void verifyDeleteWatches(final int called) throws IOException {
+    private void verifyDeleteWatches(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("DELETE"), startsWith("/_xpack/watcher/watch/"))),
+                                 any(ResponseListener.class));
     }
 
-    private void verifyGetWatches(final int called) throws IOException {
+    private void verifyGetWatches(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("GET"), startsWith("/_xpack/watcher/watch/"))), any(ResponseListener.class));
     }
 
-    private void verifyPutWatches(final int called) throws IOException {
+    private void verifyPutWatches(final int called) {
         verify(client, times(called))
-                .performRequest(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/"))));
+            .performRequestAsync(argThat(new RequestMatcher(is("PUT"), startsWith("/_xpack/watcher/watch/"))), any(ResponseListener.class));
     }
 
     private ClusterService mockClusterService(final ClusterState state) {

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpExporterTests.java

@@ -5,9 +5,12 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
 import org.apache.http.entity.ContentType;
 import org.apache.http.entity.StringEntity;
 import org.apache.http.nio.conn.ssl.SSLIOSessionStrategy;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.RestClient;
@@ -25,6 +28,7 @@ import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.xpack.core.monitoring.exporter.MonitoringTemplateUtils;
 import org.elasticsearch.xpack.core.ssl.SSLService;
 import org.elasticsearch.xpack.monitoring.exporter.ClusterAlertsUtil;
+import org.elasticsearch.xpack.monitoring.exporter.ExportBulk;
 import org.elasticsearch.xpack.monitoring.exporter.Exporter.Config;
 import org.junit.Before;
 import org.mockito.InOrder;
@@ -434,12 +438,50 @@ public class HttpExporterTests extends ESTestCase {
         final RestClient client = mock(RestClient.class);
         final Sniffer sniffer = randomFrom(mock(Sniffer.class), null);
         final NodeFailureListener listener = mock(NodeFailureListener.class);
-        final HttpResource resource = new MockHttpResource(exporterName(), true, PublishableHttpResource.CheckResponse.ERROR, false);
+        // this is configured to throw an error when the resource is checked
+        final HttpResource resource = new MockHttpResource(exporterName(), true, null, false);
 
         try (HttpExporter exporter = new HttpExporter(config, client, sniffer, threadContext, listener, resource)) {
             verify(listener).setResource(resource);
 
-            assertThat(exporter.openBulk(), nullValue());
+            final CountDownLatch awaitResponseAndClose = new CountDownLatch(1);
+            final ActionListener<ExportBulk> bulkListener = ActionListener.wrap(
+                bulk -> fail("[onFailure] should have been invoked by failed resource check"),
+                e -> awaitResponseAndClose.countDown()
+            );
+
+            exporter.openBulk(bulkListener);
+
+            // wait for it to actually respond
+            assertTrue(awaitResponseAndClose.await(15, TimeUnit.SECONDS));
+        }
+    }
+
+    public void testHttpExporterReturnsNullForOpenBulkIfNotReady() throws Exception {
+        final Config config = createConfig(Settings.EMPTY);
+        final RestClient client = mock(RestClient.class);
+        final Sniffer sniffer = randomFrom(mock(Sniffer.class), null);
+        final NodeFailureListener listener = mock(NodeFailureListener.class);
+        // always has to check, and never succeeds checks but it does not throw an exception (e.g., version check fails)
+        final HttpResource resource = new MockHttpResource(exporterName(), true, false, false);
+
+        try (HttpExporter exporter = new HttpExporter(config, client, sniffer, threadContext, listener, resource)) {
+            verify(listener).setResource(resource);
+
+            final CountDownLatch awaitResponseAndClose = new CountDownLatch(1);
+            final ActionListener<ExportBulk> bulkListener = ActionListener.wrap(
+                bulk -> {
+                    assertThat(bulk, nullValue());
+
+                    awaitResponseAndClose.countDown();
+                },
+                e -> fail(e.getMessage())
+            );
+
+            exporter.openBulk(bulkListener);
+
+            // wait for it to actually respond
+            assertTrue(awaitResponseAndClose.await(15, TimeUnit.SECONDS));
         }
     }
 
@@ -454,9 +496,20 @@ public class HttpExporterTests extends ESTestCase {
         try (HttpExporter exporter = new HttpExporter(config, client, sniffer, threadContext, listener, resource)) {
             verify(listener).setResource(resource);
 
-            final HttpExportBulk bulk = exporter.openBulk();
+            final CountDownLatch awaitResponseAndClose = new CountDownLatch(1);
+            final ActionListener<ExportBulk> bulkListener = ActionListener.wrap(
+                bulk -> {
+                    assertThat(bulk.getName(), equalTo(exporterName()));
 
-            assertThat(bulk.getName(), equalTo(exporterName()));
+                    awaitResponseAndClose.countDown();
+                },
+                e -> fail(e.getMessage())
+            );
+
+            exporter.openBulk(bulkListener);
+
+            // wait for it to actually respond
+            assertTrue(awaitResponseAndClose.await(15, TimeUnit.SECONDS));
         }
     }
 

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/HttpResourceTests.java

@@ -5,11 +5,15 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.test.ESTestCase;
 
 import java.util.function.Supplier;
 
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.mockBooleanActionListener;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -26,8 +30,8 @@ public class HttpResourceTests extends ESTestCase {
     public void testConstructorRequiresOwner() {
         expectThrows(NullPointerException.class, () -> new HttpResource(null) {
             @Override
-            protected boolean doCheckAndPublish(RestClient client) {
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
-                return false;
+                listener.onResponse(false);
             }
         });
     }
@@ -35,8 +39,8 @@ public class HttpResourceTests extends ESTestCase {
     public void testConstructor() {
         final HttpResource resource = new HttpResource(owner) {
             @Override
-            protected boolean doCheckAndPublish(RestClient client) {
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
-                return false;
+                listener.onResponse(false);
             }
         };
 
@@ -48,8 +52,8 @@ public class HttpResourceTests extends ESTestCase {
         final boolean dirty = randomBoolean();
         final HttpResource resource = new HttpResource(owner, dirty) {
             @Override
-            protected boolean doCheckAndPublish(RestClient client) {
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
-                return false;
+                listener.onResponse(false);
             }
         };
 
@@ -58,6 +62,7 @@ public class HttpResourceTests extends ESTestCase {
     }
 
     public void testDirtiness() {
+        final ActionListener<Boolean> listener = mockBooleanActionListener();
         // MockHttpResponse always succeeds for checkAndPublish
         final HttpResource resource = new MockHttpResource(owner);
 
@@ -68,59 +73,120 @@ public class HttpResourceTests extends ESTestCase {
         assertTrue(resource.isDirty());
 
         // if this fails, then the mocked resource needs to be fixed
-        assertTrue(resource.checkAndPublish(client));
+        resource.checkAndPublish(client, listener);
 
+        verify(listener).onResponse(true);
         assertFalse(resource.isDirty());
     }
 
     public void testCheckAndPublish() {
+        final ActionListener<Boolean> listener = mockBooleanActionListener();
         final boolean expected = randomBoolean();
         // the default dirtiness should be irrelevant; it should always be run!
         final HttpResource resource = new HttpResource(owner) {
             @Override
-            protected boolean doCheckAndPublish(final RestClient client) {
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
-            return expected;
+                listener.onResponse(expected);
-        }
-        };
-
-        assertEquals(expected, resource.checkAndPublish(client));
-    }
-
-    public void testCheckAndPublishEvenWhenDirty() {
-        final Supplier<Boolean> supplier = mock(Supplier.class);
-        when(supplier.get()).thenReturn(true, false);
-
-        final HttpResource resource = new HttpResource(owner) {
-            @Override
-            protected boolean doCheckAndPublish(final RestClient client) {
-                return supplier.get();
             }
         };
 
-        assertTrue(resource.isDirty());
+        resource.checkAndPublish(client, listener);
-        assertTrue(resource.checkAndPublish(client));
-        assertFalse(resource.isDirty());
-        assertFalse(resource.checkAndPublish(client));
 
-        verify(supplier, times(2)).get();
+        verify(listener).onResponse(expected);
     }
 
-    public void testCheckAndPublishIfDirty() {
+    public void testCheckAndPublishEvenWhenDirty() {
+        final ActionListener<Boolean> listener1 = mockBooleanActionListener();
+        final ActionListener<Boolean> listener2 = mockBooleanActionListener();
         @SuppressWarnings("unchecked")
         final Supplier<Boolean> supplier = mock(Supplier.class);
         when(supplier.get()).thenReturn(true, false);
 
         final HttpResource resource = new HttpResource(owner) {
             @Override
-            protected boolean doCheckAndPublish(final RestClient client) {
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
-                return supplier.get();
+                listener.onResponse(supplier.get());
             }
         };
 
         assertTrue(resource.isDirty());
-        assertTrue(resource.checkAndPublishIfDirty(client));
+        resource.checkAndPublish(client, listener1);
+        verify(listener1).onResponse(true);
         assertFalse(resource.isDirty());
-        assertTrue(resource.checkAndPublishIfDirty(client));
+        resource.checkAndPublish(client, listener2);
+        verify(listener2).onResponse(false);
+
+        verify(supplier, times(2)).get();
+    }
+
+    public void testCheckAndPublishIfDirtyFalseWhileChecking() throws InterruptedException {
+        final CountDownLatch firstCheck = new CountDownLatch(1);
+        final CountDownLatch secondCheck = new CountDownLatch(1);
+
+        final boolean response = randomBoolean();
+        final ActionListener<Boolean> listener = mockBooleanActionListener();
+        // listener used while checking is blocked, and thus should be ignored
+        final ActionListener<Boolean> checkingListener = ActionListener.wrap(
+            success -> {
+                // busy checking, so this should be ignored
+                assertFalse(success);
+                secondCheck.countDown();
+            },
+            e -> {
+                fail(e.getMessage());
+                secondCheck.countDown();
+            }
+        );
+
+        // the default dirtiness should be irrelevant; it should always be run!
+        final HttpResource resource = new HttpResource(owner) {
+            @Override
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
+                // wait until the second check has had a chance to run to completion,
+                // then respond here
+                final Thread thread = new Thread(() -> {
+                    try {
+                        assertTrue(secondCheck.await(15, TimeUnit.SECONDS));
+                        listener.onResponse(response);
+                    } catch (InterruptedException e) {
+                        listener.onFailure(e);
+                    }
+
+                    firstCheck.countDown();
+                });
+                thread.start();
+            }
+        };
+
+        resource.checkAndPublishIfDirty(client, listener);
+        resource.checkAndPublishIfDirty(client, checkingListener);
+
+        assertTrue(firstCheck.await(15, TimeUnit.SECONDS));
+
+        verify(listener).onResponse(response);
+
+    }
+
+    public void testCheckAndPublishIfDirty() {
+        final ActionListener<Boolean> listener1 = mockBooleanActionListener();
+        final ActionListener<Boolean> listener2 = mockBooleanActionListener();
+        @SuppressWarnings("unchecked")
+        final Supplier<Boolean> supplier = mock(Supplier.class);
+        when(supplier.get()).thenReturn(true, false);
+
+        final HttpResource resource = new HttpResource(owner) {
+            @Override
+            protected void doCheckAndPublish(RestClient client, ActionListener<Boolean> listener) {
+                listener.onResponse(supplier.get());
+            }
+        };
+
+        assertTrue(resource.isDirty());
+        resource.checkAndPublishIfDirty(client, listener1);
+        verify(listener1).onResponse(true);
+        assertFalse(resource.isDirty());
+        resource.checkAndPublishIfDirty(client, listener2);
+        verify(listener2).onResponse(true);
 
         // once is the default!
         verify(supplier).get();

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/MockHttpResource.java

@@ -5,6 +5,7 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.common.Nullable;
 import org.elasticsearch.common.unit.TimeValue;
@@ -17,8 +18,8 @@ import java.util.Map;
  */
 public class MockHttpResource extends PublishableHttpResource {
 
-    public final CheckResponse check;
+    public final Boolean check;
-    public final boolean publish;
+    public final Boolean publish;
 
     public int checked = 0;
     public int published = 0;
@@ -29,7 +30,7 @@ public class MockHttpResource extends PublishableHttpResource {
      * @param resourceOwnerName The user-recognizable name
      */
     public MockHttpResource(final String resourceOwnerName) {
-        this(resourceOwnerName, true, CheckResponse.EXISTS, true);
+        this(resourceOwnerName, true, true, true);
     }
 
     /**
@@ -39,7 +40,7 @@ public class MockHttpResource extends PublishableHttpResource {
      * @param dirty The starting dirtiness of the resource.
      */
     public MockHttpResource(final String resourceOwnerName, final boolean dirty) {
-        this(resourceOwnerName, dirty, CheckResponse.EXISTS, true);
+        this(resourceOwnerName, dirty, true, true);
     }
 
     /**
@@ -50,7 +51,7 @@ public class MockHttpResource extends PublishableHttpResource {
      * @param parameters The base parameters to specify for the request.
      */
     public MockHttpResource(final String resourceOwnerName, @Nullable final TimeValue masterTimeout, final Map<String, String> parameters) {
-        this(resourceOwnerName, masterTimeout, parameters, true, CheckResponse.EXISTS, true);
+        this(resourceOwnerName, masterTimeout, parameters, true, true, true);
     }
 
     /**
@@ -59,9 +60,9 @@ public class MockHttpResource extends PublishableHttpResource {
      * @param resourceOwnerName The user-recognizable name
      * @param dirty The starting dirtiness of the resource.
      * @param check The expected response when checking for the resource.
-     * @param publish The expected response when publishing the resource (assumes check was {@link CheckResponse#DOES_NOT_EXIST}).
+     * @param publish The expected response when publishing the resource (assumes check was {@code false}).
      */
-    public MockHttpResource(final String resourceOwnerName, final boolean dirty, final CheckResponse check, final boolean publish) {
+    public MockHttpResource(final String resourceOwnerName, final boolean dirty, final Boolean check, final Boolean publish) {
         this(resourceOwnerName, null, Collections.emptyMap(), dirty, check, publish);
     }
 
@@ -70,12 +71,12 @@ public class MockHttpResource extends PublishableHttpResource {
      *
      * @param resourceOwnerName The user-recognizable name
      * @param check The expected response when checking for the resource.
-     * @param publish The expected response when publishing the resource (assumes check was {@link CheckResponse#DOES_NOT_EXIST}).
+     * @param publish The expected response when publishing the resource (assumes check was {@code false}).
      * @param masterTimeout Master timeout to use with any request.
      * @param parameters The base parameters to specify for the request.
      */
     public MockHttpResource(final String resourceOwnerName, @Nullable final TimeValue masterTimeout, final Map<String, String> parameters,
-                            final CheckResponse check, final boolean publish) {
+                            final Boolean check, final Boolean publish) {
         this(resourceOwnerName, masterTimeout, parameters, true, check, publish);
     }
 
@@ -85,12 +86,12 @@ public class MockHttpResource extends PublishableHttpResource {
      * @param resourceOwnerName The user-recognizable name
      * @param dirty The starting dirtiness of the resource.
      * @param check The expected response when checking for the resource.
-     * @param publish The expected response when publishing the resource (assumes check was {@link CheckResponse#DOES_NOT_EXIST}).
+     * @param publish The expected response when publishing the resource (assumes check was {@code false}).
      * @param masterTimeout Master timeout to use with any request.
      * @param parameters The base parameters to specify for the request.
      */
     public MockHttpResource(final String resourceOwnerName, @Nullable final TimeValue masterTimeout, final Map<String, String> parameters,
-                            final boolean dirty, final CheckResponse check, final boolean publish) {
+                            final boolean dirty, final Boolean check, final Boolean publish) {
         super(resourceOwnerName, masterTimeout, parameters, dirty);
 
         this.check = check;
@@ -98,21 +99,30 @@ public class MockHttpResource extends PublishableHttpResource {
     }
 
     @Override
-    protected CheckResponse doCheck(final RestClient client) {
+    protected void doCheck(final RestClient client, final ActionListener<Boolean> listener) {
         assert client != null;
 
         ++checked;
 
-        return check;
+        if (check == null) {
+            listener.onFailure(new RuntimeException("TEST - expected"));
+        } else {
+            listener.onResponse(check);
+        }
     }
 
     @Override
-    protected boolean doPublish(final RestClient client) {
+    protected void doPublish(final RestClient client, final ActionListener<Boolean> listener) {
         assert client != null;
 
         ++published;
 
-        return publish;
+
+        if (publish == null) {
+            listener.onFailure(new RuntimeException("TEST - expected"));
+        } else {
+            listener.onResponse(publish);
+        }
     }
 
 }

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/MultiHttpResourceTests.java

@@ -5,16 +5,19 @@
  */
 package org.elasticsearch.xpack.monitoring.exporter.http;
 
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.RestClient;
 import org.elasticsearch.test.ESTestCase;
-import org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse;
 
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.mockBooleanActionListener;
 import static org.hamcrest.Matchers.equalTo;
+import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
 
 /**
  * Tests {@link MultiHttpResource}.
@@ -23,12 +26,15 @@ public class MultiHttpResourceTests extends ESTestCase {
 
     private final String owner = getClass().getSimpleName();
     private final RestClient client = mock(RestClient.class);
+    private final ActionListener<Boolean> listener = mockBooleanActionListener();
 
     public void testDoCheckAndPublish() {
         final List<MockHttpResource> allResources = successfulResources();
         final MultiHttpResource multiResource = new MultiHttpResource(owner, allResources);
 
-        assertTrue(multiResource.doCheckAndPublish(client));
+        multiResource.doCheckAndPublish(client, listener);
+
+        verify(listener).onResponse(true);
 
         for (final MockHttpResource resource : allResources) {
             assertSuccessfulResource(resource);
@@ -37,8 +43,8 @@ public class MultiHttpResourceTests extends ESTestCase {
 
     public void testDoCheckAndPublishShortCircuits() {
         // fail either the check or the publish
-        final CheckResponse check = randomFrom(CheckResponse.ERROR, CheckResponse.DOES_NOT_EXIST);
+        final Boolean check = randomBoolean() ? null : false;
-        final boolean publish = check == CheckResponse.ERROR;
+        final boolean publish = check == null;
         final List<MockHttpResource> allResources = successfulResources();
         final MockHttpResource failureResource = new MockHttpResource(owner, true, check, publish);
 
@@ -48,7 +54,13 @@ public class MultiHttpResourceTests extends ESTestCase {
 
         final MultiHttpResource multiResource = new MultiHttpResource(owner, allResources);
 
-        assertFalse(multiResource.doCheckAndPublish(client));
+        multiResource.doCheckAndPublish(client, listener);
+
+        if (check == null) {
+            verify(listener).onFailure(any(Exception.class));
+        } else {
+            verify(listener).onResponse(false);
+        }
 
         boolean found = false;
 
@@ -56,7 +68,7 @@ public class MultiHttpResourceTests extends ESTestCase {
             // should stop looking at this point
             if (resource == failureResource) {
                 assertThat(resource.checked, equalTo(1));
-                if (resource.check == CheckResponse.ERROR) {
+                if (resource.check == null) {
                     assertThat(resource.published, equalTo(0));
                 } else {
                     assertThat(resource.published, equalTo(1));
@@ -85,8 +97,8 @@ public class MultiHttpResourceTests extends ESTestCase {
         final List<MockHttpResource> resources = new ArrayList<>(successful);
 
         for (int i = 0; i < successful; ++i) {
-            final CheckResponse check = randomFrom(CheckResponse.DOES_NOT_EXIST, CheckResponse.EXISTS);
+            final boolean check = randomBoolean();
-            final MockHttpResource resource = new MockHttpResource(owner, randomBoolean(), check, check == CheckResponse.DOES_NOT_EXIST);
+            final MockHttpResource resource = new MockHttpResource(owner, randomBoolean(), check, check == false);
 
             resources.add(resource);
         }
@@ -96,7 +108,7 @@ public class MultiHttpResourceTests extends ESTestCase {
 
     private void assertSuccessfulResource(final MockHttpResource resource) {
         assertThat(resource.checked, equalTo(1));
-        if (resource.check == CheckResponse.DOES_NOT_EXIST) {
+        if (resource.check == false) {
             assertThat(resource.published, equalTo(1));
         } else {
             assertThat(resource.published, equalTo(0));

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/PipelineHttpResourceTests.java

@@ -15,9 +15,6 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.util.function.Supplier;
 
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.DOES_NOT_EXIST;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.ERROR;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.EXISTS;
 import static org.hamcrest.Matchers.is;
 
 /**
@@ -48,46 +45,42 @@ public class PipelineHttpResourceTests extends AbstractPublishableHttpResourceTe
         assertThat(byteStream.available(), is(0));
     }
 
-    public void testDoCheckExists() throws IOException {
+    public void testDoCheckExists() {
-        final HttpEntity entity = entityForResource(EXISTS, pipelineName, minimumVersion);
+        final HttpEntity entity = entityForResource(true, pipelineName, minimumVersion);
 
-        doCheckWithStatusCode(resource, "/_ingest/pipeline", pipelineName, successfulCheckStatus(), EXISTS, entity);
+        doCheckWithStatusCode(resource, "/_ingest/pipeline", pipelineName, successfulCheckStatus(), true, entity);
     }
 
-    public void testDoCheckDoesNotExist() throws IOException {
+    public void testDoCheckDoesNotExist() {
         if (randomBoolean()) {
             // it does not exist because it's literally not there
             assertCheckDoesNotExist(resource, "/_ingest/pipeline", pipelineName);
         } else {
             // it does not exist because we need to replace it
-            final HttpEntity entity = entityForResource(DOES_NOT_EXIST, pipelineName, minimumVersion);
+            final HttpEntity entity = entityForResource(false, pipelineName, minimumVersion);
 
             doCheckWithStatusCode(resource, "/_ingest/pipeline", pipelineName,
-                                  successfulCheckStatus(), DOES_NOT_EXIST, entity);
+                                  successfulCheckStatus(), false, entity);
         }
     }
 
-    public void testDoCheckError() throws IOException {
+    public void testDoCheckError() {
         if (randomBoolean()) {
             // error because of a server error
             assertCheckWithException(resource, "/_ingest/pipeline", pipelineName);
         } else {
             // error because of a malformed response
-            final HttpEntity entity = entityForResource(ERROR, pipelineName, minimumVersion);
+            final HttpEntity entity = entityForResource(null, pipelineName, minimumVersion);
 
-            doCheckWithStatusCode(resource, "/_ingest/pipeline", pipelineName, successfulCheckStatus(), ERROR, entity);
+            doCheckWithStatusCode(resource, "/_ingest/pipeline", pipelineName, successfulCheckStatus(), null, entity);
         }
     }
 
-    public void testDoPublishTrue() throws IOException {
+    public void testDoPublishTrue() {
         assertPublishSucceeds(resource, "/_ingest/pipeline", pipelineName, ByteArrayEntity.class);
     }
 
-    public void testDoPublishFalse() throws IOException {
+    public void testDoPublishFalseWithException() {
-        assertPublishFails(resource, "/_ingest/pipeline", pipelineName, ByteArrayEntity.class);
-    }
-
-    public void testDoPublishFalseWithException() throws IOException {
         assertPublishWithException(resource, "/_ingest/pipeline", pipelineName, ByteArrayEntity.class);
     }
 

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/PublishableHttpResourceTests.java

@@ -13,25 +13,28 @@ import org.apache.logging.log4j.Logger;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.ResponseException;
+import org.elasticsearch.client.ResponseListener;
 import org.elasticsearch.client.RestClient;
+import org.elasticsearch.common.CheckedFunction;
 import org.elasticsearch.common.SuppressLoggerChecks;
-import org.elasticsearch.common.collect.Tuple;
 import org.elasticsearch.common.xcontent.XContent;
 import org.elasticsearch.common.xcontent.XContentType;
 import org.elasticsearch.rest.RestStatus;
-import org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse;
 
 import org.mockito.ArgumentCaptor;
 
 import java.io.IOException;
 import java.util.function.Supplier;
 
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.whenPerformRequestAsyncWith;
 import static org.hamcrest.Matchers.is;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
+import static org.mockito.Mockito.verifyZeroInteractions;
 import static org.mockito.Mockito.when;
 
 /**
@@ -51,11 +54,11 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
             new MockHttpResource(owner, masterTimeout, PublishableHttpResource.NO_BODY_PARAMETERS);
 
     public void testCheckForResourceExists() throws IOException {
-        assertCheckForResource(successfulCheckStatus(), CheckResponse.EXISTS, "{} [{}] found on the [{}] {}");
+        assertCheckForResource(successfulCheckStatus(), true, "{} [{}] found on the [{}] {}");
     }
 
     public void testCheckForResourceDoesNotExist() throws IOException {
-        assertCheckForResource(notFoundCheckStatus(), CheckResponse.DOES_NOT_EXIST, "{} [{}] does not exist on the [{}] {}");
+        assertCheckForResource(notFoundCheckStatus(), false, "{} [{}] does not exist on the [{}] {}");
     }
 
     public void testCheckForResourceUnexpectedResponse() throws IOException {
@@ -65,34 +68,34 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        sometimesAssertSimpleCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, CheckResponse.ERROR, response);
+        assertCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, null, response);
 
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), any(ResponseException.class));
 
         verifyNoMoreInteractions(client, logger);
     }
 
-    public void testVersionCheckForResourceExists() throws IOException {
+    public void testVersionCheckForResourceExists() {
-        assertVersionCheckForResource(successfulCheckStatus(), CheckResponse.EXISTS, randomInt(), "{} [{}] found on the [{}] {}");
+        assertVersionCheckForResource(successfulCheckStatus(), true, randomInt(), "{} [{}] found on the [{}] {}");
     }
 
-    public void testVersionCheckForResourceDoesNotExist() throws IOException {
+    public void testVersionCheckForResourceDoesNotExist() {
         if (randomBoolean()) {
             // it literally does not exist
-            assertVersionCheckForResource(notFoundCheckStatus(), CheckResponse.DOES_NOT_EXIST,
+            assertVersionCheckForResource(notFoundCheckStatus(), false,
                                           randomInt(), "{} [{}] does not exist on the [{}] {}");
         } else {
             // it DOES exist, but the version needs to be replaced
-            assertVersionCheckForResource(successfulCheckStatus(), CheckResponse.DOES_NOT_EXIST,
+            assertVersionCheckForResource(successfulCheckStatus(), false,
                                           randomInt(), "{} [{}] found on the [{}] {}");
         }
     }
 
-    public void testVersionCheckForResourceUnexpectedResponse() throws IOException {
+    public void testVersionCheckForResourceUnexpectedResponse() {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final RestStatus failedStatus = failedCheckStatus();
         final Response response = response("GET", endpoint, failedStatus);
@@ -101,41 +104,41 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.versionCheckForResource(client, logger,
+        resource.versionCheckForResource(client, listener, logger,
-                                                    resourceBasePath, resourceName, resourceType, owner, ownerType,
+                                         resourceBasePath, resourceName, resourceType, owner, ownerType,
-                                                    xContent, minimumVersion),
+                                         xContent, minimumVersion);
-                   is(CheckResponse.ERROR));
 
+        verifyListener(null);
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), any(ResponseException.class));
 
         verifyNoMoreInteractions(client, logger);
     }
 
-    public void testVersionCheckForResourceMalformedResponse() throws IOException {
+    public void testVersionCheckForResourceMalformedResponse() {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final RestStatus okStatus = successfulCheckStatus();
         final int minimumVersion = randomInt();
-        final HttpEntity entity = entityForResource(CheckResponse.ERROR, resourceName, minimumVersion);
+        final HttpEntity entity = entityForResource(null, resourceName, minimumVersion);
         final Response response = response("GET", endpoint, okStatus, entity);
         final XContent xContent = mock(XContent.class);
         final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.versionCheckForResource(client, logger,
+        resource.versionCheckForResource(client, listener, logger,
-                                                    resourceBasePath, resourceName, resourceType, owner, ownerType,
+                                         resourceBasePath, resourceName, resourceType, owner, ownerType,
-                                                    xContent, minimumVersion),
+                                         xContent, minimumVersion);
-                   is(CheckResponse.ERROR));
 
+        verifyListener(null);
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
         verify(logger).debug("{} [{}] found on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
-        verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), any(ResponseException.class));
+        verify(logger, times(2)).error(any(org.apache.logging.log4j.util.Supplier.class), any(ResponseException.class));
 
         verifyNoMoreInteractions(client, logger);
     }
@@ -147,56 +150,59 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         final Exception e = randomFrom(new IOException("expected"), new RuntimeException("expected"), responseException);
         final Response response = e == responseException ? responseException.getResponse() : null;
 
-        Request request = new Request("GET", endpoint);
+        final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
-        when(client.performRequest(request)).thenThrow(e);
 
-        sometimesAssertSimpleCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, CheckResponse.ERROR, response);
+        whenPerformRequestAsyncWith(client, request, e);
+
+        assertCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, null, response);
 
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), eq(e));
 
         verifyNoMoreInteractions(client, logger);
     }
 
-    public void testPutResourceTrue() throws IOException {
+    public void testPutResourceTrue() {
         assertPutResource(successfulPublishStatus(), true);
     }
 
-    public void testPutResourceFalse() throws IOException {
+    public void testPutResourceFalse() {
         assertPutResource(failedPublishStatus(), false);
     }
 
-    public void testPutResourceFalseWithException() throws IOException {
+    public void testPutResourceFalseWithException() {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Exception e = randomFrom(new IOException("expected"), new RuntimeException("expected"));
         final Request request = new Request("PUT", endpoint);
         addParameters(request, resource.getParameters());
         request.setEntity(entity);
 
-        when(client.performRequest(request)).thenThrow(e);
+        whenPerformRequestAsyncWith(client, request, e);
 
-        assertThat(resource.putResource(client, logger, resourceBasePath, resourceName, body, resourceType, owner, ownerType), is(false));
+        resource.putResource(client, listener, logger, resourceBasePath, resourceName, body, resourceType, owner, ownerType);
+
+        verifyListener(null);
 
         verify(logger).trace("uploading {} [{}] to the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), eq(e));
 
         verifyNoMoreInteractions(client, logger);
     }
 
-    public void testDeleteResourceTrue() throws IOException {
+    public void testDeleteResourceTrue() {
         final RestStatus status = randomFrom(successfulCheckStatus(), notFoundCheckStatus());
 
         assertDeleteResource(status, true);
     }
 
-    public void testDeleteResourceFalse() throws IOException {
+    public void testDeleteResourceFalse() {
         assertDeleteResource(failedCheckStatus(), false);
     }
 
-    public void testDeleteResourceErrors() throws IOException {
+    public void testDeleteResourceErrors() {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final RestStatus failedStatus = failedCheckStatus();
         final ResponseException responseException = responseException("DELETE", endpoint, failedStatus);
@@ -205,12 +211,14 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         final Request request = new Request("DELETE", endpoint);
         addParameters(request, deleteParameters);
 
-        when(client.performRequest(request)).thenThrow(e);
+        whenPerformRequestAsyncWith(client, request, e);
 
-        assertThat(resource.deleteResource(client, logger, resourceBasePath, resourceName, resourceType, owner, ownerType), is(false));
+        resource.deleteResource(client, listener, logger, resourceBasePath, resourceName, resourceType, owner, ownerType);
+
+        verifyListener(null);
 
         verify(logger).trace("deleting {} [{}] from the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(logger).error(any(org.apache.logging.log4j.util.Supplier.class), eq(e));
 
         verifyNoMoreInteractions(client, logger);
@@ -222,20 +230,24 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
 
     public void testDoCheckAndPublishIgnoresPublishWhenCheckErrors() {
         final PublishableHttpResource resource =
-                new MockHttpResource(owner, masterTimeout, PublishableHttpResource.NO_BODY_PARAMETERS, CheckResponse.ERROR, true);
+                new MockHttpResource(owner, masterTimeout, PublishableHttpResource.NO_BODY_PARAMETERS, null, true);
 
-        assertThat(resource.doCheckAndPublish(client), is(false));
+        resource.doCheckAndPublish(client, listener);
+
+        verifyListener(null);
     }
 
     public void testDoCheckAndPublish() {
         // not an error (the third state)
-        final PublishableHttpResource.CheckResponse exists = randomBoolean() ? CheckResponse.EXISTS : CheckResponse.DOES_NOT_EXIST;
+        final boolean exists = randomBoolean();
         final boolean publish = randomBoolean();
 
         final PublishableHttpResource resource =
                 new MockHttpResource(owner, masterTimeout, PublishableHttpResource.NO_BODY_PARAMETERS, exists, publish);
 
-        assertThat(resource.doCheckAndPublish(client), is(exists == CheckResponse.EXISTS || publish));
+        resource.doCheckAndPublish(client, listener);
+
+        verifyListener(exists || publish);
     }
 
     public void testShouldReplaceResourceRethrowsIOException() throws IOException {
@@ -249,9 +261,9 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         expectThrows(IOException.class, () -> resource.shouldReplaceResource(response, xContent, resourceName, randomInt()));
     }
 
-    public void testShouldReplaceResourceThrowsExceptionForMalformedResponse() throws IOException {
+    public void testShouldReplaceResourceThrowsExceptionForMalformedResponse() {
         final Response response = mock(Response.class);
-        final HttpEntity entity = entityForResource(CheckResponse.ERROR, resourceName, randomInt());
+        final HttpEntity entity = entityForResource(null, resourceName, randomInt());
         final XContent xContent = XContentType.JSON.xContent();
 
         when(response.getEntity()).thenReturn(entity);
@@ -262,7 +274,7 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
     public void testShouldReplaceResourceReturnsTrueVersionIsNotExpected() throws IOException {
         final int minimumVersion = randomInt();
         final Response response = mock(Response.class);
-        final HttpEntity entity = entityForResource(CheckResponse.DOES_NOT_EXIST, resourceName, minimumVersion);
+        final HttpEntity entity = entityForResource(false, resourceName, minimumVersion);
         final XContent xContent = XContentType.JSON.xContent();
 
         when(response.getEntity()).thenReturn(entity);
@@ -287,21 +299,21 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
     }
 
     @SuppressLoggerChecks(reason = "mock logger used")
-    private void assertCheckForResource(final RestStatus status, final CheckResponse expected, final String debugLogMessage)
+    private void assertCheckForResource(final RestStatus status, final Boolean expected, final String debugLogMessage)
             throws IOException {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("GET", endpoint, status);
         final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        sometimesAssertSimpleCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, expected, response);
+        assertCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, expected, response);
 
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
 
-        if (expected == CheckResponse.EXISTS || expected == CheckResponse.DOES_NOT_EXIST) {
+        if (expected != null) {
             verify(response).getStatusLine();
         } else {
             verify(response).getStatusLine();
@@ -316,64 +328,62 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
     }
 
     @SuppressLoggerChecks(reason = "mock logger used")
-    private void assertVersionCheckForResource(final RestStatus status, final CheckResponse expected,
+    private void assertVersionCheckForResource(final RestStatus status, final Boolean expected,
                                                final int minimumVersion,
-                                               final String debugLogMessage)
+                                               final String debugLogMessage) {
-            throws IOException {
-
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
-        final boolean shouldReplace = status == RestStatus.OK && expected == CheckResponse.DOES_NOT_EXIST;
+        final boolean shouldReplace = status == RestStatus.OK && expected == Boolean.FALSE;
         final HttpEntity entity = status == RestStatus.OK ? entityForResource(expected, resourceName, minimumVersion) : null;
         final Response response = response("GET", endpoint, status, entity);
         final XContent xContent = XContentType.JSON.xContent();
         final Request request = new Request("GET", endpoint);
         addParameters(request, getParameters(resource.getParameters()));
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.versionCheckForResource(client, logger,
+        resource.versionCheckForResource(client, listener, logger,
-                                                    resourceBasePath, resourceName, resourceType, owner, ownerType,
+                                         resourceBasePath, resourceName, resourceType, owner, ownerType,
-                                                    xContent, minimumVersion),
+                                         xContent, minimumVersion);
-                   is(expected));
 
         verify(logger).trace("checking if {} [{}] exists on the [{}] {}", resourceType, resourceName, owner, ownerType);
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
 
-        if (shouldReplace || expected == CheckResponse.EXISTS) {
+        if (shouldReplace || expected == true) {
             verify(response).getStatusLine();
             verify(response).getEntity();
-        } else if (expected == CheckResponse.DOES_NOT_EXIST) {
+        } else if (expected == false) {
             verify(response).getStatusLine();
-        } else {
+        } else { // expected == null
             verify(response).getStatusLine();
             verify(response).getRequestLine();
             verify(response).getHost();
             verify(response).getEntity();
         }
 
+        verifyListener(expected);
         verify(logger).debug(debugLogMessage, resourceType, resourceName, owner, ownerType);
 
         verifyNoMoreInteractions(client, response, logger);
     }
 
-    private void assertPutResource(final RestStatus status, final boolean expected) throws IOException {
+    private void assertPutResource(final RestStatus status, final boolean errorFree) {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("PUT", endpoint, status);
         final Request request = new Request("PUT", endpoint);
         addParameters(request, resource.getParameters());
         request.setEntity(entity);
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.putResource(client, logger, resourceBasePath, resourceName, body, resourceType, owner, ownerType),
+        resource.putResource(client, listener, logger, resourceBasePath, resourceName, body, resourceType, owner, ownerType);
-                   is(expected));
 
-        verify(client).performRequest(request);
+        verifyListener(errorFree ? true : null);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(response).getStatusLine();
 
         verify(logger).trace("uploading {} [{}] to the [{}] {}", resourceType, resourceName, owner, ownerType);
 
-        if (expected) {
+        if (errorFree) {
             verify(logger).debug("{} [{}] uploaded to the [{}] {}", resourceType, resourceName, owner, ownerType);
         } else {
             ArgumentCaptor<RuntimeException> e = ArgumentCaptor.forClass(RuntimeException.class);
@@ -387,42 +397,56 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
         verifyNoMoreInteractions(client, response, logger, entity);
     }
 
-    private void sometimesAssertSimpleCheckForResource(final RestClient client, final Logger logger,
+    @SuppressWarnings("unchecked")
-                                                       final String resourceBasePath,
+    private void assertCheckForResource(final RestClient client, final Logger logger,
-                                                       final String resourceName, final String resourceType,
+                                        final String resourceBasePath, final String resourceName, final String resourceType,
-                                                       final CheckResponse expected, final Response response) {
+                                        final Boolean expected, final Response response)
-        // sometimes use the simple check
+            throws IOException {
-        if (randomBoolean()) {
+        final CheckedFunction<Response, Boolean, IOException> responseChecker = mock(CheckedFunction.class);
-            assertThat(resource.simpleCheckForResource(client, logger, resourceBasePath, resourceName, resourceType, owner, ownerType),
+        final CheckedFunction<Response, Boolean, IOException> dneResponseChecker = mock(CheckedFunction.class);
-                    is(expected));
-        } else {
-            final Tuple<CheckResponse, Response> responseTuple =
-                    resource.checkForResource(client, logger, resourceBasePath, resourceName, resourceType, owner, ownerType,
-                                              PublishableHttpResource.GET_EXISTS, PublishableHttpResource.GET_DOES_NOT_EXIST);
 
-            assertThat(responseTuple.v1(), is(expected));
+        if (expected != null) {
-            assertThat(responseTuple.v2(), is(response));
+            // invert expected to keep the same value
+            when(responseChecker.apply(response)).thenReturn(false == expected);
+            when(dneResponseChecker.apply(response)).thenReturn(false == expected);
         }
+
+        resource.checkForResource(client, listener, logger, resourceBasePath, resourceName, resourceType, owner, ownerType,
+                                  PublishableHttpResource.GET_EXISTS, PublishableHttpResource.GET_DOES_NOT_EXIST,
+                                  responseChecker, dneResponseChecker);
+
+        if (expected == Boolean.TRUE) {
+            verify(responseChecker).apply(response);
+            verifyZeroInteractions(dneResponseChecker);
+        } else if (expected == Boolean.FALSE) {
+            verifyZeroInteractions(responseChecker);
+            verify(dneResponseChecker).apply(response);
+        } else {
+            verifyZeroInteractions(responseChecker, dneResponseChecker);
+        }
+
+        verifyListener(expected);
     }
 
-    private void assertDeleteResource(final RestStatus status, final boolean expected) throws IOException {
+    private void assertDeleteResource(final RestStatus status, final boolean expected) {
         final String endpoint = concatenateEndpoint(resourceBasePath, resourceName);
         final Response response = response("DELETE", endpoint, status);
         final Map<String, String> deleteParameters = deleteParameters(resource.getParameters());
         final Request request = new Request("DELETE", endpoint);
         addParameters(request, deleteParameters);
 
-        when(client.performRequest(request)).thenReturn(response);
+        whenPerformRequestAsyncWith(client, request, response);
 
-        assertThat(resource.deleteResource(client, logger, resourceBasePath, resourceName, resourceType, owner, ownerType), is(expected));
+        resource.deleteResource(client, listener, logger, resourceBasePath, resourceName, resourceType, owner, ownerType);
 
-        verify(client).performRequest(request);
+        verify(client).performRequestAsync(eq(request), any(ResponseListener.class));
         verify(response).getStatusLine();
 
         verify(logger).trace("deleting {} [{}] from the [{}] {}", resourceType, resourceName, owner, ownerType);
 
         if (expected) {
             verify(logger).debug("{} [{}] deleted from the [{}] {}", resourceType, resourceName, owner, ownerType);
+            verifyListener(true);
         } else {
             ArgumentCaptor<RuntimeException> e = ArgumentCaptor.forClass(RuntimeException.class);
 
@@ -430,6 +454,7 @@ public class PublishableHttpResourceTests extends AbstractPublishableHttpResourc
 
             assertThat(e.getValue().getMessage(),
                        is("[" + resourceBasePath + "/" + resourceName + "] responded with [" + status.getStatus() + "]"));
+            verifyListener(null);
         }
 
         verifyNoMoreInteractions(client, response, logger, entity);

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/TemplateHttpResourceTests.java

@@ -15,9 +15,6 @@ import java.io.IOException;
 import java.io.InputStream;
 import java.util.function.Supplier;
 
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.DOES_NOT_EXIST;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.ERROR;
-import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse.EXISTS;
 import static org.hamcrest.Matchers.is;
 
 /**
@@ -49,45 +46,41 @@ public class TemplateHttpResourceTests extends AbstractPublishableHttpResourceTe
         assertThat(byteStream.available(), is(0));
     }
 
-    public void testDoCheckExists() throws IOException {
+    public void testDoCheckExists() {
-        final HttpEntity entity = entityForResource(EXISTS, templateName, minimumVersion);
+        final HttpEntity entity = entityForResource(true, templateName, minimumVersion);
 
-        doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), EXISTS, entity);
+        doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), true, entity);
     }
 
-    public void testDoCheckDoesNotExist() throws IOException {
+    public void testDoCheckDoesNotExist() {
         if (randomBoolean()) {
             // it does not exist because it's literally not there
             assertCheckDoesNotExist(resource, "/_template", templateName);
         } else {
             // it does not exist because we need to replace it
-            final HttpEntity entity = entityForResource(DOES_NOT_EXIST, templateName, minimumVersion);
+            final HttpEntity entity = entityForResource(false, templateName, minimumVersion);
 
-            doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), DOES_NOT_EXIST, entity);
+            doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), false, entity);
         }
     }
 
-    public void testDoCheckError() throws IOException {
+    public void testDoCheckError() {
         if (randomBoolean()) {
             // error because of a server error
             assertCheckWithException(resource, "/_template", templateName);
         } else {
             // error because of a malformed response
-            final HttpEntity entity = entityForResource(ERROR, templateName, minimumVersion);
+            final HttpEntity entity = entityForResource(null, templateName, minimumVersion);
 
-            doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), ERROR, entity);
+            doCheckWithStatusCode(resource, "/_template", templateName, successfulCheckStatus(), null, entity);
         }
     }
 
-    public void testDoPublishTrue() throws IOException {
+    public void testDoPublishTrue() {
         assertPublishSucceeds(resource, "/_template", templateName, StringEntity.class);
     }
 
-    public void testDoPublishFalse() throws IOException {
+    public void testDoPublishFalseWithException() {
-        assertPublishFails(resource, "/_template", templateName, StringEntity.class);
-    }
-
-    public void testDoPublishFalseWithException() throws IOException {
         assertPublishWithException(resource, "/_template", templateName, StringEntity.class);
     }
 

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/VersionHttpResourceTests.java

@@ -8,6 +8,7 @@ package org.elasticsearch.xpack.monitoring.exporter.http;
 import org.apache.http.entity.ContentType;
 import org.apache.http.nio.entity.NStringEntity;
 import org.elasticsearch.Version;
+import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.RestClient;
@@ -16,6 +17,9 @@ import org.elasticsearch.test.VersionUtils;
 
 import java.io.IOException;
 
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.mockBooleanActionListener;
+import static org.elasticsearch.xpack.monitoring.exporter.http.AsyncHttpResourceHelper.whenPerformRequestAsyncWith;
+import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
@@ -27,76 +31,85 @@ public class VersionHttpResourceTests extends ESTestCase {
 
     private final String owner = getClass().getSimpleName();
     private final RestClient client = mock(RestClient.class);
+    private final ActionListener<Boolean> listener = mockBooleanActionListener();
 
-    public void testDoCheckAndPublishSuccess() throws IOException {
+    public void testDoCheckAndPublishSuccess() {
         final Version minimumVersion = VersionUtils.randomVersion(random());
         final Version version = randomFrom(minimumVersion, Version.CURRENT);
         final Response response = responseForVersion(version);
 
         final VersionHttpResource resource = new VersionHttpResource(owner, minimumVersion);
 
-        assertTrue(resource.doCheckAndPublish(client));
+        resource.doCheckAndPublish(client, listener);
 
+        verify(listener).onResponse(true);
         verify(response).getEntity();
     }
 
-    public void testDoCheckAndPublishFailedParsing() throws IOException {
+    public void testDoCheckAndPublishFailedParsing() {
         // malformed JSON
         final Response response = responseForJSON("{");
 
         final VersionHttpResource resource = new VersionHttpResource(owner, Version.CURRENT);
 
-        assertFalse(resource.doCheckAndPublish(client));
+        resource.doCheckAndPublish(client, listener);
 
+        verify(listener).onFailure(any(Exception.class));
         verify(response).getEntity();
     }
 
-    public void testDoCheckAndPublishFailedFieldMissing() throws IOException {
+    public void testDoCheckAndPublishFailedFieldMissing() {
         // malformed response; imagining that we may change it in the future or someone breaks filter_path
         final Response response = responseForJSON("{\"version.number\":\"" + Version.CURRENT + "\"}");
 
         final VersionHttpResource resource = new VersionHttpResource(owner, Version.CURRENT);
 
-        assertFalse(resource.doCheckAndPublish(client));
+        resource.doCheckAndPublish(client, listener);
 
+        verify(listener).onFailure(any(Exception.class));
         verify(response).getEntity();
     }
 
-    public void testDoCheckAndPublishFailedFieldWrongType() throws IOException {
+    public void testDoCheckAndPublishFailedFieldWrongType() {
         // malformed response (should be {version: { number : ... }})
         final Response response = responseForJSON("{\"version\":\"" + Version.CURRENT + "\"}");
 
         final VersionHttpResource resource = new VersionHttpResource(owner, Version.CURRENT);
 
-        assertFalse(resource.doCheckAndPublish(client));
+        resource.doCheckAndPublish(client, listener);
 
+        verify(listener).onFailure(any(Exception.class));
         verify(response).getEntity();
     }
 
-    public void testDoCheckAndPublishFailedWithIOException() throws IOException {
+    public void testDoCheckAndPublishFailedWithIOException() {
-        Request request = new Request("GET", "/");
+        final Request request = new Request("GET", "/");
         request.addParameter("filter_path", "version.number");
-        when(client.performRequest(request)).thenThrow(new IOException("expected"));
+
+        whenPerformRequestAsyncWith(client, request, new IOException("expected"));
 
         final VersionHttpResource resource = new VersionHttpResource(owner, Version.CURRENT);
 
-        assertFalse(resource.doCheckAndPublish(client));
+        resource.doCheckAndPublish(client, listener);
+
+        verify(listener).onFailure(any(Exception.class));
     }
 
-    private Response responseForJSON(final String json) throws IOException {
+    private Response responseForJSON(final String json) {
         final NStringEntity entity = new NStringEntity(json, ContentType.APPLICATION_JSON);
 
         final Response response = mock(Response.class);
         when(response.getEntity()).thenReturn(entity);
 
-        Request request = new Request("GET", "/");
+        final Request request = new Request("GET", "/");
         request.addParameter("filter_path", "version.number");
-        when(client.performRequest(request)).thenReturn(response);
+
+        whenPerformRequestAsyncWith(client, request, response);
 
         return response;
     }
 
-    private Response responseForVersion(final Version version) throws IOException {
+    private Response responseForVersion(final Version version) {
         return responseForJSON("{\"version\":{\"number\":\"" + version + "\"}}");
     }
 

x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/exporter/http/WatcherExistsHttpResourceTests.java

@@ -14,9 +14,7 @@ import org.elasticsearch.cluster.ClusterState;
 import org.elasticsearch.cluster.node.DiscoveryNodes;
 import org.elasticsearch.cluster.service.ClusterService;
 import org.elasticsearch.rest.RestStatus;
-import org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.CheckResponse;
 
-import java.io.IOException;
 import java.util.Map;
 
 import static org.elasticsearch.xpack.monitoring.exporter.http.PublishableHttpResource.GET_EXISTS;
@@ -42,28 +40,29 @@ public class WatcherExistsHttpResourceTests extends AbstractPublishableHttpResou
     public void testDoCheckIgnoresClientWhenNotElectedMaster() {
         whenNotElectedMaster();
 
-        assertThat(resource.doCheck(client), is(CheckResponse.EXISTS));
+        resource.doCheck(client, listener);
 
+        verify(listener).onResponse(true);
         verifyZeroInteractions(client);
     }
 
-    public void testDoCheckExistsFor404() throws IOException {
+    public void testDoCheckExistsFor404() {
         whenElectedMaster();
 
         // /_xpack returning a 404 means ES didn't handle the request properly and X-Pack doesn't exist
         doCheckWithStatusCode(resource, "", "_xpack", notFoundCheckStatus(),
-                              GET_EXISTS, XPACK_DOES_NOT_EXIST, CheckResponse.EXISTS);
+                              GET_EXISTS, XPACK_DOES_NOT_EXIST, true);
     }
 
-    public void testDoCheckExistsFor400() throws IOException {
+    public void testDoCheckExistsFor400() {
         whenElectedMaster();
 
         // /_xpack returning a 400 means X-Pack does not exist
         doCheckWithStatusCode(resource, "", "_xpack", RestStatus.BAD_REQUEST,
-                              GET_EXISTS, XPACK_DOES_NOT_EXIST, CheckResponse.EXISTS);
+                              GET_EXISTS, XPACK_DOES_NOT_EXIST, true);
     }
 
-    public void testDoCheckExistsAsElectedMaster() throws IOException {
+    public void testDoCheckExistsAsElectedMaster() {
         whenElectedMaster();
 
         final String[] noWatcher = {
@@ -82,12 +81,12 @@ public class WatcherExistsHttpResourceTests extends AbstractPublishableHttpResou
         when(response.getEntity()).thenReturn(responseEntity);
 
         // returning EXISTS implies that we CANNOT use Watcher to avoid running the publish phase
-        doCheckWithStatusCode(resource, expectedParameters, endpoint, CheckResponse.EXISTS, response);
+        doCheckWithStatusCode(resource, expectedParameters, endpoint, true, response);
 
         verify(response).getEntity();
     }
 
-    public void testDoCheckDoesNotExist() throws IOException {
+    public void testDoCheckDoesNotExist() {
         whenElectedMaster();
 
         final String[] hasWatcher = {
@@ -103,12 +102,12 @@ public class WatcherExistsHttpResourceTests extends AbstractPublishableHttpResou
         when(response.getEntity()).thenReturn(responseEntity);
 
         // returning DOES_NOT_EXIST implies that we CAN use Watcher and need to run the publish phase
-        doCheckWithStatusCode(resource, expectedParameters, endpoint, CheckResponse.DOES_NOT_EXIST, response);
+        doCheckWithStatusCode(resource, expectedParameters, endpoint, false, response);
 
         verify(response).getEntity();
     }
 
-    public void testDoCheckErrorWithDataException() throws IOException {
+    public void testDoCheckErrorWithDataException() {
         whenElectedMaster();
 
         final String[] errorWatcher = {
@@ -124,39 +123,55 @@ public class WatcherExistsHttpResourceTests extends AbstractPublishableHttpResou
 
         when(response.getEntity()).thenReturn(responseEntity);
 
-        // returning DOES_NOT_EXIST implies that we CAN use Watcher and need to run the publish phase
+        // returning an error implies that we CAN use Watcher and need to run the publish phase
-        doCheckWithStatusCode(resource, endpoint, CheckResponse.ERROR, response);
+        doCheckWithStatusCode(resource, expectedParameters, endpoint, null, response);
     }
 
-    public void testDoCheckErrorWithResponseException() throws IOException {
+    public void testDoCheckErrorWithResponseException() {
         whenElectedMaster();
 
-        assertCheckWithException(resource, "", "_xpack");
+        assertCheckWithException(resource, expectedParameters, "", "_xpack");
     }
 
-    public void testDoPublishTrue() throws IOException {
+    public void testDoPublishTrue() {
-        final CheckResponse checkResponse = randomFrom(CheckResponse.EXISTS, CheckResponse.DOES_NOT_EXIST);
+        final boolean checkResponse = randomBoolean();
-        final boolean publish = checkResponse == CheckResponse.DOES_NOT_EXIST;
+        final boolean publish = checkResponse == false;
         final MockHttpResource mockWatch = new MockHttpResource(owner, randomBoolean(), checkResponse, publish);
         final MultiHttpResource watches = new MultiHttpResource(owner, Collections.singletonList(mockWatch));
         final WatcherExistsHttpResource resource = new WatcherExistsHttpResource(owner, clusterService, watches);
 
-        assertTrue(resource.doPublish(client));
+        resource.doPublish(client, listener);
+
+        verifyListener(true);
 
         assertThat(mockWatch.checked, is(1));
         assertThat(mockWatch.published, is(publish ? 1 : 0));
     }
 
-    public void testDoPublishFalse() throws IOException {
+    public void testDoPublishFalse() {
-        final CheckResponse checkResponse = randomFrom(CheckResponse.DOES_NOT_EXIST, CheckResponse.ERROR);
+        final MockHttpResource mockWatch = new MockHttpResource(owner, true, false, false);
-        final MockHttpResource mockWatch = new MockHttpResource(owner, true, checkResponse, false);
         final MultiHttpResource watches = new MultiHttpResource(owner, Collections.singletonList(mockWatch));
         final WatcherExistsHttpResource resource = new WatcherExistsHttpResource(owner, clusterService, watches);
 
-        assertFalse(resource.doPublish(client));
+        resource.doPublish(client, listener);
+
+        verifyListener(false);
 
         assertThat(mockWatch.checked, is(1));
-        assertThat(mockWatch.published, is(checkResponse == CheckResponse.DOES_NOT_EXIST ? 1 : 0));
+        assertThat(mockWatch.published, is(1));
+    }
+
+    public void testDoPublishException() {
+        final MockHttpResource mockWatch = new MockHttpResource(owner, true, false, null);
+        final MultiHttpResource watches = new MultiHttpResource(owner, Collections.singletonList(mockWatch));
+        final WatcherExistsHttpResource resource = new WatcherExistsHttpResource(owner, clusterService, watches);
+
+        resource.doPublish(client, listener);
+
+        verifyListener(null);
+
+        assertThat(mockWatch.checked, is(1));
+        assertThat(mockWatch.published, is(1));
     }
 
     public void testParameters() {