From 352d2aaf18824389446f63cc6bbe64e04e012e96 Mon Sep 17 00:00:00 2001 From: David Pilato Date: Wed, 21 Aug 2013 17:44:08 +0200 Subject: [PATCH] Plugin Manager can not download _site plugins from github Sounds like github changes a bit download url for master zip file. From `https://github.com/username/reponame/zipball/master` to `https://github.com/username/reponame/archive/master.zip`. We need to update plugin manager to reflect that change. In the meantime, we invite users having this issue to use: ```sh bin/plugin -install reponame -url https://github.com/username/reponame/archive/master.zip ``` For example: ```sh bin/plugin -install paramedic -url https://github.com/karmi/elasticsearch-paramedic/archive/master.zip ``` Closes #3551 --- src/main/java/org/elasticsearch/plugins/PluginManager.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/elasticsearch/plugins/PluginManager.java b/src/main/java/org/elasticsearch/plugins/PluginManager.java index 90537d7962f..2a5b9704232 100644 --- a/src/main/java/org/elasticsearch/plugins/PluginManager.java +++ b/src/main/java/org/elasticsearch/plugins/PluginManager.java @@ -178,7 +178,7 @@ public class PluginManager { } if (!downloaded) { // try it as a site plugin tagged - pluginUrl = new URL("https://codeload.github.com/" + userName + "/" + repoName + "/zip/v" + version); + pluginUrl = new URL("https://github.com/" + userName + "/" + repoName + "/archive/v" + version + ".zip"); System.out.println("Trying " + pluginUrl.toExternalForm() + "... (assuming site plugin)"); try { downloadHelper.download(pluginUrl, pluginFile, new HttpDownloadHelper.VerboseProgress(System.out)); @@ -192,7 +192,7 @@ public class PluginManager { } } else { // assume site plugin, download master.... - URL pluginUrl = new URL("https://codeload.github.com/" + userName + "/" + repoName + "/zip/master"); + URL pluginUrl = new URL("https://github.com/" + userName + "/" + repoName + "/archive/master.zip"); System.out.println("Trying " + pluginUrl.toExternalForm() + "... (assuming site plugin)"); try { downloadHelper.download(pluginUrl, pluginFile, new HttpDownloadHelper.VerboseProgress(System.out));