Elasticsearch dependency should be provided and not compile
Please change the Elasticsearch dependency to provided (and maybe testCompile) instead of compile and runtime. Why? If you include the plugin in embedded Elasticsearch, and you exclude anything from the Elasticsearch dependency, it is undone by this dependency also including Elasticsearch. Therefore you have to tune both, when really this plugin only needs it as provided (since it runs with Elasticsearch or in Elasticsearch but never on its own). Closes #48.
This commit is contained in:
parent
bbb064468c
commit
3616ed6ddd
2
pom.xml
2
pom.xml
|
@ -69,7 +69,7 @@
|
||||||
<groupId>org.elasticsearch</groupId>
|
<groupId>org.elasticsearch</groupId>
|
||||||
<artifactId>elasticsearch</artifactId>
|
<artifactId>elasticsearch</artifactId>
|
||||||
<version>${elasticsearch.version}</version>
|
<version>${elasticsearch.version}</version>
|
||||||
<scope>compile</scope>
|
<scope>provided</scope>
|
||||||
</dependency>
|
</dependency>
|
||||||
|
|
||||||
<dependency>
|
<dependency>
|
||||||
|
|
Loading…
Reference in New Issue