Bulk API, closes #371.

This commit is contained in:
kimchy 2010-09-15 12:22:07 +02:00
parent f6fa6ea44e
commit 3afe4da550
10 changed files with 203 additions and 6 deletions

View File

@ -106,7 +106,7 @@ public class CountRequest extends BroadcastOperationRequest {
@Override protected void beforeLocalFork() { @Override protected void beforeLocalFork() {
if (querySourceUnsafe) { if (querySourceUnsafe) {
querySource = Arrays.copyOfRange(querySource, querySourceOffset, querySourceLength); querySource = Arrays.copyOfRange(querySource, querySourceOffset, querySourceOffset + querySourceLength);
querySourceOffset = 0; querySourceOffset = 0;
querySourceUnsafe = false; querySourceUnsafe = false;
} }

View File

@ -107,7 +107,7 @@ public class DeleteByQueryRequest extends IndicesReplicationOperationRequest {
*/ */
byte[] querySource() { byte[] querySource() {
if (querySourceUnsafe || querySourceOffset > 0) { if (querySourceUnsafe || querySourceOffset > 0) {
querySource = Arrays.copyOfRange(querySource, querySourceOffset, querySourceLength); querySource = Arrays.copyOfRange(querySource, querySourceOffset, querySourceOffset + querySourceLength);
querySourceOffset = 0; querySourceOffset = 0;
querySourceUnsafe = false; querySourceUnsafe = false;
} }

View File

@ -222,7 +222,7 @@ public class IndexRequest extends ShardReplicationOperationRequest {
*/ */
public byte[] source() { public byte[] source() {
if (sourceUnsafe || sourceOffset > 0) { if (sourceUnsafe || sourceOffset > 0) {
source = Arrays.copyOfRange(source, sourceOffset, sourceLength); source = Arrays.copyOfRange(source, sourceOffset, sourceOffset + sourceLength);
sourceOffset = 0; sourceOffset = 0;
sourceUnsafe = false; sourceUnsafe = false;
} }

View File

@ -312,7 +312,7 @@ public class MoreLikeThisRequest implements ActionRequest {
void beforeLocalFork() { void beforeLocalFork() {
if (searchSourceUnsafe) { if (searchSourceUnsafe) {
searchSource = Arrays.copyOfRange(searchSource, searchSourceOffset, searchSourceLength); searchSource = Arrays.copyOfRange(searchSource, searchSourceOffset, searchSourceOffset + searchSourceLength);
searchSourceOffset = 0; searchSourceOffset = 0;
searchSourceUnsafe = false; searchSourceUnsafe = false;
} }

View File

@ -121,12 +121,12 @@ public class SearchRequest implements ActionRequest {
*/ */
public void beforeLocalFork() { public void beforeLocalFork() {
if (source != null && sourceUnsafe) { if (source != null && sourceUnsafe) {
source = Arrays.copyOfRange(source, sourceOffset, sourceLength); source = Arrays.copyOfRange(source, sourceOffset, sourceOffset + sourceLength);
sourceOffset = 0; sourceOffset = 0;
sourceUnsafe = false; sourceUnsafe = false;
} }
if (extraSource != null && extraSourceUnsafe) { if (extraSource != null && extraSourceUnsafe) {
extraSource = Arrays.copyOfRange(extraSource, extraSourceOffset, extraSourceLength); extraSource = Arrays.copyOfRange(extraSource, extraSourceOffset, extraSourceOffset + extraSourceLength);
extraSourceOffset = 0; extraSourceOffset = 0;
extraSourceUnsafe = false; extraSourceUnsafe = false;
} }

View File

@ -33,6 +33,8 @@ public interface XContent {
*/ */
XContentType type(); XContentType type();
byte streamSeparator();
/** /**
* Creates a new generator using the provided output stream. * Creates a new generator using the provided output stream.
*/ */

View File

@ -60,6 +60,10 @@ public class JsonXContent implements XContent {
return XContentType.JSON; return XContentType.JSON;
} }
@Override public byte streamSeparator() {
return '\n';
}
@Override public XContentGenerator createGenerator(OutputStream os) throws IOException { @Override public XContentGenerator createGenerator(OutputStream os) throws IOException {
return new JsonXContentGenerator(jsonFactory.createJsonGenerator(os, JsonEncoding.UTF8)); return new JsonXContentGenerator(jsonFactory.createJsonGenerator(os, JsonEncoding.UTF8));
} }

View File

@ -59,6 +59,10 @@ public class SmileXContent implements XContent {
return XContentType.SMILE; return XContentType.SMILE;
} }
@Override public byte streamSeparator() {
return (byte) 0xFF;
}
@Override public XContentGenerator createGenerator(OutputStream os) throws IOException { @Override public XContentGenerator createGenerator(OutputStream os) throws IOException {
return new SmileXContentGenerator(smileFactory.createJsonGenerator(os, JsonEncoding.UTF8)); return new SmileXContentGenerator(smileFactory.createJsonGenerator(os, JsonEncoding.UTF8));
} }

View File

@ -41,6 +41,7 @@ import org.elasticsearch.rest.action.admin.indices.optimize.RestOptimizeAction;
import org.elasticsearch.rest.action.admin.indices.refresh.RestRefreshAction; import org.elasticsearch.rest.action.admin.indices.refresh.RestRefreshAction;
import org.elasticsearch.rest.action.admin.indices.settings.RestUpdateSettingsAction; import org.elasticsearch.rest.action.admin.indices.settings.RestUpdateSettingsAction;
import org.elasticsearch.rest.action.admin.indices.status.RestIndicesStatusAction; import org.elasticsearch.rest.action.admin.indices.status.RestIndicesStatusAction;
import org.elasticsearch.rest.action.bulk.RestBulkAction;
import org.elasticsearch.rest.action.count.RestCountAction; import org.elasticsearch.rest.action.count.RestCountAction;
import org.elasticsearch.rest.action.delete.RestDeleteAction; import org.elasticsearch.rest.action.delete.RestDeleteAction;
import org.elasticsearch.rest.action.deletebyquery.RestDeleteByQueryAction; import org.elasticsearch.rest.action.deletebyquery.RestDeleteByQueryAction;
@ -95,6 +96,7 @@ public class RestActionModule extends AbstractModule {
bind(RestDeleteByQueryAction.class).asEagerSingleton(); bind(RestDeleteByQueryAction.class).asEagerSingleton();
bind(RestCountAction.class).asEagerSingleton(); bind(RestCountAction.class).asEagerSingleton();
bind(RestBulkAction.class).asEagerSingleton();
bind(RestSearchAction.class).asEagerSingleton(); bind(RestSearchAction.class).asEagerSingleton();
bind(RestSearchScrollAction.class).asEagerSingleton(); bind(RestSearchScrollAction.class).asEagerSingleton();

View File

@ -0,0 +1,185 @@
/*
* Licensed to Elastic Search and Shay Banon under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. Elastic Search licenses this
* file to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.elasticsearch.rest.action.bulk;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.bulk.BulkItemResponse;
import org.elasticsearch.action.bulk.BulkRequest;
import org.elasticsearch.action.bulk.BulkResponse;
import org.elasticsearch.action.delete.DeleteRequest;
import org.elasticsearch.action.index.IndexRequest;
import org.elasticsearch.client.Client;
import org.elasticsearch.client.Requests;
import org.elasticsearch.common.inject.Inject;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.xcontent.XContent;
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentFactory;
import org.elasticsearch.common.xcontent.XContentParser;
import org.elasticsearch.rest.*;
import java.io.IOException;
import static org.elasticsearch.rest.RestRequest.Method.*;
import static org.elasticsearch.rest.RestResponse.Status.*;
import static org.elasticsearch.rest.action.support.RestXContentBuilder.*;
/**
* <pre>
* { "index" : { "index" : "test", "type" : "type1", "id" : "1" }
* { "type1" : { "field1" : "value1" } }
* { "delete" : { "index" : "test", "type" : "type1", "id" : "2" } }
* { "create" : { "index" : "test", "type" : "type1", "id" : "1" }
* { "type1" : { "field1" : "value1" } }
* </pre>
*
* @author kimchy (shay.banon)
*/
public class RestBulkAction extends BaseRestHandler {
@Inject public RestBulkAction(Settings settings, Client client, RestController controller) {
super(settings, client);
controller.registerHandler(POST, "/_bulk", this);
controller.registerHandler(PUT, "/_bulk", this);
}
@Override public void handleRequest(final RestRequest request, final RestChannel channel) {
BulkRequest bulkRequest = Requests.bulkRequest();
int fromIndex = request.contentByteArrayOffset();
byte[] data = request.contentByteArray();
int length = request.contentLength();
try {
// first, guess the content
XContent xContent = XContentFactory.xContent(data, fromIndex, length);
byte marker = xContent.streamSeparator();
while (true) {
int nextMarker = findNextMarker(marker, fromIndex, data, length);
if (nextMarker == -1) {
break;
}
// now parse the action
XContentParser parser = xContent.createParser(data, fromIndex, nextMarker - fromIndex);
// move pointers
fromIndex = nextMarker + 1;
// Move to START_OBJECT
XContentParser.Token token = parser.nextToken();
if (token == null) {
continue;
}
assert token == XContentParser.Token.START_OBJECT;
// Move to FIELD_NAME, that's the action
token = parser.nextToken();
assert token == XContentParser.Token.FIELD_NAME;
String action = parser.currentName();
// Move to START_OBJECT
token = parser.nextToken();
assert token == XContentParser.Token.START_OBJECT;
String index = null;
String type = null;
String id = null;
String currentFieldName = null;
while ((token = parser.nextToken()) != XContentParser.Token.END_OBJECT) {
if (token == XContentParser.Token.FIELD_NAME) {
currentFieldName = parser.currentName();
} else if (token.isValue()) {
if ("index".equals(currentFieldName)) {
index = parser.text();
} else if ("type".equals(currentFieldName)) {
type = parser.text();
} else if ("id".equals(currentFieldName)) {
id = parser.text();
}
}
}
if ("delete".equals(action)) {
bulkRequest.add(new DeleteRequest(index, type, id));
} else {
nextMarker = findNextMarker(marker, fromIndex, data, length);
if (nextMarker == -1) {
break;
}
bulkRequest.add(new IndexRequest(index, type, id)
.create("create".equals(action))
.source(data, fromIndex, nextMarker - fromIndex, request.contentUnsafe()));
// move pointers
fromIndex = nextMarker + 1;
}
}
} catch (Exception e) {
try {
XContentBuilder builder = restContentBuilder(request);
channel.sendResponse(new XContentRestResponse(request, BAD_REQUEST, builder.startObject().field("error", e.getMessage()).endObject()));
} catch (IOException e1) {
logger.error("Failed to send failure response", e1);
}
return;
}
client.bulk(bulkRequest, new ActionListener<BulkResponse>() {
@Override public void onResponse(BulkResponse response) {
try {
XContentBuilder builder = restContentBuilder(request);
builder.startObject();
for (BulkItemResponse itemResponse : response) {
builder.startObject(itemResponse.opType());
builder.field("index", itemResponse.index());
builder.field("type", itemResponse.type());
builder.field("id", itemResponse.id());
if (itemResponse.failed()) {
builder.field("error", itemResponse.failure().message());
}
builder.endObject();
}
builder.endObject();
channel.sendResponse(new XContentRestResponse(request, OK, builder));
} catch (Exception e) {
onFailure(e);
}
}
@Override public void onFailure(Throwable e) {
try {
channel.sendResponse(new XContentThrowableRestResponse(request, e));
} catch (IOException e1) {
logger.error("Failed to send failure response", e1);
}
}
});
}
private int findNextMarker(byte marker, int from, byte[] data, int length) {
for (int i = from; i < length; i++) {
if (data[i] == marker) {
return i;
}
}
return -1;
}
}