Added a new line linter (#2875)

* Added linter to add new line

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Fixed new lines

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Ignore empty files

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Updated DEVELOPER GUIDE

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Renamed workflow file

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Fixed failing tests

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

.github/workflows/code-hygiene.yml

@@ -0,0 +1,14 @@
+name: Code Hygiene
+
+on: [push, pull_request]
+
+jobs:
+  linelint:
+    runs-on: ubuntu-latest
+    name: Check if all files end in newline
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Linelint
+        uses: fernandrone/linelint@0.0.4

.linelint.yml

@@ -0,0 +1,49 @@
+# 'true' will fix files
+autofix: true
+
+ignore:
+  - .git/
+  - .gradle/
+  - .idea/
+  - '*.sha1'
+  - '*.txt'
+  - '.github/CODEOWNERS'
+  - 'buildSrc/src/testKit/opensearch.build/LICENSE'
+  - 'buildSrc/src/testKit/opensearch.build/NOTICE'
+  - 'server/licenses/apache-log4j-extras-DEPENDENCIES'
+  # Empty files
+  - 'doc-tools/missing-doclet/bin/main/org/opensearch/missingdoclet/MissingDoclet.class'
+  - 'buildSrc/src/integTest/resources/org/opensearch/gradle/internal/fake_git/remote/build.gradle'
+  - 'buildSrc/src/integTest/resources/org/opensearch/gradle/internal/fake_git/remote/distribution/archives/oss-darwin-tar/build.gradle'
+  - 'buildSrc/src/integTest/resources/org/opensearch/gradle/internal/fake_git/remote/distribution/bwc/bugfix/build.gradle'
+  - 'buildSrc/src/integTest/resources/org/opensearch/gradle/internal/fake_git/remote/distribution/bwc/minor/build.gradle'
+  - 'buildSrc/src/main/resources/buildSrc.marker'
+  - 'buildSrc/src/testKit/opensearch-build-resources/settings.gradle'
+  - 'buildSrc/src/testKit/opensearch.build/settings.gradle'
+  - 'buildSrc/src/testKit/reaper/settings.gradle'
+  - 'buildSrc/src/testKit/symbolic-link-preserving-tar/settings.gradle'
+  - 'buildSrc/src/testKit/testingConventions/empty_test_task/.gitignore'
+  - 'client/rest-high-level/src/main/resources/META-INF/services/org.opensearch.plugins.spi.NamedXContentProvider'
+  - 'distribution/bwc/bugfix/build.gradle'
+  - 'distribution/bwc/maintenance/build.gradle'
+  - 'distribution/bwc/minor/build.gradle'
+  - 'distribution/bwc/staged/build.gradle'
+  - 'libs/ssl-config/src/test/resources/certs/pem-utils/empty.pem'
+  - 'qa/evil-tests/src/test/resources/org/opensearch/common/logging/does_not_exist/nothing_to_see_here'
+  - 'qa/os/centos-6/build.gradle'
+  - 'qa/os/debian-8/build.gradle'
+  - 'qa/os/oel-6/build.gradle'
+  - 'qa/os/oel-7/build.gradle'
+  - 'qa/os/sles-12/build.gradle'
+  # Test requires no new line for these files
+  - 'server/src/test/resources/org/opensearch/action/bulk/simple-bulk11.json'
+  - 'server/src/test/resources/org/opensearch/action/search/simple-msearch5.json'
+
+rules:
+  # checks if file ends in a newline character
+  end-of-file:
+    # set to true to enable this rule
+    enable: true
+
+    # if true also checks if file ends in a single newline character
+    single-new-line: true

DEVELOPER_GUIDE.md

@@ -48,6 +48,7 @@
     - [Distributed Framework](#distributed-framework)
   - [Submitting Changes](#submitting-changes)
   - [Backports](#backports)
+  - [LineLint](#linelint)
 
 # Developer Guide
 
@@ -472,3 +473,18 @@ See [CONTRIBUTING](CONTRIBUTING.md).
 ## Backports
 
 The Github workflow in [`backport.yml`](.github/workflows/backport.yml) creates backport PRs automatically when the original PR with an appropriate label `backport <backport-branch-name>` is merged to main with the backport workflow run successfully on the PR. For example, if a PR on main needs to be backported to `1.x` branch, add a label `backport 1.x` to the PR and make sure the backport workflow runs on the PR along with other checks. Once this PR is merged to main, the workflow will create a backport PR to the `1.x` branch.
+
+## LineLint
+A linter in [`code-hygiene.yml`](.github/workflows/code-hygiene.yml) that validates simple newline and whitespace rules in all sorts of files. It can:
+- Recursively check a directory tree for files that do not end in a newline
+- Automatically fix these files by adding a newline or trimming extra newlines.
+
+Rules are defined in `.linelint.yml`.
+
+Executing the binary will automatically search the local directory tree for linting errors.
+
+    linelint .
+
+Pass a list of files or directories to limit your search.
+
+    linelint README.md LICENSE

buildSrc/src/testKit/testingConventions/build.gradle

@@ -88,6 +88,3 @@ project(':valid_setup_with_base') {
     }
   }
 }
-
-
-

dev-tools/prepare_release_update_documentation.py

@@ -136,4 +136,3 @@ if __name__ == "__main__":
     print('WARNING: no documentation references updates for release %s' % (release_version))
 
   print('*** Done.')
-

dev-tools/signoff-check.sh

@@ -28,4 +28,3 @@ done
 
 # Return non-zero error code if any commits were missing signoff
 exit $missingSignoff
-

distribution/docker/src/test/resources/rest-api-spec/test/10_info.yml

@@ -7,4 +7,3 @@
   - is_true:    version
   - is_true:    version.number
   - match: { version.build_type: "docker" }
-

distribution/docker/src/test/resources/rest-api-spec/test/11_nodes.yml

@@ -123,4 +123,3 @@
   - match:
       $body: |
         /^(\S{5,}\n)+$/
-

distribution/src/bin/opensearch-env-from-file

@@ -47,4 +47,3 @@ for VAR_NAME_FILE in OPENSEARCH_PASSWORD_FILE KEYSTORE_PASSWORD_FILE ; do
     unset "$VAR_NAME_FILE"
   fi
 done
-

distribution/src/bin/opensearch-env.bat

@@ -74,4 +74,3 @@ if defined JAVA_OPTS (
 
 rem check the Java version
 %JAVA% -cp "%OPENSEARCH_CLASSPATH%" "org.opensearch.tools.java_version_checker.JavaVersionChecker" || exit /b 1
-

doc-tools/build.gradle

@@ -8,4 +8,3 @@ version '1.0.0-SNAPSHOT'
 repositories {
     mavenCentral()
 }
-

libs/dissect/build.gradle

@@ -40,4 +40,3 @@ dependencies {
 tasks.named('forbiddenApisMain').configure {
   replaceSignatureFiles 'jdk-signatures'
 }
-

libs/geo/build.gradle

@@ -42,4 +42,3 @@ tasks.named('forbiddenApisMain').configure {
   // TODO: Need to decide how we want to handle for forbidden signatures with the changes to core
   replaceSignatureFiles 'jdk-signatures'
 }
-

libs/grok/src/main/resources/patterns/exim

@@ -10,4 +10,3 @@ EXIM_PROTOCOL (P=%{NOTSPACE:protocol})
 EXIM_MSG_SIZE (S=%{NUMBER:exim_msg_size})
 EXIM_HEADER_ID (id=%{NOTSPACE:exim_header_id})
 EXIM_SUBJECT (T=%{QS:exim_subject})
-

libs/grok/src/main/resources/patterns/junos

@@ -6,4 +6,3 @@ RT_FLOW1 %{RT_FLOW_EVENT:event}: %{GREEDYDATA:close-reason}: %{IP:src-ip}/%{INT:
 RT_FLOW2 %{RT_FLOW_EVENT:event}: session created %{IP:src-ip}/%{INT:src-port}->%{IP:dst-ip}/%{INT:dst-port} %{DATA:service} %{IP:nat-src-ip}/%{INT:nat-src-port}->%{IP:nat-dst-ip}/%{INT:nat-dst-port} %{DATA:src-nat-rule-name} %{DATA:dst-nat-rule-name} %{INT:protocol-id} %{DATA:policy-name} %{DATA:from-zone} %{DATA:to-zone} %{INT:session-id} .*
 
 RT_FLOW3 %{RT_FLOW_EVENT:event}: session denied %{IP:src-ip}/%{INT:src-port}->%{IP:dst-ip}/%{INT:dst-port} %{DATA:service} %{INT:protocol-id}\(\d\) %{DATA:policy-name} %{DATA:from-zone} %{DATA:to-zone} .*
-

libs/grok/src/main/resources/patterns/postgresql

@@ -1,3 +1,2 @@
 # Default postgresql pg_log format pattern
 POSTGRESQL %{DATESTAMP:timestamp} %{TZ} %{DATA:user_id} %{GREEDYDATA:connection_id} %{POSINT:pid}
-

libs/ssl-config/build.gradle

@@ -61,4 +61,3 @@ tasks.test {
         jvmArgs += ["--add-opens", "java.base/java.security.cert=ALL-UNNAMED"]
     }
 }
-

modules/analysis-common/src/yamlRestTest/resources/rest-api-spec/test/analysis-common/60_analysis_scripting.yml

@@ -68,4 +68,3 @@
     - match: { tokens.1.token: "f" }
     - match: { tokens.2.token: "g" }
     - match: { tokens.3.token: "h" }
-

modules/analysis-common/src/yamlRestTest/resources/rest-api-spec/test/cluster.stats/10_analysis_stats.yml

@@ -119,4 +119,3 @@
   - match: { indices.analysis.built_in_analyzers.2.name: spanish }
   - match: { indices.analysis.built_in_analyzers.2.count: 2 }
   - match: { indices.analysis.built_in_analyzers.2.index_count: 2 }
-

modules/analysis-common/src/yamlRestTest/resources/rest-api-spec/test/indices.analyze/10_synonyms.yml

@@ -76,4 +76,3 @@
   - match:  { tokens.5.token: dude }
   - match:  { tokens.5.position: 4 }
   - match:  { tokens.5.positionLength: null }
-

modules/analysis-common/src/yamlRestTest/resources/rest-api-spec/test/search.query/60_synonym_graph.yml

@@ -229,4 +229,3 @@ setup:
                 query: bar baz
                 analyzer: lower_graph_syns
   - match: { hits.total: 1 }
-

modules/analysis-common/src/yamlRestTest/resources/rest-api-spec/test/search.query/70_intervals.yml

@@ -56,4 +56,3 @@ setup:
                         use_field: text_en
                   max_gaps: 1
   - match: { hits.total.value: 1 }
-

modules/ingest-common/src/yamlRestTest/resources/rest-api-spec/test/ingest/220_drop_processor.yml

@@ -91,4 +91,3 @@ teardown:
     get:
       index: test
       id: 3
-

modules/ingest-user-agent/build.gradle

@@ -43,4 +43,3 @@ restResources {
 testClusters.all {
   extraConfigFile 'ingest-user-agent/test-regexes.yml', file('src/test/test-regexes.yml')
 }
-

modules/lang-expression/build.gradle

@@ -52,4 +52,3 @@ tasks.named("dependencyLicenses").configure {
   mapping from: /lucene-.*/, to: 'lucene'
   mapping from: /asm-.*/, to: 'asm'
 }
-

modules/lang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/100_terms_agg.yml

@@ -139,4 +139,3 @@ setup:
   - is_false: aggregations.placeholder.buckets.0.str_terms.buckets.1.key_as_string
   - match: { aggregations.placeholder.buckets.0.str_terms.buckets.1.doc_count: 1 }
   - match: { aggregations.placeholder.buckets.0.the_bucket_script.value: 2.0 }
-

modules/opensearch-dashboards/build.gradle

@@ -41,4 +41,3 @@ dependencies {
 testClusters.all {
   module ':modules:reindex'
 }
-

modules/repository-url/build.gradle

@@ -75,4 +75,3 @@ testClusters.all {
     "http://snapshot.test*,http://${urlFixture.addressAndPort}"
   }, PropertyNormalization.IGNORE_VALUE
 }
-

modules/systemd/build.gradle

@@ -32,4 +32,3 @@ opensearchplugin {
   description 'Integrates OpenSearch with systemd'
   classname 'org.opensearch.systemd.SystemdPlugin'
 }
-

plugins/analysis-kuromoji/build.gradle

@@ -46,4 +46,3 @@ restResources {
 tasks.named("dependencyLicenses").configure {
   mapping from: /lucene-.*/, to: 'lucene'
 }
-

plugins/analysis-phonetic/src/yamlRestTest/resources/rest-api-spec/test/analysis_phonetic/10_metaphone.yml

@@ -31,4 +31,3 @@
     - match:  { tokens.1.token: joe  }
     - match:  { tokens.2.token: BLKS  }
     - match:  { tokens.3.token: bloggs  }
-

plugins/analysis-phonetic/src/yamlRestTest/resources/rest-api-spec/test/analysis_phonetic/20_double_metaphone.yml

@@ -28,4 +28,3 @@
 
     - length: { tokens: 1 }
     - match:  { tokens.0.token: SPRKLF }
-

plugins/analysis-phonetic/src/yamlRestTest/resources/rest-api-spec/test/analysis_phonetic/30_beider_morse.yml

@@ -30,4 +30,3 @@
 
     - length: { tokens: 1 }
     - match:  { tokens.0.token: Svarts }
-

plugins/analysis-phonetic/src/yamlRestTest/resources/rest-api-spec/test/analysis_phonetic/50_daitch_mokotoff.yml

@@ -27,4 +27,3 @@
 
     - length: { tokens: 1 }
     - match:  { tokens.0.token: "645740" }
-

plugins/analysis-smartcn/build.gradle

@@ -47,4 +47,3 @@ restResources {
 tasks.named("dependencyLicenses").configure {
   mapping from: /lucene-.*/, to: 'lucene'
 }
-

plugins/examples/build.gradle

@@ -36,4 +36,3 @@ configure(project('painless-whitelist')) {
     }
   }
 }
-

plugins/examples/custom-settings/build.gradle

@@ -42,4 +42,3 @@ testClusters.all {
   // Adds a setting in the OpenSearch keystore before running the integration tests
   keystore 'custom.secured', 'password'
 }
-

plugins/examples/rest-handler/build.gradle

@@ -56,4 +56,3 @@ javaRestTest {
   dependsOn exampleFixture
   nonInputProperties.systemProperty 'external.address', "${-> exampleFixture.addressAndPort}"
 }
-

plugins/examples/script-expert-scoring/build.gradle

@@ -39,4 +39,3 @@ opensearchplugin {
 }
 
 test.enabled = false
-

plugins/ingest-attachment/src/test/resources/org/opensearch/ingest/attachment/test/sample-files/asciidoc.asciidoc

@@ -2,4 +2,3 @@
 = AsciiDoc test
 
 Here is a test of the asciidoc format.
-

plugins/ingest-attachment/src/yamlRestTest/resources/rest-api-spec/test/ingest_attachment/10_basic.yml

@@ -12,4 +12,3 @@
 
     - contains:  { 'nodes.$master.plugins': { name: ingest-attachment }  }
     - contains:  { 'nodes.$master.ingest.processors': { type: attachment } }
-

plugins/mapper-annotated-text/src/yamlRestTest/resources/rest-api-spec/test/mapper_annotatedtext/10_basic.yml

@@ -142,4 +142,3 @@
         request_cache: false
         body: { "query" : {"match_phrase" : { "my_field" : {"query": "~MARK0", "analyzer": "whitespace"} } }, "highlight" : { "type" : "annotated",  "fields" : { "my_field" : {} } } }
   - match: {_shards.failed: 0}
-

plugins/repository-hdfs/src/test/resources/rest-api-spec/test/hdfs_repository/30_snapshot.yml

@@ -45,4 +45,3 @@
   - do:
      snapshot.delete_repository:
        repository: test_snapshot_repository
-

plugins/repository-hdfs/src/test/resources/rest-api-spec/test/secure_hdfs_repository/30_snapshot.yml

@@ -47,4 +47,3 @@
   - do:
      snapshot.delete_repository:
        repository: test_snapshot_repository
-

plugins/transport-nio/build.gradle

@@ -183,4 +183,3 @@ thirdPartyAudit {
     'io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator'
   )
 }
-

qa/die-with-dignity/build.gradle

@@ -35,4 +35,3 @@ testClusters.javaRestTest {
 }
 
 test.enabled = false
-

qa/multi-cluster-search/src/test/resources/rest-api-spec/test/multi_cluster/70_skip_shards.yml

@@ -220,4 +220,3 @@
     # When all shards are skipped current logic returns 1 to produce a valid search result
   - match: { _shards.skipped : 1}
   - match: { _shards.failed: 0 }
-

qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/10_basic.yml

@@ -204,4 +204,3 @@
       tasks.get:
         wait_for_completion: true
         task_id: $task
-

qa/rolling-upgrade/src/test/resources/rest-api-spec/test/old_cluster/20_date_range.yml

@@ -111,5 +111,3 @@
                 gte: "2019-02-01T00:00+01:00"
                 lte: "2019-02-01T00:00+01:00"
   - match: { hits.total: 1 }
-
-

qa/rolling-upgrade/src/test/resources/rest-api-spec/test/upgraded_cluster/10_basic.yml

@@ -133,5 +133,3 @@
         wait_for_completion: true
         task_id: $task_id
   - match: { task.headers.X-Opaque-Id: "Reindexing Again" }
-
-

qa/rolling-upgrade/src/test/resources/rest-api-spec/test/upgraded_cluster/20_date_range.yml

@@ -38,4 +38,3 @@
               time_frame:
                 gte: "2019-02-01T00:00+01:00"
                 lte: "2019-02-01T00:00+01:00"
-

qa/smoke-test-ingest-disabled/src/test/resources/rest-api-spec/test/ingest_mustache/10_ingest_disabled.yml

@@ -112,4 +112,3 @@
               _id:    test_id2
               pipeline: my_pipeline_1
           - f1: v2
-

qa/smoke-test-ingest-with-all-dependencies/src/test/resources/rest-api-spec/test/ingest/50_script_processor_using_painless.yml

@@ -102,4 +102,3 @@
   - match: { error.processor_type: "script" }
   - match: { error.type: "script_exception" }
   - match: { error.reason: "compile error" }
-

qa/smoke-test-ingest-with-all-dependencies/src/test/resources/rest-api-spec/test/ingest/60_pipeline_timestamp_date_mapping.yml

@@ -34,4 +34,3 @@
         id: 1
         pipeline: "my_timely_pipeline"
         body: {}
-

qa/smoke-test-plugins/src/test/java/org/opensearch/smoketest/SmokeTestPluginsClientYamlTestSuiteIT.java

@@ -49,4 +49,3 @@ public class SmokeTestPluginsClientYamlTestSuiteIT extends OpenSearchClientYamlS
         return OpenSearchClientYamlSuiteTestCase.createParameters();
     }
 }
-

release-notes/opensearch.release-notes-1.0.0-rc1.md

@@ -411,5 +411,3 @@
 
 
     Signed-off-by: Abbas Hussain <abbas_10690@yahoo.com>
-
-

release-notes/opensearch.release-notes-1.1.0.md

@@ -386,5 +386,3 @@
 
 
     Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
-
-

release-notes/opensearch.release-notes-1.2.0.md

@@ -458,4 +458,3 @@
 
 
     Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
-

release-notes/opensearch.release-notes-1.2.4.md

@@ -72,5 +72,3 @@
     
     
     Signed-off-by: dblock <dblock@amazon.com>
-
-

release-notes/opensearch.release-notes-1.3.0.md

@@ -1295,5 +1295,3 @@
     [Nick Knize](mailto:nknize@apache.org) - Thu, 4 Nov 2021 14:46:57 -0500
 
     Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
-
-

rest-api-spec/src/main/resources/rest-api-spec/test/bulk/10_basic.yml

@@ -223,4 +223,3 @@
   - match: { items.0.index.status: 400 }
   - match: { items.0.index.error.type: illegal_argument_exception }
   - match: { items.0.index.error.reason: "no write index is defined for alias [test_index]. The write index may be explicitly disabled using is_write_index=false or the alias points to multiple indices without one being designated as a write index" }
-

rest-api-spec/src/main/resources/rest-api-spec/test/bulk/20_list_of_strings.yml

@@ -14,4 +14,3 @@
         index: test_index
 
   - match: {count: 2}
-

rest-api-spec/src/main/resources/rest-api-spec/test/bulk/30_big_string.yml

@@ -14,4 +14,3 @@
         index: test_index
 
   - match: {count: 2}
-

rest-api-spec/src/main/resources/rest-api-spec/test/bulk/40_source.yml

@@ -68,4 +68,3 @@
 
   - match: { items.0.update.get._source.foo: garply }
   - is_false: items.0.update.get._source.bar
-

rest-api-spec/src/main/resources/rest-api-spec/test/cat.nodes/10_basic.yml

@@ -131,4 +131,3 @@
   - match:
       $body: |
                /^(\S{5,}\n)+$/
-

rest-api-spec/src/main/resources/rest-api-spec/test/cluster.pending_tasks/10_basic.yml

@@ -11,4 +11,3 @@
         local: true
 
   - is_true: tasks
-

rest-api-spec/src/main/resources/rest-api-spec/test/cluster.remote_info/10_info.yml

@@ -3,4 +3,3 @@
   - do:
       cluster.remote_info: {}
   - is_true: ''
-

rest-api-spec/src/main/resources/rest-api-spec/test/cluster.voting_config_exclusions/10_basic.yml

@@ -104,4 +104,3 @@ teardown:
       cluster.post_voting_config_exclusions:
         node_ids: nodeId
         node_names: nodeName
-

rest-api-spec/src/main/resources/rest-api-spec/test/create/40_routing.yml

@@ -39,4 +39,3 @@
       get:
           index:   test_1
           id:      1
-

rest-api-spec/src/main/resources/rest-api-spec/test/delete/30_routing.yml

@@ -30,4 +30,3 @@
           index:   test_1
           id:      1
           routing: 5
-

rest-api-spec/src/main/resources/rest-api-spec/test/get/15_default_values.yml

@@ -14,4 +14,3 @@
   - match: { _index:   test_1 }
   - match: { _id:      '1'    }
   - match: { _source:  { foo: "bar" } }
-

rest-api-spec/src/main/resources/rest-api-spec/test/get/20_stored_fields.yml

@@ -48,5 +48,3 @@
   - match: { fields.foo:  [bar] }
   - match: { fields.count:  [1] }
   - match: { _source.foo: bar }
-
-

rest-api-spec/src/main/resources/rest-api-spec/test/get/40_routing.yml

@@ -41,4 +41,3 @@
       get:
           index:   test_1
           id:      1
-

rest-api-spec/src/main/resources/rest-api-spec/test/get/90_versions.yml

@@ -80,4 +80,3 @@
           id:     1
           version: 1
           version_type: external_gte
-

rest-api-spec/src/main/resources/rest-api-spec/test/index/40_routing.yml

@@ -40,4 +40,3 @@
       get:
           index:   test_1
           id:      1
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.delete_alias/all_path_options.yml

@@ -221,4 +221,3 @@ setup:
       catch: param
       indices.delete_alias:
         index: "test_index1"
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.exists_template/10_basic.yml

@@ -41,4 +41,3 @@ setup:
         local: true
 
   - is_false: ''
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.forcemerge/10_basic.yml

@@ -27,5 +27,3 @@
         index: test
         max_num_segments: 10
         only_expunge_deletes: true
-
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_field_mapping/40_missing_index.yml

@@ -6,5 +6,3 @@
       indices.get_field_mapping:
         index: test_index
         fields: field
-
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_field_mapping/50_field_wildcards.yml

@@ -127,4 +127,3 @@ setup:
   - match:  {test_index_2.mappings.t1.full_name: t1 }
   - match:  {test_index_2.mappings.t2.full_name: t2 }
   - length: {test_index_2.mappings: 2}
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_index_template/20_get_missing.yml

@@ -17,4 +17,3 @@ setup:
       catch:  missing
       indices.get_index_template:
         name: test
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_mapping/30_missing_index.yml

@@ -29,4 +29,3 @@
         index: test_index
         ignore_unavailable: true
         allow_no_indices: false
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_settings/20_aliases.yml

@@ -23,4 +23,3 @@
   - match: { test-index.settings.index.number_of_replicas: "3" }
   - match: { test-index.settings.index.number_of_shards: "2" }
   - match: { test-index.settings.index.refresh_interval: "-1" }
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.get_template/20_get_missing.yml

@@ -10,4 +10,3 @@ setup:
       catch:  missing
       indices.get_template:
         name: test
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.open/20_multiple_indices.yml

@@ -101,4 +101,3 @@ setup:
       search:
         rest_total_hits_as_int: true
         index: test_index3
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.put_alias/all_path_options.yml

@@ -113,4 +113,3 @@ setup:
   - do:
       catch: param
       indices.put_alias: {}
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.put_mapping/10_basic.yml

@@ -143,4 +143,3 @@
 
   - is_false: test_index.mappings.properties.foo.meta.bar
   - match: { test_index.mappings.properties.foo.meta.baz: "quux" }
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.put_mapping/all_path_options.yml

@@ -159,4 +159,3 @@ setup:
       indices.get_mapping: {}
 
   - match: {test_index1.mappings.properties.text.type:     text}
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.put_settings/all_path_options.yml

@@ -110,4 +110,3 @@ setup:
   - match: {test_index1.settings.index.refresh_interval:     1s}
   - match: {test_index2.settings.index.refresh_interval:     1s}
   - match: {foo.settings.index.refresh_interval:     1s}
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.refresh/10_basic.yml

@@ -55,4 +55,3 @@ setup:
   - match: { _shards.total: 0 }
   - match: { _shards.successful: 0 }
   - match: { _shards.failed: 0 }
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.rollover/10_basic.yml

@@ -148,4 +148,3 @@
         body:
           conditions:
             max_docs: 1
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.rollover/20_max_doc_condition.yml

@@ -52,4 +52,3 @@
 
   - match: { conditions: { "[max_docs: 2]": true } }
   - match: { rolled_over: true }
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.update_aliases/20_routing.yml

@@ -132,4 +132,3 @@ setup:
         index: test_index
 
   - match: {test_index.aliases.test_alias: {'index_routing': '5', 'search_routing': '5'}}
-

rest-api-spec/src/main/resources/rest-api-spec/test/indices.upgrade/10_basic.yml

@@ -69,4 +69,3 @@
       indices.upgrade:
         index: ["test_index", "does_not_exist"]
         ignore_unavailable: false
-

rest-api-spec/src/main/resources/rest-api-spec/test/info/20_lucene_version.yml

@@ -2,6 +2,3 @@
 "Lucene Version":
     - do:         {info: {}}
     - is_true:    version.lucene_version
-
-
-

rest-api-spec/src/main/resources/rest-api-spec/test/nodes.stats/11_indices_metrics.yml

@@ -224,4 +224,3 @@
   - is_false:  nodes.$node_id.indices.translog
   - is_false:  nodes.$node_id.indices.recovery
   - is_true:   nodes.$node_id.indices.segments.file_sizes
-

rest-api-spec/src/main/resources/rest-api-spec/test/ping/10_ping.yml

@@ -2,4 +2,3 @@
 "Ping":
     - do:      { ping: {}}
     - is_true: ''
-

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/240_max_buckets.yml

@@ -118,4 +118,3 @@ setup:
                 2:
                   terms:
                     field: date
-

rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/250_moving_fn.yml

@@ -74,4 +74,3 @@
                 buckets_path: "the_avg"
                 window: -1
                 script: "MovingFunctions.windowMax(values)"
-