add some more comments about internal api usage

This commit is contained in:
Robert Muir 2015-12-16 18:56:02 -05:00
parent 49f37a526c
commit 42138007db
9 changed files with 16 additions and 20 deletions

View File

@ -26,9 +26,6 @@ import org.gradle.api.tasks.TaskAction
import org.apache.tools.ant.BuildLogger
import org.apache.tools.ant.Project
import org.slf4j.Logger
import org.slf4j.LoggerFactory
/**
* Basic static checking to keep tabs on third party JARs
*/
@ -119,7 +116,6 @@ public class ThirdPartyAuditTask extends DefaultTask {
for (File jar : jars) {
names.add(jar.getName())
}
Logger logger = LoggerFactory.getLogger(getClass());
logger.error("[thirdPartyAudit] Scanning: " + names)
// warn that you won't see any forbidden apis warnings

View File

@ -115,7 +115,7 @@ forbiddenPatterns {
thirdPartyAudit.lenient = true
// uses internal sun ssl classes!
thirdPartyAudit.excludes = [
// sun.security.x509 (X509CertInfo, X509CertImpl, X500Name)
// uses internal java api: sun.security.x509 (X509CertInfo, X509CertImpl, X500Name)
'org.jboss.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator',
]

View File

@ -39,7 +39,7 @@ integTest {
// classes are missing, e.g. jline.console.completer.Completer
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// sun.misc.Unsafe
// uses internal java api: sun.misc.Unsafe
'groovy.json.internal.FastStringUtils',
'groovy.json.internal.FastStringUtils$StringImplementation$1',
'groovy.json.internal.FastStringUtils$StringImplementation$2',

View File

@ -71,9 +71,9 @@ thirdPartyAudit.lenient = true
// WE ARE JAR HELLING WITH THE JDK AND THAT IS WHY THIS HAPPENS
// TODO: fix this!!!!!!!!!!!
thirdPartyAudit.excludes = [
// com.sun.xml.fastinfoset.stax.StAXDocumentParser
// uses internal java api: com.sun.xml.fastinfoset.stax.StAXDocumentParser
'com.sun.xml.bind.v2.runtime.unmarshaller.FastInfosetConnector',
'com.sun.xml.bind.v2.runtime.unmarshaller.FastInfosetConnector$CharSequenceImpl',
// com.sun.xml.fastinfoset.stax.StAXDocumentSerializer
// uses internal java api: com.sun.xml.fastinfoset.stax.StAXDocumentSerializer
'com.sun.xml.bind.v2.runtime.output.FastInfosetStreamWriterOutput',
]

View File

@ -52,8 +52,8 @@ test {
// classes are missing, e.g. org.apache.avalon.framework.logger.Logger
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl
// com.sun.org.apache.xml.internal.dtm.ref.DTMManagerDefault
// com.sun.org.apache.xpath.internal.XPathContext
// uses internal java api: com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl
// uses internal java api: com.sun.org.apache.xml.internal.dtm.ref.DTMManagerDefault
// uses internal java api: com.sun.org.apache.xpath.internal.XPathContext
'com.amazonaws.util.XpathUtils',
]

View File

@ -39,17 +39,17 @@ integTest {
// classes are missing, e.g. org.tukaani.xz.FilterOptions
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// sun.security.x509 (X509CertInfo, X509CertImpl, X500Name)
// uses internal java api: sun.security.x509 (X509CertInfo, X509CertImpl, X500Name)
'org.python.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator',
// sun.misc.Cleaner
// uses internal java api: sun.misc.Cleaner
'org.python.netty.util.internal.Cleaner0',
// sun.misc.Signal
// uses internal java api: sun.misc.Signal
'jnr.posix.JavaPOSIX',
'jnr.posix.JavaPOSIX$SunMiscSignalHandler',
// sun.misc.Unsafe
// uses internal java api: sun.misc.Unsafe
'com.kenai.jffi.MemoryIO$UnsafeImpl',
'com.kenai.jffi.MemoryIO$UnsafeImpl32',
'com.kenai.jffi.MemoryIO$UnsafeImpl64',

View File

@ -73,6 +73,6 @@ forbiddenPatterns {
// classes are missing, e.g. org.openxmlformats.schemas.drawingml.x2006.chart.CTExtensionList
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// com.sun.syndication (SyndFeedInput, SyndFeed, SyndEntry, SyndContent)
// uses internal java api: com.sun.syndication (SyndFeedInput, SyndFeed, SyndEntry, SyndContent)
'org.apache.tika.parser.feed.FeedParser',
]

View File

@ -53,8 +53,8 @@ test {
// classes are missing, e.g. org.apache.log.Logger
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl
// com.sun.org.apache.xml.internal.dtm.ref.DTMManagerDefault
// com.sun.org.apache.xpath.internal.XPathContext
// uses internal java api: com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl
// uses internal java api: com.sun.org.apache.xml.internal.dtm.ref.DTMManagerDefault
// uses internal java api: com.sun.org.apache.xpath.internal.XPathContext
'com.amazonaws.util.XpathUtils',
]

View File

@ -38,7 +38,7 @@ test {
// classes are missing, com.ibm.icu.lang.UCharacter
thirdPartyAudit.lenient = true
thirdPartyAudit.excludes = [
// sun.misc.Unsafe
// uses internal java api: sun.misc.Unsafe
'com.google.common.cache.Striped64',
'com.google.common.cache.Striped64$1',
'com.google.common.cache.Striped64$Cell',