honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make sure we close the parser even if it failed to parse a search request

This commit is contained in:
kimchy 2011-04-30 00:09:36 +03:00
parent fcdd2ba11c
commit 4558816bcf
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/elasticsearch/src/main/java/org/elasticsearch/search/SearchService.java
View File

@ -446,8 +446,9 @@ public class SearchService extends AbstractLifecycleComponent<SearchService> {
if (source == null || length == 0) {
return;
}
XContentParser parser = null;
try {
XContentParser parser = XContentFactory.xContent(source, offset, length).createParser(source, offset, length);
parser = XContentFactory.xContent(source, offset, length).createParser(source, offset, length);
XContentParser.Token token;
while ((token = parser.nextToken()) != XContentParser.Token.END_OBJECT) {
if (token == XContentParser.Token.FIELD_NAME) {
@ -471,6 +472,10 @@ public class SearchService extends AbstractLifecycleComponent<SearchService> {
// ignore
}
throw new SearchParseException(context, "Failed to parse source [" + sSource + "]", e);
} finally {
if (parser != null) {
parser.close();
}
}
}