honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-17 02:14:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

no need for volatile on writer, its always accessed under a lock

Browse Source
This commit is contained in:
kimchy 2010-07-20 13:58:01 +03:00
parent 3c8cf68a17
commit 45c821316b
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
modules/elasticsearch/src/main/java/org/elasticsearch/index/engine/robin/RobinEngine.java
View File

@ -87,7 +87,8 @@ public class RobinEngine extends AbstractIndexShardComponent implements Engine,
private final SimilarityService similarityService;
private volatile IndexWriter indexWriter;
// no need for volatile, its always used under a lock
private IndexWriter indexWriter;
private volatile AcquirableResource<ReaderSearcherHolder> nrtResource;
@ -121,14 +122,19 @@ public class RobinEngine extends AbstractIndexShardComponent implements Engine,
@Override public void indexingBuffer(ByteSizeValue indexingBufferSize) {
// LUCENE MONITOR - If this restriction is removed from Lucene, remove it from here
if (indexingBufferSize.mbFrac() > 2048.0) {
this.indexingBufferSize = new ByteSizeValue(2048, ByteSizeUnit.MB);
} else {
this.indexingBufferSize = indexingBufferSize;
}
IndexWriter indexWriter = this.indexWriter;
if (indexWriter != null) {
indexWriter.setRAMBufferSizeMB(this.indexingBufferSize.mbFrac());
rwl.readLock().lock();
try {
if (indexingBufferSize.mbFrac() > 2048.0) {
this.indexingBufferSize = new ByteSizeValue(2048, ByteSizeUnit.MB);
} else {
this.indexingBufferSize = indexingBufferSize;
}
IndexWriter indexWriter = this.indexWriter;
if (indexWriter != null) {
indexWriter.setRAMBufferSizeMB(this.indexingBufferSize.mbFrac());
}
} finally {
rwl.readLock().unlock();
}
}