honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Query Cache: Invalidate the query cache when mappings change, closes #532.

This commit is contained in:
kimchy 2010-11-23 15:26:19 +02:00
parent 9479ac636e
commit 4a3e5b6348
1 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
modules/elasticsearch/src/main/java/org/elasticsearch/cache/NodeCache.java vendored
View File

@ -21,33 +21,36 @@ package org.elasticsearch.cache;
import org.elasticsearch.cache.memory.ByteBufferCache; import org.elasticsearch.cache.memory.ByteBufferCache;
import org.elasticsearch.cache.query.parser.QueryParserCache; import org.elasticsearch.cache.query.parser.QueryParserCache;
import org.elasticsearch.cache.query.parser.none.NoneQueryParserCache; import org.elasticsearch.cluster.ClusterChangedEvent;
import org.elasticsearch.cluster.ClusterService;
import org.elasticsearch.cluster.ClusterStateListener;
import org.elasticsearch.common.component.AbstractComponent; import org.elasticsearch.common.component.AbstractComponent;
import org.elasticsearch.common.inject.Inject; import org.elasticsearch.common.inject.Inject;
import org.elasticsearch.common.settings.ImmutableSettings;
import org.elasticsearch.common.settings.Settings; import org.elasticsearch.common.settings.Settings;
/** /**
* @author kimchy (shay.banon) * @author kimchy (shay.banon)
*/ */
public class NodeCache extends AbstractComponent { public class NodeCache extends AbstractComponent implements ClusterStateListener {
private final ClusterService clusterService;
private final ByteBufferCache byteBufferCache; private final ByteBufferCache byteBufferCache;
private final QueryParserCache queryParserCache; private final QueryParserCache queryParserCache;
public NodeCache() { @Inject public NodeCache(Settings settings, ByteBufferCache byteBufferCache, QueryParserCache queryParserCache, ClusterService clusterService) {
this(ImmutableSettings.Builder.EMPTY_SETTINGS, new ByteBufferCache(ImmutableSettings.Builder.EMPTY_SETTINGS), new NoneQueryParserCache());
}
@Inject public NodeCache(Settings settings, ByteBufferCache byteBufferCache, QueryParserCache queryParserCache) {
super(settings); super(settings);
this.clusterService = clusterService;
this.byteBufferCache = byteBufferCache; this.byteBufferCache = byteBufferCache;
this.queryParserCache = queryParserCache; this.queryParserCache = queryParserCache;
clusterService.add(this);
} }
public void close() { public void close() {
clusterService.remove(this);
byteBufferCache.close(); byteBufferCache.close();
queryParserCache.clear();
} }
public ByteBufferCache byteBuffer() { public ByteBufferCache byteBuffer() {
@ -57,4 +60,12 @@ public class NodeCache extends AbstractComponent {
public QueryParserCache queryParser() { public QueryParserCache queryParser() {
return queryParserCache; return queryParserCache;
} }
// listen on cluster change events to invalidate the query parser cache
@Override public void clusterChanged(ClusterChangedEvent event) {
// TODO we can do better by detecting just mappings changes
if (event.metaDataChanged()) {
queryParserCache.clear();
}
}
} }