honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-25 22:36:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ML] Improve comment on why task is marked completed on kill process

Browse Source 
Original commit: elastic/x-pack-elasticsearch@5c16cf8e26
This commit is contained in:
Dimitris Athanasiou 2018-04-10 13:31:39 +01:00
parent 7e4e1dabcf
commit 4c7bd71bdf
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManager.java
View File

@ -157,10 +157,13 @@ public class AutodetectProcessManager extends AbstractComponent {
.kill();
} else {
// If the process is missing but the task exists this is most likely
// because the job went into the failed state then the node restarted
// causing the task to be recreated but the failed process wasn't.
// We still need to remove the task from the TaskManager (which
// is what the kill would do)
// due to 2 reasons. The first is because the job went into the failed
// state then the node restarted causing the task to be recreated
// but the failed process wasn't. The second is that the job went into
// the failed state and the user tries to remove it force-deleting it.
// Force-delete issues a kill but the process will not be present
// as it is cleaned up already. In both cases, we still need to remove
// the task from the TaskManager (which is what the kill would do)
logger.trace("[{}] Marking job task as completed", jobTask.getJobId());
jobTask.markAsCompleted();
}