honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix testFirstListElementsToCommaDelimitedStringReportsFirstElementsIfLong (#44785) 

This test can fail (super-rarely) if it generates a list of length 11
containing a duplicate, because the `.distinct()` reduces the list length to 10
and then it is not abbreviated any more. This change generalises the test to
cover lists of any random length.
This commit is contained in:
David Turner 2019-07-24 16:09:51 +01:00
parent d8be9244f9
commit 4cfd2fc6b2
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
server/src/test/java/org/elasticsearch/cluster/routing/allocation/AllocationServiceTests.java
View File

@ -49,8 +49,8 @@ public class AllocationServiceTests extends ESTestCase {
}
public void testFirstListElementsToCommaDelimitedStringReportsFirstElementsIfLong() {
List<String> strings = IntStream.range(0, between(11, 100)).mapToObj(i -> randomAlphaOfLength(10))
.distinct().collect(Collectors.toList());
List<String> strings = IntStream.range(0, between(0, 100))
.mapToObj(i -> randomAlphaOfLength(between(6, 10))).distinct().collect(Collectors.toList());
final String abbreviated = AllocationService.firstListElementsToCommaDelimitedString(strings, Function.identity(), false);
for (int i = 0; i < strings.size(); i++) {
if (i < 10) {
@ -59,8 +59,13 @@ public class AllocationServiceTests extends ESTestCase {
assertThat(abbreviated, not(containsString(strings.get(i))));
}
}
assertThat(abbreviated, containsString("..."));
assertThat(abbreviated, containsString("[" + strings.size() + " items in total]"));
if (strings.size() > 10) {
assertThat(abbreviated, containsString("..."));
assertThat(abbreviated, containsString("[" + strings.size() + " items in total]"));
} else {
assertThat(abbreviated, not(containsString("...")));
}
}
public void testFirstListElementsToCommaDelimitedStringUsesFormatterNotToString() {