Build: Replace provided configuration with compileOnly (elastic/x-pack-elasticsearch#3868)

This is the xpack side of elastic/elasticsearch#28564

Original commit: elastic/x-pack-elasticsearch@60033824a4

plugin/core/build.gradle

@@ -23,7 +23,7 @@ dependencyLicenses {
 }
 
 dependencies {
-    provided "org.elasticsearch:elasticsearch:${version}"
+    compileOnly "org.elasticsearch:elasticsearch:${version}"
     compile "org.apache.httpcomponents:httpclient:${versions.httpclient}"
     compile "org.apache.httpcomponents:httpcore:${versions.httpcore}"
     compile "org.apache.httpcomponents:httpcore-nio:${versions.httpcore}"

plugin/deprecation/build.gradle

@@ -10,7 +10,7 @@ esplugin {
 archivesBaseName = 'x-pack-deprecation'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
 }
 
 run {

plugin/graph/build.gradle

@@ -10,7 +10,7 @@ esplugin {
 archivesBaseName = 'x-pack-graph'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
 }
 

plugin/logstash/build.gradle

@@ -10,7 +10,7 @@ esplugin {
 archivesBaseName = 'x-pack-logstash'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
 
 }

plugin/ml/build.gradle

@@ -40,7 +40,7 @@ compileJava.options.compilerArgs << "-Xlint:-deprecation,-rawtypes,-serial,-try,
 compileTestJava.options.compilerArgs << "-Xlint:-deprecation,-rawtypes,-serial,-try,-unchecked"
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
     // This should not be here
     testCompile project(path: xpackModule('security'), configuration: 'testArtifacts')

plugin/monitoring/build.gradle

@@ -13,7 +13,7 @@ esplugin {
 archivesBaseName = 'x-pack-monitoring'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
 
     // monitoring deps

plugin/security/build.gradle

@@ -12,9 +12,9 @@ esplugin {
 archivesBaseName = 'x-pack-security'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     compileOnly project(path: ':modules:transport-netty4', configuration: 'runtime')
-    provided project(path: ':plugins:transport-nio', configuration: 'runtime')
+    compileOnly project(path: ':plugins:transport-nio', configuration: 'runtime')
 
     testCompile project(path: xpackModule('monitoring'))
     testCompile project(path: xpackModule('sql:sql-proto'))

plugin/sql/build.gradle

@@ -20,9 +20,8 @@ archivesBaseName = 'x-pack-sql'
 integTest.enabled = false
 
 dependencies {
-    provided "org.elasticsearch:elasticsearch:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
-    compile project(xpackModule('sql:sql-proto'))
+    compile project('sql-proto')
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
     compile 'org.antlr:antlr4-runtime:4.5.3'
     testCompile "org.elasticsearch.test:framework:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')

plugin/upgrade/build.gradle

@@ -14,7 +14,7 @@ esplugin {
 archivesBaseName = 'x-pack-upgrade'
 
 dependencies {
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
 }
 

plugin/watcher/build.gradle

@@ -23,11 +23,11 @@ dependencyLicenses {
 }
 
 dependencies {
-    provided "org.elasticsearch:elasticsearch:${version}"
+    compileOnly "org.elasticsearch:elasticsearch:${version}"
 
-    provided "org.elasticsearch.plugin:x-pack-core:${version}"
+    compileOnly "org.elasticsearch.plugin:x-pack-core:${version}"
-    provided project(path: ':modules:transport-netty4', configuration: 'runtime')
+    compileOnly project(path: ':modules:transport-netty4', configuration: 'runtime')
-    provided project(path: ':plugins:transport-nio', configuration: 'runtime')
+    compileOnly project(path: ':plugins:transport-nio', configuration: 'runtime')
 
     testCompile project(path: xpackModule('core'), configuration: 'testArtifacts')
 
@@ -38,8 +38,8 @@ dependencies {
     // HACK: java 9 removed javax.activation from the default modules, so instead of trying to add modules, which would have
     // to be conditionalized for java 8/9, we pull in the classes directly
     compile 'javax.activation:activation:1.1.1'
-    provided "org.apache.httpcomponents:httpclient:${versions.httpclient}"
+    compileOnly "org.apache.httpcomponents:httpclient:${versions.httpclient}"
-    provided "org.apache.httpcomponents:httpcore:${versions.httpcore}"
+    compileOnly "org.apache.httpcomponents:httpcore:${versions.httpcore}"
 
     testCompile 'org.subethamail:subethasmtp:3.1.7'
     // needed for subethasmtp, has @GuardedBy annotation

qa/security-example-spi-extension/build.gradle

@@ -8,7 +8,7 @@ esplugin {
 }
 
 dependencies {
-  provided project(path: xpackModule('core'), configuration: 'runtime')
+  compileOnly project(path: xpackModule('core'), configuration: 'runtime')
   testCompile project(path: xpackProject('transport-client').path, configuration: 'runtime')
 }