From 51d2e986c5724b1e58a679985513891981954ac5 Mon Sep 17 00:00:00 2001 From: Yannick Welsch Date: Fri, 23 Nov 2018 17:11:06 +0100 Subject: [PATCH] Remove BWC conditions after backport of #35731 This PR was backported to 6.x, so the extra BWC conditions are not needed anymore --- .../org/elasticsearch/repositories/RepositoriesService.java | 3 +-- .../repositories/VerifyNodeRepositoryAction.java | 6 +----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/server/src/main/java/org/elasticsearch/repositories/RepositoriesService.java b/server/src/main/java/org/elasticsearch/repositories/RepositoriesService.java index 980df387ef5..295b64c554f 100644 --- a/server/src/main/java/org/elasticsearch/repositories/RepositoriesService.java +++ b/server/src/main/java/org/elasticsearch/repositories/RepositoriesService.java @@ -214,14 +214,13 @@ public class RepositoriesService implements ClusterStateApplier { public void verifyRepository(final String repositoryName, final ActionListener listener) { final Repository repository = repository(repositoryName); - final boolean readOnly = repository.isReadOnly(); try { threadPool.executor(ThreadPool.Names.SNAPSHOT).execute(() -> { try { final String verificationToken = repository.startVerification(); if (verificationToken != null) { try { - verifyAction.verify(repositoryName, readOnly, verificationToken, new ActionListener() { + verifyAction.verify(repositoryName, verificationToken, new ActionListener() { @Override public void onResponse(VerifyResponse verifyResponse) { threadPool.executor(ThreadPool.Names.SNAPSHOT).execute(() -> { diff --git a/server/src/main/java/org/elasticsearch/repositories/VerifyNodeRepositoryAction.java b/server/src/main/java/org/elasticsearch/repositories/VerifyNodeRepositoryAction.java index 3f65bd0ca6f..b0e98f3fa39 100644 --- a/server/src/main/java/org/elasticsearch/repositories/VerifyNodeRepositoryAction.java +++ b/server/src/main/java/org/elasticsearch/repositories/VerifyNodeRepositoryAction.java @@ -24,7 +24,6 @@ import com.carrotsearch.hppc.cursors.ObjectCursor; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.message.ParameterizedMessage; -import org.elasticsearch.Version; import org.elasticsearch.action.ActionListener; import org.elasticsearch.cluster.node.DiscoveryNode; import org.elasticsearch.cluster.node.DiscoveryNodes; @@ -67,7 +66,7 @@ public class VerifyNodeRepositoryAction { transportService.registerRequestHandler(ACTION_NAME, VerifyNodeRepositoryRequest::new, ThreadPool.Names.SNAPSHOT, new VerifyNodeRepositoryRequestHandler()); } - public void verify(String repository, boolean readOnly, String verificationToken, final ActionListener listener) { + public void verify(String repository, String verificationToken, final ActionListener listener) { final DiscoveryNodes discoNodes = clusterService.state().nodes(); final DiscoveryNode localNode = discoNodes.getLocalNode(); @@ -75,9 +74,6 @@ public class VerifyNodeRepositoryAction { final List nodes = new ArrayList<>(); for (ObjectCursor cursor : masterAndDataNodes) { DiscoveryNode node = cursor.value; - if (readOnly && node.getVersion().before(Version.V_7_0_0)) { - continue; - } nodes.add(node); } final CopyOnWriteArrayList errors = new CopyOnWriteArrayList<>();