diff --git a/server/src/main/java/org/elasticsearch/index/engine/Engine.java b/server/src/main/java/org/elasticsearch/index/engine/Engine.java index de393881c89..4c9e966e39f 100644 --- a/server/src/main/java/org/elasticsearch/index/engine/Engine.java +++ b/server/src/main/java/org/elasticsearch/index/engine/Engine.java @@ -400,7 +400,7 @@ public abstract class Engine implements Closeable { */ public abstract DeleteResult delete(Delete delete) throws IOException; - public abstract NoOpResult noOp(NoOp noOp); + public abstract NoOpResult noOp(NoOp noOp) throws IOException; /** * Base class for index and delete operation results diff --git a/server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java b/server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java index 42d258bfed4..c60cb1a23fd 100644 --- a/server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java +++ b/server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java @@ -1452,13 +1452,19 @@ public class InternalEngine extends Engine { } @Override - public NoOpResult noOp(final NoOp noOp) { - NoOpResult noOpResult; + public NoOpResult noOp(final NoOp noOp) throws IOException { + final NoOpResult noOpResult; try (ReleasableLock ignored = readLock.acquire()) { + ensureOpen(); markSeqNoAsSeen(noOp.seqNo()); noOpResult = innerNoOp(noOp); } catch (final Exception e) { - noOpResult = new NoOpResult(getPrimaryTerm(), noOp.seqNo(), e); + try { + maybeFailEngine("noop", e); + } catch (Exception inner) { + e.addSuppressed(inner); + } + throw e; } return noOpResult; } diff --git a/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java b/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java index bb92b419ae2..12308488406 100644 --- a/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java +++ b/server/src/main/java/org/elasticsearch/index/shard/IndexShard.java @@ -807,7 +807,7 @@ public class IndexShard extends AbstractIndexShardComponent implements IndicesCl return noOp(engine, noOp); } - private Engine.NoOpResult noOp(Engine engine, Engine.NoOp noOp) { + private Engine.NoOpResult noOp(Engine engine, Engine.NoOp noOp) throws IOException { active.set(true); if (logger.isTraceEnabled()) { logger.trace("noop (seq# [{}])", noOp.seqNo()); diff --git a/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java b/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java index 8d0865a6525..a48216ecaa7 100644 --- a/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java +++ b/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java @@ -3232,7 +3232,7 @@ public class InternalEngineTests extends EngineTestCase { final ParsedDocument doc3 = testParsedDocument("3", null, testDocumentWithTextField(), B_1, null); AtomicReference throwingIndexWriter = new AtomicReference<>(); - try (Engine engine = createEngine(defaultSettings, store, createTempDir(), NoMergePolicy.INSTANCE, + try (InternalEngine engine = createEngine(defaultSettings, store, createTempDir(), NoMergePolicy.INSTANCE, (directory, iwc) -> { throwingIndexWriter.set(new ThrowingIndexWriter(directory, iwc)); return throwingIndexWriter.get(); @@ -3297,16 +3297,13 @@ public class InternalEngineTests extends EngineTestCase { engine.close(); } // now the engine is closed check we respond correctly - try { - if (randomBoolean()) { - engine.index(indexForDoc(doc1)); - } else { - engine.delete(new Engine.Delete("test", "", newUid(doc1), primaryTerm.get())); - } - fail("engine should be closed"); - } catch (Exception e) { - assertThat(e, instanceOf(AlreadyClosedException.class)); - } + expectThrows(AlreadyClosedException.class, () -> engine.index(indexForDoc(doc1))); + expectThrows(AlreadyClosedException.class, + () -> engine.delete(new Engine.Delete("test", "", newUid(doc1), primaryTerm.get()))); + expectThrows(AlreadyClosedException.class, () -> engine.noOp( + new Engine.NoOp(engine.getLocalCheckpointTracker().generateSeqNo(), + engine.config().getPrimaryTermSupplier().getAsLong(), + randomFrom(Engine.Operation.Origin.values()), randomNonNegativeLong(), "test"))); } } }