From 57b1d245e8e9e766cb708088dd78fbc691557dfc Mon Sep 17 00:00:00 2001
From: Jim Ferenczi <jim.ferenczi@elastic.co>
Date: Fri, 1 Feb 2019 11:41:17 +0100
Subject: [PATCH] Remove AtomiFieldData#getLegacyFieldValues (#38087)

This function is unused now that we format the docvalue fields with the default
formatter on the field (#30831)
---
 .../index/fielddata/AtomicFieldData.java      |  7 ----
 .../fielddata/plain/AtomicLongFieldData.java  | 33 -------------------
 2 files changed, 40 deletions(-)

diff --git a/server/src/main/java/org/elasticsearch/index/fielddata/AtomicFieldData.java b/server/src/main/java/org/elasticsearch/index/fielddata/AtomicFieldData.java
index c4f310073c4..20c9c3c70c1 100644
--- a/server/src/main/java/org/elasticsearch/index/fielddata/AtomicFieldData.java
+++ b/server/src/main/java/org/elasticsearch/index/fielddata/AtomicFieldData.java
@@ -32,13 +32,6 @@ public interface AtomicFieldData extends Accountable, Releasable {
      */
     ScriptDocValues<?> getScriptValues();
 
-    /**
-     * Returns field values for use by returned hits.
-     */
-    default ScriptDocValues<?> getLegacyFieldValues() {
-        return getScriptValues();
-    }
-
     /**
      * Return a String representation of the values.
      */
diff --git a/server/src/main/java/org/elasticsearch/index/fielddata/plain/AtomicLongFieldData.java b/server/src/main/java/org/elasticsearch/index/fielddata/plain/AtomicLongFieldData.java
index 66b25c21c80..9e0f3ab0736 100644
--- a/server/src/main/java/org/elasticsearch/index/fielddata/plain/AtomicLongFieldData.java
+++ b/server/src/main/java/org/elasticsearch/index/fielddata/plain/AtomicLongFieldData.java
@@ -25,11 +25,6 @@ import org.elasticsearch.index.fielddata.IndexNumericFieldData.NumericType;
 import org.elasticsearch.index.fielddata.ScriptDocValues;
 import org.elasticsearch.index.fielddata.SortedBinaryDocValues;
 import org.elasticsearch.index.fielddata.SortedNumericDoubleValues;
-import org.elasticsearch.script.JodaCompatibleZonedDateTime;
-import org.joda.time.DateTime;
-import org.joda.time.DateTimeZone;
-
-import java.io.IOException;
 
 /**
  * Specialization of {@link AtomicNumericFieldData} for integers.
@@ -52,34 +47,6 @@ abstract class AtomicLongFieldData implements AtomicNumericFieldData {
         return ramBytesUsed;
     }
 
-    @Override
-    public final ScriptDocValues<?> getLegacyFieldValues() {
-        switch (numericType) {
-            case DATE:
-                final ScriptDocValues.Dates realDV = new ScriptDocValues.Dates(getLongValues());
-                return new ScriptDocValues<DateTime>() {
-
-                    @Override
-                    public int size() {
-                        return realDV.size();
-                    }
-
-                    @Override
-                    public DateTime get(int index) {
-                        JodaCompatibleZonedDateTime dt = realDV.get(index);
-                        return new DateTime(dt.toInstant().toEpochMilli(), DateTimeZone.UTC);
-                    }
-
-                    @Override
-                    public void setNextDocId(int docId) throws IOException {
-                        realDV.setNextDocId(docId);
-                    }
-                };
-            default:
-                return getScriptValues();
-        }
-    }
-
     @Override
     public final ScriptDocValues<?> getScriptValues() {
         switch (numericType) {