honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove assertion from checkpoint tracker invariants 

This assertion is wrong because the global checkpoint on a promoted
primary can be lagging the replicas until it catches up after through
resyncs, ongoing indexing operations and removing the old primary from
the in-sync set.
This commit is contained in:
Jason Tedor 2017-09-19 17:51:07 -04:00
parent 5090260119
commit 581a873124
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/org/elasticsearch/index/seqno/GlobalCheckpointTracker.java
View File

@ -278,13 +278,6 @@ public class GlobalCheckpointTracker extends AbstractIndexShardComponent {
+ "for primary mode allocation ID [" + shardAllocationId + "] " + "for primary mode allocation ID [" + shardAllocationId + "] "
+ "more than in-sync local checkpoints [" + checkpoints + "]"; + "more than in-sync local checkpoints [" + checkpoints + "]";
// when in primary mode, the local knowledge of the global checkpoints on shard copies is bounded by the global checkpoint
assert !primaryMode
|| getGlobalCheckpoint() >= inSyncCheckpointStates(checkpoints, CheckpointState::getGlobalCheckpoint, LongStream::max)
: "global checkpoint [" + getGlobalCheckpoint() + "] "
+ "for primary mode allocation ID [" + shardAllocationId + "] "
+ "less than in-sync global checkpoints [" + checkpoints + "]";
// we have a routing table iff we have a replication group // we have a routing table iff we have a replication group
assert (routingTable == null) == (replicationGroup == null) : assert (routingTable == null) == (replicationGroup == null) :
"routing table is " + routingTable + " but replication group is " + replicationGroup; "routing table is " + routingTable + " but replication group is " + replicationGroup;