Des.config=/path/to/config/file doesn't replace $ES_HOME/elasticsearch.conf, just appends to it, closes #588.

This commit is contained in:
kimchy 2011-01-03 12:53:50 +02:00
parent ccdbbef276
commit 5e029865a8

View File

@ -46,29 +46,34 @@ public class InternalSettingsPerparer {
Environment environment = new Environment(settingsBuilder.build());
if (loadConfigSettings) {
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.yml"));
} catch (FailedToResolveConfigException e) {
// ignore
} catch (NoClassDefFoundError e) {
// ignore, no yaml
}
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.json"));
} catch (FailedToResolveConfigException e) {
// ignore
}
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.properties"));
} catch (FailedToResolveConfigException e) {
// ignore
}
boolean explicitSettingsProvided = false;
if (System.getProperty("es.config") != null) {
explicitSettingsProvided = true;
settingsBuilder.loadFromUrl(environment.resolveConfig(System.getProperty("es.config")));
}
if (System.getProperty("elasticsearch.config") != null) {
explicitSettingsProvided = true;
settingsBuilder.loadFromUrl(environment.resolveConfig(System.getProperty("elasticsearch.config")));
}
if (!explicitSettingsProvided) {
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.yml"));
} catch (FailedToResolveConfigException e) {
// ignore
} catch (NoClassDefFoundError e) {
// ignore, no yaml
}
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.json"));
} catch (FailedToResolveConfigException e) {
// ignore
}
try {
settingsBuilder.loadFromUrl(environment.resolveConfig("elasticsearch.properties"));
} catch (FailedToResolveConfigException e) {
// ignore
}
}
}
settingsBuilder.put(pSettings)