honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove filter from QL's field_caps requests (#63840) (#63845) 

(cherry picked from commit f009e6341d0fc0471f212d5a41c91e7aab77e006)
This commit is contained in:
Andrei Stefan 2020-10-17 01:36:26 +03:00 committed by GitHub
parent 3e5e54b884
commit 5f3c79d64b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 19 additions and 100 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
x-pack/plugin/eql/src/main/java/org/elasticsearch/xpack/eql/session/EqlSession.java
View File

@ -100,7 +100,7 @@ public class EqlSession {
listener.onFailure(new TaskCancelledException("cancelled"));
return;
}
indexResolver.resolveAsMergedMapping(indexWildcard, null, configuration.indicesOptions(), configuration.filter(),
indexResolver.resolveAsMergedMapping(indexWildcard, null, configuration.indicesOptions(),
map(listener, r -> preAnalyzer.preAnalyze(parsed, r))
);
}

20
x-pack/plugin/ql/src/main/java/org/elasticsearch/xpack/ql/index/IndexResolver.java
View File

@ -25,7 +25,6 @@ import org.elasticsearch.cluster.metadata.AliasMetadata;
import org.elasticsearch.common.Strings;
import org.elasticsearch.common.collect.ImmutableOpenMap;
import org.elasticsearch.index.IndexNotFoundException;
import org.elasticsearch.index.query.QueryBuilder;
import org.elasticsearch.xpack.ql.QlIllegalArgumentException;
import org.elasticsearch.xpack.ql.type.ConstantKeywordEsField;
import org.elasticsearch.xpack.ql.type.DataType;
@ -280,9 +279,9 @@ public class IndexResolver {
/**
* Resolves a pattern to one (potentially compound meaning that spawns multiple indices) mapping.
*/
public void resolveAsMergedMapping(String indexWildcard, String javaRegex, IndicesOptions indicesOptions, QueryBuilder filter,
public void resolveAsMergedMapping(String indexWildcard, String javaRegex, IndicesOptions indicesOptions,
ActionListener<IndexResolution> listener) {
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, indicesOptions, filter);
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, indicesOptions);
client.fieldCaps(fieldRequest,
ActionListener.wrap(
response -> listener.onResponse(mergedMappings(typeRegistry, indexWildcard, response.getIndices(), response.get())),
@ -292,9 +291,9 @@ public class IndexResolver {
/**
* Resolves a pattern to one (potentially compound meaning that spawns multiple indices) mapping.
*/
public void resolveAsMergedMapping(String indexWildcard, String javaRegex, boolean includeFrozen, QueryBuilder filter,
public void resolveAsMergedMapping(String indexWildcard, String javaRegex, boolean includeFrozen,
ActionListener<IndexResolution> listener) {
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, includeFrozen, filter);
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, includeFrozen);
client.fieldCaps(fieldRequest,
ActionListener.wrap(
response -> listener.onResponse(mergedMappings(typeRegistry, indexWildcard, response.getIndices(), response.get())),
@ -470,28 +469,27 @@ public class IndexResolver {
return new EsField(fieldName, esType, props, isAggregateable, isAlias);
}
private static FieldCapabilitiesRequest createFieldCapsRequest(String index, IndicesOptions indicesOptions, QueryBuilder filter) {
private static FieldCapabilitiesRequest createFieldCapsRequest(String index, IndicesOptions indicesOptions) {
return new FieldCapabilitiesRequest()
.indices(Strings.commaDelimitedListToStringArray(index))
.fields("*")
.includeUnmapped(true)
.indexFilter(filter)
//lenient because we throw our own errors looking at the response e.g. if something was not resolved
//also because this way security doesn't throw authorization exceptions but rather honors ignore_unavailable
.indicesOptions(indicesOptions);
}
private static FieldCapabilitiesRequest createFieldCapsRequest(String index, boolean includeFrozen, QueryBuilder filter) {
private static FieldCapabilitiesRequest createFieldCapsRequest(String index, boolean includeFrozen) {
IndicesOptions indicesOptions = includeFrozen ? FIELD_CAPS_FROZEN_INDICES_OPTIONS : FIELD_CAPS_INDICES_OPTIONS;
return createFieldCapsRequest(index, indicesOptions, filter);
return createFieldCapsRequest(index, indicesOptions);
}
/**
* Resolves a pattern to multiple, separate indices. Doesn't perform validation.
*/
public void resolveAsSeparateMappings(String indexWildcard, String javaRegex, boolean includeFrozen, QueryBuilder filter,
public void resolveAsSeparateMappings(String indexWildcard, String javaRegex, boolean includeFrozen,
ActionListener<List<EsIndex>> listener) {
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, includeFrozen, filter);
FieldCapabilitiesRequest fieldRequest = createFieldCapsRequest(indexWildcard, includeFrozen);
client.fieldCaps(fieldRequest, wrap(response -> {
client.admin().indices().getAliases(createGetAliasesRequest(response, includeFrozen), wrap(aliases ->
listener.onResponse(separateMappings(typeRegistry, javaRegex, response.getIndices(), response.get(), aliases.getAliases())),

81
x-pack/plugin/sql/qa/server/src/main/java/org/elasticsearch/xpack/sql/qa/rest/RestSqlTestCase.java
View File

@ -6,6 +6,7 @@
package org.elasticsearch.xpack.sql.qa.rest;
import com.fasterxml.jackson.core.io.JsonStringEncoder;
import org.apache.http.HttpEntity;
import org.apache.http.entity.ContentType;
import org.apache.http.entity.StringEntity;
@ -697,86 +698,6 @@ public abstract class RestSqlTestCase extends BaseRestSqlTestCase implements Err
);
}
/**
* Test for filtering the field_caps response with a filter.
* Because there is no actual SELECT involved (thus, the REST request filter not actually being applied on an actual _search), we can
* test if the filtering is correctly applied at field_caps request level.
*/
public void testSysColumnsCommandWithFilter() throws IOException {
String mode = randomMode();
// create three indices with same @timestamp date field and with differently named one more field
indexWithIndexName("test2018", "{\"@timestamp\":\"2018-06-01\",\"field2018\":\"foo\"}");
indexWithIndexName("test2019", "{\"@timestamp\":\"2019-06-01\",\"field2019\":\"foo\"}");
indexWithIndexName("test2020", "{\"@timestamp\":\"2020-06-01\",\"field2020\":\"foo\"}");
// filter the results so that only test2020's columns are displayed
Map<String, Object> actual = runSql(
new StringEntity(
query("SYS COLUMNS").mode(mode).filter("{\"range\": {\"@timestamp\": {\"gte\": \"2020\"}}}").toString(),
ContentType.APPLICATION_JSON
),
StringUtils.EMPTY,
mode
);
@SuppressWarnings("unchecked")
List<List<String>> rows = (List<List<String>>) actual.get("rows");
assertEquals(3, rows.size());
List<String> currentRow = rows.get(0);
assertEquals("test2020", currentRow.get(2));
assertEquals("@timestamp", currentRow.get(3));
currentRow = rows.get(1);
assertEquals("test2020", currentRow.get(2));
assertEquals("field2020", currentRow.get(3));
currentRow = rows.get(2);
assertEquals("test2020", currentRow.get(2));
assertEquals("field2020.keyword", currentRow.get(3));
}
/**
* Similar test with {@link #testSysColumnsCommandWithFilter()} but using "SHOW COLUMNS" command which, compared to "SYS COLUMNS"
* goes through a different calls path in IndexResolver
*/
@SuppressWarnings("unchecked")
public void testShowColumnsCommandWithFilter() throws IOException {
String mode = randomMode();
// create three indices with same @timestamp date field and with differently named one more field
indexWithIndexName("test2018", "{\"@timestamp\":\"2018-06-01\",\"field2018\":\"foo\"}");
indexWithIndexName("test2019", "{\"@timestamp\":\"2019-06-01\",\"field2019\":\"foo\"}");
indexWithIndexName("test2020", "{\"@timestamp\":\"2020-06-01\",\"field2020\":\"foo\"}");
// filter the results so that only test2020's columns are displayed
Map<String, Object> actual = runSql(
new StringEntity(
query("SHOW COLUMNS FROM test2020").mode(mode).filter("{\"range\": {\"@timestamp\": {\"gte\": \"2020\"}}}").toString(),
ContentType.APPLICATION_JSON
),
StringUtils.EMPTY,
mode
);
List<List<String>> rows = (List<List<String>>) actual.get("rows");
assertEquals(3, rows.size());
List<String> currentRow = rows.get(0);
assertEquals("@timestamp", currentRow.get(0));
currentRow = rows.get(1);
assertEquals("field2020", currentRow.get(0));
currentRow = rows.get(2);
assertEquals("field2020.keyword", currentRow.get(0));
// the second test is from an index that is filtered out by the range filter, so the result list should be empty
actual = runSql(
new StringEntity(
query("SHOW COLUMNS FROM test2019").mode(mode).filter("{\"range\": {\"@timestamp\": {\"gte\": \"2020\"}}}").toString(),
ContentType.APPLICATION_JSON
),
StringUtils.EMPTY,
mode
);
rows = (List<List<String>>) actual.get("rows");
assertTrue(rows.isEmpty());
}
public void testBasicTranslateQueryWithFilter() throws IOException {
index("{\"test\":\"foo\"}", "{\"test\":\"bar\"}");

2
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/plan/logical/command/ShowColumns.java
View File

@ -66,7 +66,7 @@ public class ShowColumns extends Command {
String regex = pattern != null ? pattern.asJavaRegex() : null;
boolean withFrozen = includeFrozen || session.configuration().includeFrozen();
session.indexResolver().resolveAsMergedMapping(idx, regex, withFrozen, session.configuration().filter(), ActionListener.wrap(
session.indexResolver().resolveAsMergedMapping(idx, regex, withFrozen, ActionListener.wrap(
indexResult -> {
List<List<?>> rows = emptyList();
if (indexResult.isValid()) {

4
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/plan/logical/command/sys/SysColumns.java
View File

@ -128,7 +128,7 @@ public class SysColumns extends Command {
// special case for '%' (translated to *)
if ("*".equals(idx)) {
session.indexResolver().resolveAsSeparateMappings(idx, regex, includeFrozen, session.configuration().filter(),
session.indexResolver().resolveAsSeparateMappings(idx, regex, includeFrozen,
ActionListener.wrap(esIndices -> {
List<List<?>> rows = new ArrayList<>();
for (EsIndex esIndex : esIndices) {
@ -139,7 +139,7 @@ public class SysColumns extends Command {
}
// otherwise use a merged mapping
else {
session.indexResolver().resolveAsMergedMapping(idx, regex, includeFrozen, session.configuration().filter(),
session.indexResolver().resolveAsMergedMapping(idx, regex, includeFrozen,
ActionListener.wrap(r -> {
List<List<?>> rows = new ArrayList<>();
// populate the data only when a target is found

2
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/session/SqlSession.java
View File

@ -140,7 +140,7 @@ public class SqlSession implements Session {
}
boolean includeFrozen = configuration.includeFrozen() || tableInfo.isFrozen();
indexResolver.resolveAsMergedMapping(table.index(), null, includeFrozen, configuration.filter(),
indexResolver.resolveAsMergedMapping(table.index(), null, includeFrozen,
wrap(indexResult -> listener.onResponse(action.apply(indexResult)), listener::onFailure));
} else {
try {

8
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/plan/logical/command/sys/SysColumnsTests.java
View File

@ -559,13 +559,13 @@ public class SysColumnsTests extends ESTestCase {
IndexResolver resolver = mock(IndexResolver.class);
when(resolver.clusterName()).thenReturn(CLUSTER_NAME);
doAnswer(invocation -> {
((ActionListener<IndexResolution>) invocation.getArguments()[4]).onResponse(IndexResolution.valid(test));
((ActionListener<IndexResolution>) invocation.getArguments()[3]).onResponse(IndexResolution.valid(test));
return Void.TYPE;
}).when(resolver).resolveAsMergedMapping(any(), any(), anyBoolean(), any(), any());
}).when(resolver).resolveAsMergedMapping(any(), any(), anyBoolean(), any());
doAnswer(invocation -> {
((ActionListener<List<EsIndex>>) invocation.getArguments()[4]).onResponse(singletonList(test));
((ActionListener<List<EsIndex>>) invocation.getArguments()[3]).onResponse(singletonList(test));
return Void.TYPE;
}).when(resolver).resolveAsSeparateMappings(any(), any(), anyBoolean(), any(), any());
}).when(resolver).resolveAsSeparateMappings(any(), any(), anyBoolean(), any());
SqlSession session = new SqlSession(config, null, null, resolver, null, null, null, null, null);
return new Tuple<>(cmd, session);