Fail build for lines longer than 140 characters
140 characters is our official line length from CONTRIBUTING.md. It is a little longer than fits well in github but you can use a userstyle to fix that. It is perfect for Eclipse and unified diffs but too wide for side by side diffs. Regardless, its the official limit we've had for years. We just haven't enforced it automatically and we haven't enforced it using github because line limits are hard to notice there. This only hits about 2/3 of the java files - those that didn't have failures already. If they did have a failure it suppresses them. We should pick files off that list as time goes on. For posterity I generated the suppressions by running checkstyle with ignoreFailures = true, piping the output to a file, and then running it through this: perl -ne 'print if s{.*\[ant:checkstyle\] /.+/elasticsearch/}{ <suppress files="} && s{\.java.+}{\.java" checks="LineLength" />}' | uniq
This commit is contained in:
parent
d87625c9f0
commit
63aedb8720
|
@ -11,11 +11,12 @@
|
|||
</module>
|
||||
|
||||
<module name="TreeWalker">
|
||||
<!-- ~3500 violations
|
||||
<!-- Its our official line length! See checkstyle_suppressions.xml for the files that don't pass this. For now we
|
||||
suppress the check there but enforce it everywhere else. This prevents the list from getting longer even if it is
|
||||
unfair. -->
|
||||
<module name="LineLength">
|
||||
<property name="max" value="140"/>
|
||||
</module>
|
||||
-->
|
||||
|
||||
<module name="AvoidStarImport" />
|
||||
<!-- Doesn't pass but we could make it pass pretty quick.
|
||||
|
|
File diff suppressed because it is too large
Load Diff
Loading…
Reference in New Issue