honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix test failure in RangeQueryBuilderTests.testToQuery (#58449) 

Very rarely this test can fail if we draw a random TimeZone id that we cannot
parse with the legacy joda DateMathParser and get an IllegalArgumentException.
In addition to a "SystemV/*" time zone we also need an index "versionCreated"
before V_7_0_0 and no "format" setting in the query builder. Given how unlikely
this combination is, we should simply dissallow those time zone ids when
generating the random query builder for RangeQueryBuilderTests.

Closes #58431
This commit is contained in:
Christoph Büscher 2020-06-23 17:44:18 +02:00 committed by GitHub
parent 0d6bfd0ac3
commit 642b05a511
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/src/test/java/org/elasticsearch/index/query/RangeQueryBuilderTests.java
View File

@ -83,7 +83,13 @@ public class RangeQueryBuilderTests extends AbstractQueryTestCase<RangeQueryBuil
// otherwise we could trigger exception.
if (createShardContext().getMapperService().fieldType(DATE_FIELD_NAME) != null) {
if (randomBoolean()) {
query.timeZone(randomZone().getId());
// drawing a truly random zoneId here can rarely fail under the following conditons:
// - index versionCreated before V_7_0_0
// - no "forced" date parser through a format parameter
// - one of the SystemV* time zones that Jodas DateTimeZone parser doesn't know about
// thats why we exlude it here (see #58431)
String zoneId = randomValueOtherThanMany(zi -> zi.getId().startsWith("SystemV"), () -> randomZone()).getId();
query.timeZone(zoneId);
}
if (randomBoolean()) {
String format = "strict_date_optional_time";