honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

When stopping alert manager wait for ongoing operations to complete. 

Original commit: elastic/x-pack-elasticsearch@646e534628
This commit is contained in:
Martijn van Groningen 2014-11-27 13:36:09 +01:00
parent 27f83bb621
commit 6da23d412a
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/org/elasticsearch/alerts/AlertManager.java
View File

@ -212,6 +212,20 @@ public class AlertManager extends AbstractComponent {
private void internalStop() { private void internalStop() {
if (state.compareAndSet(State.STARTED, State.STOPPING)) { if (state.compareAndSet(State.STARTED, State.STOPPING)) {
while (true) {
// It can happen we have still ongoing operations and we wait those operations to finish to avoid
// that AlertManager or any of its components end up in a illegal state after the state as been set to stopped.
//
// For example: An alert action entry may be added while we stopping alerting if we don't wait for
// ongoing operations to complete. Resulting in once the alert manager starts again that more than
// expected alert action entries are processed.
//
// Note: new operations will fail now because the state has been set to: stopping
if (!alertLock.hasLockedKeys()) {
break;
}
}
logger.info("Stopping alert manager..."); logger.info("Stopping alert manager...");
actionManager.stop(); actionManager.stop();
scheduler.stop(); scheduler.stop();