honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update TODO after a brief talk with couchDB team, attachment filter doesn't make sense on server side but only on client side. BTW, we may like to fully support attachments in ES couchDB river as by now only meta information are sent to Elastic Search

This commit is contained in:
David Pilato 2011-08-28 23:34:38 +02:00 committed by Shay Banon
parent 1f30681a84
commit 7420e99e7d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/river/couchdb/src/main/java/org/elasticsearch/river/couchdb/CouchdbRiver.java
View File

@ -254,7 +254,6 @@ public class CouchdbRiver extends AbstractRiverComponent implements River {
}
// Remove _attachement from doc if needed
// TODO : check if couchDB support now attachment filter : https://issues.apache.org/jira/browse/COUCHDB-1263
if (couchIgnoreAttachements) {
if (doc.containsKey("_attachments")) {
Map<String, Object> _attachments = (Map<String, Object>) doc
@ -266,6 +265,9 @@ public class CouchdbRiver extends AbstractRiverComponent implements River {
}
}
}
} else {
// TODO by now, couchDB river does not really store attachments in Elastic Search but only attachments meta informations
// So we perhaps need to fully support attachments
}
bulk.add(indexRequest(index).type(type).id(id).source(doc).routing(extractRouting(ctx)));
@ -403,7 +405,6 @@ public class CouchdbRiver extends AbstractRiverComponent implements River {
file = file + couchFilterParamsUrl;
}
}
// TODO : check if couchDB support now attachment filter : https://issues.apache.org/jira/browse/COUCHDB-1263
if (lastSeq != null) {
file = file + "&since=" + lastSeq;