honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SQL: Soften NOCOMMIT to TODO 

I'm adding this to the SQL tracker issue. It is more low priority
but we should think about doing it before merging because it is
fairly easy:

Exceptions have many constructors that take a string pattern and
arguments. These kinds of things have mostly been removed in core
because we prefer explicitly building the message at the call site
for clarity. We should probably remove these constructors because
it is easy and another way that we can be more like core quickly.

Original commit: elastic/x-pack-elasticsearch@fa4326c4d1
This commit is contained in:
Nik Everett 2017-09-18 18:07:59 -04:00
parent 08a09582bc
commit 76543491bc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sql/net-client/src/main/java/org/elasticsearch/xpack/sql/net/client/ClientException.java
View File

@ -18,7 +18,7 @@ public class ClientException extends RuntimeException {
super(message); super(message);
} }
public ClientException(String message, Object... args) { // NOCOMMIT these are not popular in core any more.... public ClientException(String message, Object... args) { // TODO remove these ctors
super(format(Locale.ROOT, message, args)); super(format(Locale.ROOT, message, args));
} }