adjust some javadocs and methods visibility

This commit is contained in:
javanna 2017-01-09 18:14:26 +01:00 committed by Luca Cavanna
parent 4d51be1257
commit 77141716ba
5 changed files with 8 additions and 12 deletions

View File

@ -108,7 +108,7 @@ public final class RemoteClusterService extends AbstractComponent implements Clo
} }
/** /**
* This method updates the list of remote clusters. it's intendet to be used as a update consumer on the settings infrastructure * This method updates the list of remote clusters. It's intended to be used as an update consumer on the settings infrastructure
* @param seedSettings the group settings returned from {@link #REMOTE_CLUSTERS_SEEDS} * @param seedSettings the group settings returned from {@link #REMOTE_CLUSTERS_SEEDS}
* @param connectionListener a listener invoked once every configured cluster has been connected to * @param connectionListener a listener invoked once every configured cluster has been connected to
*/ */
@ -288,7 +288,7 @@ public final class RemoteClusterService extends AbstractComponent implements Clo
* Returns a connection to the given node on the given remote cluster * Returns a connection to the given node on the given remote cluster
* @throws IllegalArgumentException if the remote cluster is unknown * @throws IllegalArgumentException if the remote cluster is unknown
*/ */
Transport.Connection getConnection(DiscoveryNode node, String cluster) { private Transport.Connection getConnection(DiscoveryNode node, String cluster) {
RemoteClusterConnection connection = remoteClusters.get(cluster); RemoteClusterConnection connection = remoteClusters.get(cluster);
if (connection == null) { if (connection == null) {
throw new IllegalArgumentException("no such remote cluster: " + cluster); throw new IllegalArgumentException("no such remote cluster: " + cluster);

View File

@ -411,6 +411,4 @@ public class SearchTransportService extends AbstractLifecycleComponent {
protected void doClose() throws IOException { protected void doClose() throws IOException {
remoteClusterService.close(); remoteClusterService.close();
} }
} }

View File

@ -227,8 +227,6 @@ public class TransportSearchAction extends HandledTransportAction<SearchRequest,
return new GroupShardsIterator(shards); return new GroupShardsIterator(shards);
} }
@Override @Override
protected final void doExecute(SearchRequest searchRequest, ActionListener<SearchResponse> listener) { protected final void doExecute(SearchRequest searchRequest, ActionListener<SearchResponse> listener) {
throw new UnsupportedOperationException("the task parameter is required"); throw new UnsupportedOperationException("the task parameter is required");

View File

@ -28,7 +28,7 @@ import java.io.IOException;
import java.io.UncheckedIOException; import java.io.UncheckedIOException;
/** /**
* TransportActionProxy allows an arbitrary action to be executed on a defined target node while the initial request is send to a second * TransportActionProxy allows an arbitrary action to be executed on a defined target node while the initial request is sent to a second
* node that acts as a request proxy to the target node. This is useful if a node is not directly connected to a target node but is * node that acts as a request proxy to the target node. This is useful if a node is not directly connected to a target node but is
* connected to an intermediate node that establishes a transitive connection. * connected to an intermediate node that establishes a transitive connection.
*/ */
@ -42,7 +42,7 @@ public final class TransportActionProxy {
private final String action; private final String action;
private final Supplier<TransportResponse> responseFactory; private final Supplier<TransportResponse> responseFactory;
public ProxyRequestHandler(TransportService service, String action, Supplier<TransportResponse> responseFactory) { ProxyRequestHandler(TransportService service, String action, Supplier<TransportResponse> responseFactory) {
this.service = service; this.service = service;
this.action = action; this.action = action;
this.responseFactory = responseFactory; this.responseFactory = responseFactory;
@ -61,7 +61,7 @@ public final class TransportActionProxy {
private final Supplier<T> responseFactory; private final Supplier<T> responseFactory;
private final TransportChannel channel; private final TransportChannel channel;
public ProxyResponseHandler(TransportChannel channel, Supplier<T> responseFactory) { ProxyResponseHandler(TransportChannel channel, Supplier<T> responseFactory) {
this.responseFactory = responseFactory; this.responseFactory = responseFactory;
this.channel = channel; this.channel = channel;
@ -100,11 +100,11 @@ public final class TransportActionProxy {
Supplier<T> supplier; Supplier<T> supplier;
DiscoveryNode targetNode; DiscoveryNode targetNode;
public ProxyRequest(Supplier<T> supplier) { ProxyRequest(Supplier<T> supplier) {
this.supplier = supplier; this.supplier = supplier;
} }
public ProxyRequest(T wrapped, DiscoveryNode targetNode) { ProxyRequest(T wrapped, DiscoveryNode targetNode) {
this.wrapped = wrapped; this.wrapped = wrapped;
this.targetNode = targetNode; this.targetNode = targetNode;
} }

View File

@ -351,7 +351,7 @@ public class TransportService extends AbstractLifecycleComponent {
* Executes a high-level handshake using the given connection * Executes a high-level handshake using the given connection
* and returns the discovery node of the node the connection * and returns the discovery node of the node the connection
* was established with. The handshake will fail if the cluster * was established with. The handshake will fail if the cluster
* name on the target node mismatches the local cluster name. * name on the target node doesn't match the local cluster name.
* *
* @param connection the connection to a specific node * @param connection the connection to a specific node
* @param handshakeTimeout handshake timeout * @param handshakeTimeout handshake timeout