honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Type removal] Remove _type from _bulk yaml test, scripts, unused constants (#3372) 

* [Type removal] Remove redundant _type deprecation checks in bulk request

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* [Type removal] bulk yaml tests validating deprecation on _type and removal from scripts

Signed-off-by: Suraj Singh <surajrider@gmail.com>
This commit is contained in:
Suraj Singh 2022-05-18 14:04:29 -07:00 committed by GitHub
parent daed5c190a
commit 7a73fb561e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/ingest-common/src/test/java/org/opensearch/ingest/common/ForEachProcessorTests.java
View File

@ -127,7 +127,6 @@ public class ForEachProcessorTests extends OpenSearchTestCase {
TestProcessor innerProcessor = new TestProcessor(id -> {
id.setFieldValue("_ingest._value.index", id.getSourceAndMetadata().get("_index"));
id.setFieldValue("_ingest._value.type", id.getSourceAndMetadata().get("_type"));
id.setFieldValue("_ingest._value.id", id.getSourceAndMetadata().get("_id"));
});
ForEachProcessor processor = new ForEachProcessor("_tag", null, "values", innerProcessor, false);

20
rest-api-spec/src/main/resources/rest-api-spec/test/bulk/60_deprecated.yml
View File

@ -1,20 +0,0 @@
---
"Deprecated parameters should fail in Bulk query":
- do:
catch: bad_request
bulk:
body: |
{ "update": { "_index": "test_index", "_type": "test_type", "_id": "test_id_1", "_version": 1 } }
{ "doc": { "f1": "v1" } }
{ "update": { "_index": "test_index", "_type": "test_type", "_id": "test_id_2", "_version": 1 } }
{ "doc": { "f1": "v2" } }
- do:
catch: bad_request
bulk:
body: |
{ "update": { "_index": "test_index", "_type": "test_type", "_id": "test_id_1", "_routing": "test1" } }
{ "doc": { "f1": "v1" } }
{ "update": { "_index": "test_index", "_type": "test_type", "_id": "test_id_2", "_routing": "test1" } }
{ "doc": { "f1": "v2" } }

1
server/src/internalClusterTest/java/org/opensearch/search/fields/SearchFieldsIT.java
View File

@ -142,7 +142,6 @@ public class SearchFieldsIT extends OpenSearchIntegTestCase {
scripts.put("_fields['num1'].value", vars -> fieldsScript(vars, "num1"));
scripts.put("_fields._uid.value", vars -> fieldsScript(vars, "_uid"));
scripts.put("_fields._id.value", vars -> fieldsScript(vars, "_id"));
scripts.put("_fields._type.value", vars -> fieldsScript(vars, "_type"));
scripts.put("_source.obj1", vars -> sourceScript(vars, "obj1"));
scripts.put("_source.obj1.test", vars -> sourceScript(vars, "obj1.test"));

1
server/src/main/java/org/opensearch/action/termvectors/MultiTermVectorsResponse.java
View File

@ -161,7 +161,6 @@ public class MultiTermVectorsResponse extends ActionResponse implements Iterable
static final class Fields {
static final String DOCS = "docs";
static final String _INDEX = "_index";
static final String _TYPE = "_type";
static final String _ID = "_id";
}

1
server/src/main/java/org/opensearch/action/update/UpdateHelper.java
View File

@ -482,7 +482,6 @@ public class UpdateHelper {
public static final String SOURCE = "_source";
public static final String NOW = "_now";
public static final String INDEX = "_index";
public static final String TYPE = "_type";
public static final String ID = "_id";
public static final String VERSION = "_version";
public static final String ROUTING = "_routing";