Remove assemble task when not used for publishing (#25228)

Removes the `assemble` task from projects that are not published.
This should speed up `gradle assemble` by skipping projects that
don't need to be built. Which is useful because `gradle assemble`
is how we cut releases.

benchmarks/build.gradle

@@ -34,6 +34,8 @@ apply plugin: 'com.github.johnrengelman.shadow'
 // have the shadow plugin provide the runShadow task
 apply plugin: 'application'
 
+tasks.remove(assemble) // Not published so no need to assemble
+
 archivesBaseName = 'elasticsearch-benchmarks'
 mainClassName = 'org.openjdk.jmh.Main'
 

build.gradle

@@ -420,3 +420,16 @@ task run(type: Run) {
   group = 'Verification'
   impliesSubProjects = true
 }
+
+/* Remove assemble on all qa projects because we don't need to publish
+ * artifacts for them. */
+gradle.projectsEvaluated {
+  subprojects {
+    if (project.path.startsWith(':qa')) {
+      Task assemble = project.tasks.findByName('assemble')
+      if (assemble) {
+        project.tasks.remove(assemble)
+      }
+    }
+  }
+}

buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy

@@ -394,8 +394,11 @@ class BuildPlugin implements Plugin<Project> {
             project.tasks.withType(GenerateMavenPom.class) { GenerateMavenPom t ->
                 // place the pom next to the jar it is for
                 t.destination = new File(project.buildDir, "distributions/${project.archivesBaseName}-${project.version}.pom")
-                // build poms with assemble
+                // build poms with assemble (if the assemble task exists)
-                project.assemble.dependsOn(t)
+                Task assemble = project.tasks.findByName('assemble')
+                if (assemble) {
+                    assemble.dependsOn(t)
+                }
             }
         }
     }

buildSrc/src/main/groovy/org/elasticsearch/gradle/doc/DocsTestPlugin.groovy

@@ -32,6 +32,8 @@ public class DocsTestPlugin extends RestTestPlugin {
     public void apply(Project project) {
         project.pluginManager.apply('elasticsearch.standalone-rest-test')
         super.apply(project)
+        // Docs are published separately so no need to assemble
+        project.tasks.remove(project.assemble)
         Map<String, String> defaultSubstitutions = [
             /* These match up with the asciidoc syntax for substitutions but
              * the values may differ. In particular {version} needs to resolve

client/benchmark/build.gradle

@@ -37,6 +37,8 @@ apply plugin: 'application'
 
 group = 'org.elasticsearch.client'
 
+tasks.remove(assemble) // Not published so no need to assemble
+
 archivesBaseName = 'client-benchmarks'
 mainClassName = 'org.elasticsearch.client.benchmark.BenchmarkMain'
 

client/client-benchmark-noop-api-plugin/build.gradle

@@ -27,9 +27,10 @@ esplugin {
   classname 'org.elasticsearch.plugin.noop.NoopPlugin'
 }
 
+tasks.remove(assemble) // Not published so no need to assemble
+
 compileJava.options.compilerArgs << "-Xlint:-cast,-deprecation,-rawtypes,-try,-unchecked"
 
 // no unit tests
 test.enabled = false
 integTest.enabled = false
-

distribution/bwc/build.gradle

@@ -49,6 +49,7 @@ if (project.name == 'bwc-stable-snapshot') {
 
 if (enabled) {
   apply plugin: 'distribution'
+  tasks.remove(assemble) // Not published so no need to assemble
 
   def (String major, String minor, String bugfix) = bwcVersion.split('\\.')
   def (String currentMajor, String currentMinor, String currentBugfix) = version.split('\\.')

plugins/examples/build.gradle

@@ -0,0 +1,9 @@
+// Subprojects aren't published so do not assemble
+gradle.projectsEvaluated {
+  subprojects {
+    Task assemble = project.tasks.findByName('assemble')
+    if (assemble) {
+      project.tasks.remove(assemble)
+    }
+  }
+}

plugins/jvm-example/build.gradle

@@ -21,6 +21,7 @@ esplugin {
   description 'Demonstrates all the pluggable Java entry points in Elasticsearch'
   classname 'org.elasticsearch.plugin.example.JvmExamplePlugin'
 }
+tasks.remove(assemble) // Not published so no need to assemble
 
 // no unit tests
 test.enabled = false
@@ -47,4 +48,3 @@ integTestCluster {
 integTestRunner {
   systemProperty 'external.address', "${ -> exampleFixture.addressAndPort }"
 }
-

test/fixtures/example-fixture/build.gradle

@@ -19,3 +19,4 @@
 
 apply plugin: 'elasticsearch.build'
 test.enabled = false
+tasks.remove(assemble) // Not published so no need to assemble