From 7c3198ba448038aabeb93d52e5070ddedb936deb Mon Sep 17 00:00:00 2001 From: Marios Trivyzas Date: Thu, 14 Nov 2019 11:29:57 +0100 Subject: [PATCH] SQL: [Tests] Mute testReplaceChildren for Pivot (#49045) Temporarily "mute" the testReplaceChildren for Pivot since it leads to failing tests for some seeds, since the new child doesn't respond to a valid data type. Relates to #48900 (cherry picked from commit 6200a2207b9a4264d2f3fc976577323c7e084317) --- .../org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java b/x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java index ddcbe27906e..f27c65fbc7c 100644 --- a/x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java +++ b/x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/tree/NodeSubclassTests.java @@ -36,9 +36,11 @@ import org.elasticsearch.xpack.sql.expression.predicate.operator.comparison.In; import org.elasticsearch.xpack.sql.expression.predicate.operator.comparison.InPipe; import org.elasticsearch.xpack.sql.expression.predicate.regex.Like; import org.elasticsearch.xpack.sql.expression.predicate.regex.LikePattern; +import org.elasticsearch.xpack.sql.plan.logical.Pivot; import org.elasticsearch.xpack.sql.tree.NodeTests.ChildrenAreAProperty; import org.elasticsearch.xpack.sql.tree.NodeTests.Dummy; import org.elasticsearch.xpack.sql.tree.NodeTests.NoChildren; +import org.junit.Assume; import org.mockito.exceptions.base.MockitoException; import java.io.IOException; @@ -164,6 +166,9 @@ public class NodeSubclassTests> extends ESTestCas * Test {@link Node#replaceChildren} implementation on {@link #subclass}. */ public void testReplaceChildren() throws Exception { + // TODO: Provide a proper fix for: https://github.com/elastic/elasticsearch/issues/48900 + Assume.assumeFalse(subclass.equals(Pivot.class)); + Constructor ctor = longestCtor(subclass); Object[] nodeCtorArgs = ctorArgs(ctor); T node = ctor.newInstance(nodeCtorArgs);