honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tests: Block replica check for static index bwc tests until all pending 

tasks are complete

Blocking once replicas are set to 0 here should remove the chance of a
race condition while the replicas are being removed.
This commit is contained in:
Ryan Ernst 2015-01-20 11:08:42 -08:00
parent a7a726700e
commit 81621840b8
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/java/org/elasticsearch/bwcompat/OldIndexBackwardsCompatibilityTests.java
View File

@ -182,7 +182,7 @@ public class OldIndexBackwardsCompatibilityTests extends StaticIndexBackwardComp
.build()));
}
void assertNewReplicasWork() {
void assertNewReplicasWork() throws Exception {
final int numReplicas = randomIntBetween(2, 3);
for (int i = 0; i < numReplicas; ++i) {
logger.debug("Creating another node for replica " + i);
@ -195,11 +195,15 @@ public class OldIndexBackwardsCompatibilityTests extends StaticIndexBackwardComp
ensureGreen("test");
assertAcked(client().admin().indices().prepareUpdateSettings("test").setSettings(ImmutableSettings.builder()
.put("number_of_replicas", numReplicas)).execute().actionGet());
ensureGreen(TimeValue.timeValueMinutes(1), "test"); // this can take a while when the number of replicas is high
// This can take a while when the number of replicas is greater than cluster.routing.allocation.node_concurrent_recoveries
// (which defaults to 2). We could override that setting, but running this test on a busy box could
// still result in taking a long time to finish starting replicas, so instead we have an increased timeout
ensureGreen(TimeValue.timeValueMinutes(1), "test");
assertAcked(client().admin().indices().prepareUpdateSettings("test").setSettings(ImmutableSettings.builder()
.put("number_of_replicas", 0))
.execute().actionGet());
waitNoPendingTasksOnAll(); // make sure the replicas are removed before going on
}
void assertUpgradeWorks(boolean alreadyLatest) throws Exception {