diff --git a/core/src/main/java/org/elasticsearch/cluster/NodeConnectionsService.java b/core/src/main/java/org/elasticsearch/cluster/NodeConnectionsService.java
index 5fe42a7b163..79c4db9dcad 100644
--- a/core/src/main/java/org/elasticsearch/cluster/NodeConnectionsService.java
+++ b/core/src/main/java/org/elasticsearch/cluster/NodeConnectionsService.java
@@ -46,7 +46,7 @@ import static org.elasticsearch.common.settings.Setting.positiveTimeSetting;
* to pings. This is done by {@link org.elasticsearch.discovery.zen.fd.NodesFaultDetection}. Master fault detection
* is done by {@link org.elasticsearch.discovery.zen.fd.MasterFaultDetection}.
*/
-public class NodeConnectionsService extends AbstractLifecycleComponent {
+public class NodeConnectionsService extends AbstractLifecycleComponent {
public static final Setting CLUSTER_NODE_RECONNECT_INTERVAL_SETTING =
positiveTimeSetting("cluster.nodes.reconnect_interval", TimeValue.timeValueSeconds(10), Property.NodeScope);
diff --git a/core/src/main/java/org/elasticsearch/cluster/routing/DelayedAllocationService.java b/core/src/main/java/org/elasticsearch/cluster/routing/DelayedAllocationService.java
index e79884cf9c9..ea0b7e3094c 100644
--- a/core/src/main/java/org/elasticsearch/cluster/routing/DelayedAllocationService.java
+++ b/core/src/main/java/org/elasticsearch/cluster/routing/DelayedAllocationService.java
@@ -51,7 +51,7 @@ import java.util.concurrent.atomic.AtomicReference;
* {@link AllocationService#removeDelayMarkers(RoutingAllocation)}, triggering yet
* another cluster change event.
*/
-public class DelayedAllocationService extends AbstractLifecycleComponent implements ClusterStateListener {
+public class DelayedAllocationService extends AbstractLifecycleComponent implements ClusterStateListener {
static final String CLUSTER_UPDATE_TASK_SOURCE = "delayed_allocation_reroute";
diff --git a/core/src/main/java/org/elasticsearch/cluster/routing/RoutingService.java b/core/src/main/java/org/elasticsearch/cluster/routing/RoutingService.java
index 78e7e15d389..7bd2c2219b5 100644
--- a/core/src/main/java/org/elasticsearch/cluster/routing/RoutingService.java
+++ b/core/src/main/java/org/elasticsearch/cluster/routing/RoutingService.java
@@ -44,7 +44,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
* actions.
*
*/
-public class RoutingService extends AbstractLifecycleComponent {
+public class RoutingService extends AbstractLifecycleComponent {
private static final String CLUSTER_UPDATE_TASK_SOURCE = "cluster_reroute";
diff --git a/core/src/main/java/org/elasticsearch/cluster/service/ClusterService.java b/core/src/main/java/org/elasticsearch/cluster/service/ClusterService.java
index 1480ef9a504..accb9304d25 100644
--- a/core/src/main/java/org/elasticsearch/cluster/service/ClusterService.java
+++ b/core/src/main/java/org/elasticsearch/cluster/service/ClusterService.java
@@ -88,7 +88,7 @@ import static org.elasticsearch.common.util.concurrent.EsExecutors.daemonThreadF
/**
*
*/
-public class ClusterService extends AbstractLifecycleComponent {
+public class ClusterService extends AbstractLifecycleComponent {
public static final Setting CLUSTER_SERVICE_SLOW_TASK_LOGGING_THRESHOLD_SETTING =
Setting.positiveTimeSetting("cluster.service.slow_task_logging_threshold", TimeValue.timeValueSeconds(30),
diff --git a/core/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java b/core/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
index 11dbca72973..6f1534b57d8 100644
--- a/core/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
+++ b/core/src/main/java/org/elasticsearch/common/component/AbstractLifecycleComponent.java
@@ -27,7 +27,7 @@ import java.util.concurrent.CopyOnWriteArrayList;
/**
*
*/
-public abstract class AbstractLifecycleComponent extends AbstractComponent implements LifecycleComponent {
+public abstract class AbstractLifecycleComponent extends AbstractComponent implements LifecycleComponent {
protected final Lifecycle lifecycle = new Lifecycle();
@@ -58,9 +58,9 @@ public abstract class AbstractLifecycleComponent extends AbstractComponent im
@SuppressWarnings({"unchecked"})
@Override
- public T start() {
+ public void start() {
if (!lifecycle.canMoveToStarted()) {
- return (T) this;
+ return;
}
for (LifecycleListener listener : listeners) {
listener.beforeStart();
@@ -70,16 +70,15 @@ public abstract class AbstractLifecycleComponent extends AbstractComponent im
for (LifecycleListener listener : listeners) {
listener.afterStart();
}
- return (T) this;
}
protected abstract void doStart();
@SuppressWarnings({"unchecked"})
@Override
- public T stop() {
+ public void stop() {
if (!lifecycle.canMoveToStopped()) {
- return (T) this;
+ return;
}
for (LifecycleListener listener : listeners) {
listener.beforeStop();
@@ -89,7 +88,6 @@ public abstract class AbstractLifecycleComponent extends AbstractComponent im
for (LifecycleListener listener : listeners) {
listener.afterStop();
}
- return (T) this;
}
protected abstract void doStop();
diff --git a/core/src/main/java/org/elasticsearch/common/component/LifecycleComponent.java b/core/src/main/java/org/elasticsearch/common/component/LifecycleComponent.java
index 2933bffa630..b57486105d2 100644
--- a/core/src/main/java/org/elasticsearch/common/component/LifecycleComponent.java
+++ b/core/src/main/java/org/elasticsearch/common/component/LifecycleComponent.java
@@ -24,7 +24,7 @@ import org.elasticsearch.common.lease.Releasable;
/**
*
*/
-public interface LifecycleComponent extends Releasable {
+public interface LifecycleComponent extends Releasable {
Lifecycle.State lifecycleState();
@@ -32,7 +32,7 @@ public interface LifecycleComponent extends Releasable {
void removeLifecycleListener(LifecycleListener listener);
- T start();
+ void start();
- T stop();
+ void stop();
}
diff --git a/core/src/main/java/org/elasticsearch/discovery/Discovery.java b/core/src/main/java/org/elasticsearch/discovery/Discovery.java
index 778e2d15053..751f5480ca8 100644
--- a/core/src/main/java/org/elasticsearch/discovery/Discovery.java
+++ b/core/src/main/java/org/elasticsearch/discovery/Discovery.java
@@ -34,7 +34,7 @@ import java.io.IOException;
* state to all nodes, electing a master of the cluster that raises cluster state change
* events.
*/
-public interface Discovery extends LifecycleComponent {
+public interface Discovery extends LifecycleComponent {
DiscoveryNode localNode();
diff --git a/core/src/main/java/org/elasticsearch/discovery/local/LocalDiscovery.java b/core/src/main/java/org/elasticsearch/discovery/local/LocalDiscovery.java
index a711427de77..7ba207284b2 100644
--- a/core/src/main/java/org/elasticsearch/discovery/local/LocalDiscovery.java
+++ b/core/src/main/java/org/elasticsearch/discovery/local/LocalDiscovery.java
@@ -56,7 +56,7 @@ import static org.elasticsearch.cluster.ClusterState.Builder;
/**
*
*/
-public class LocalDiscovery extends AbstractLifecycleComponent implements Discovery {
+public class LocalDiscovery extends AbstractLifecycleComponent implements Discovery {
private static final LocalDiscovery[] NO_MEMBERS = new LocalDiscovery[0];
diff --git a/core/src/main/java/org/elasticsearch/discovery/zen/ZenDiscovery.java b/core/src/main/java/org/elasticsearch/discovery/zen/ZenDiscovery.java
index 0efbe64196e..6ebdfa7e6e6 100644
--- a/core/src/main/java/org/elasticsearch/discovery/zen/ZenDiscovery.java
+++ b/core/src/main/java/org/elasticsearch/discovery/zen/ZenDiscovery.java
@@ -86,7 +86,7 @@ import static org.elasticsearch.common.unit.TimeValue.timeValueSeconds;
/**
*
*/
-public class ZenDiscovery extends AbstractLifecycleComponent implements Discovery, PingContextProvider {
+public class ZenDiscovery extends AbstractLifecycleComponent implements Discovery, PingContextProvider {
public static final Setting PING_TIMEOUT_SETTING =
Setting.positiveTimeSetting("discovery.zen.ping_timeout", timeValueSeconds(3), Property.NodeScope);
diff --git a/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPing.java b/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPing.java
index 06db6ab3d5c..5a9f5f463e2 100644
--- a/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPing.java
+++ b/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPing.java
@@ -32,7 +32,7 @@ import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.atomic.AtomicLong;
-public interface ZenPing extends LifecycleComponent {
+public interface ZenPing extends LifecycleComponent {
void setPingContextProvider(PingContextProvider contextProvider);
diff --git a/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPingService.java b/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPingService.java
index 6933d8c37b5..bd5855666ac 100644
--- a/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPingService.java
+++ b/core/src/main/java/org/elasticsearch/discovery/zen/ping/ZenPingService.java
@@ -33,7 +33,7 @@ import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
-public class ZenPingService extends AbstractLifecycleComponent implements ZenPing {
+public class ZenPingService extends AbstractLifecycleComponent implements ZenPing {
private List zenPings = Collections.emptyList();
diff --git a/core/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java b/core/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java
index 06fc9eae13d..d010587dda4 100644
--- a/core/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java
+++ b/core/src/main/java/org/elasticsearch/discovery/zen/ping/unicast/UnicastZenPing.java
@@ -86,7 +86,7 @@ import static org.elasticsearch.discovery.zen.ping.ZenPing.PingResponse.readPing
/**
*
*/
-public class UnicastZenPing extends AbstractLifecycleComponent implements ZenPing {
+public class UnicastZenPing extends AbstractLifecycleComponent implements ZenPing {
public static final String ACTION_NAME = "internal:discovery/zen/unicast";
public static final Setting> DISCOVERY_ZEN_PING_UNICAST_HOSTS_SETTING =
diff --git a/core/src/main/java/org/elasticsearch/gateway/GatewayService.java b/core/src/main/java/org/elasticsearch/gateway/GatewayService.java
index 8bd1dcbd6ea..746d70db009 100644
--- a/core/src/main/java/org/elasticsearch/gateway/GatewayService.java
+++ b/core/src/main/java/org/elasticsearch/gateway/GatewayService.java
@@ -52,7 +52,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
/**
*
*/
-public class GatewayService extends AbstractLifecycleComponent implements ClusterStateListener {
+public class GatewayService extends AbstractLifecycleComponent implements ClusterStateListener {
public static final Setting EXPECTED_NODES_SETTING =
Setting.intSetting("gateway.expected_nodes", -1, -1, Property.NodeScope);
diff --git a/core/src/main/java/org/elasticsearch/http/HttpServer.java b/core/src/main/java/org/elasticsearch/http/HttpServer.java
index 63bcd761eb3..8e3f15c5a24 100644
--- a/core/src/main/java/org/elasticsearch/http/HttpServer.java
+++ b/core/src/main/java/org/elasticsearch/http/HttpServer.java
@@ -51,7 +51,7 @@ import static org.elasticsearch.rest.RestStatus.INTERNAL_SERVER_ERROR;
/**
* A component to serve http requests, backed by rest handlers.
*/
-public class HttpServer extends AbstractLifecycleComponent implements HttpServerAdapter {
+public class HttpServer extends AbstractLifecycleComponent implements HttpServerAdapter {
private final HttpServerTransport transport;
private final RestController restController;
diff --git a/core/src/main/java/org/elasticsearch/http/HttpServerTransport.java b/core/src/main/java/org/elasticsearch/http/HttpServerTransport.java
index fa75f1dcb1e..ab8b2bd1797 100644
--- a/core/src/main/java/org/elasticsearch/http/HttpServerTransport.java
+++ b/core/src/main/java/org/elasticsearch/http/HttpServerTransport.java
@@ -25,7 +25,7 @@ import org.elasticsearch.common.transport.BoundTransportAddress;
/**
*
*/
-public interface HttpServerTransport extends LifecycleComponent {
+public interface HttpServerTransport extends LifecycleComponent {
BoundTransportAddress boundAddress();
diff --git a/core/src/main/java/org/elasticsearch/http/netty/NettyHttpServerTransport.java b/core/src/main/java/org/elasticsearch/http/netty/NettyHttpServerTransport.java
index 77c140ce7ce..6578628107e 100644
--- a/core/src/main/java/org/elasticsearch/http/netty/NettyHttpServerTransport.java
+++ b/core/src/main/java/org/elasticsearch/http/netty/NettyHttpServerTransport.java
@@ -113,7 +113,7 @@ import static org.elasticsearch.http.netty.cors.CorsHandler.ANY_ORIGIN;
/**
*
*/
-public class NettyHttpServerTransport extends AbstractLifecycleComponent implements HttpServerTransport {
+public class NettyHttpServerTransport extends AbstractLifecycleComponent implements HttpServerTransport {
static {
NettyUtils.setup();
diff --git a/core/src/main/java/org/elasticsearch/indices/IndicesService.java b/core/src/main/java/org/elasticsearch/indices/IndicesService.java
index 27387d7daaa..fadd10eae58 100644
--- a/core/src/main/java/org/elasticsearch/indices/IndicesService.java
+++ b/core/src/main/java/org/elasticsearch/indices/IndicesService.java
@@ -135,7 +135,7 @@ import static org.elasticsearch.common.util.CollectionUtils.arrayAsArrayList;
/**
*
*/
-public class IndicesService extends AbstractLifecycleComponent
+public class IndicesService extends AbstractLifecycleComponent
implements IndicesClusterStateService.AllocatedIndices, IndexService.ShardStoreDeleter {
public static final String INDICES_SHARDS_CLOSED_TIMEOUT = "indices.shards_closed_timeout";
diff --git a/core/src/main/java/org/elasticsearch/indices/breaker/CircuitBreakerService.java b/core/src/main/java/org/elasticsearch/indices/breaker/CircuitBreakerService.java
index 05bf8472ac9..93e5ad74ad8 100644
--- a/core/src/main/java/org/elasticsearch/indices/breaker/CircuitBreakerService.java
+++ b/core/src/main/java/org/elasticsearch/indices/breaker/CircuitBreakerService.java
@@ -27,7 +27,7 @@ import org.elasticsearch.common.settings.Settings;
* Interface for Circuit Breaker services, which provide breakers to classes
* that load field data.
*/
-public abstract class CircuitBreakerService extends AbstractLifecycleComponent {
+public abstract class CircuitBreakerService extends AbstractLifecycleComponent {
protected CircuitBreakerService(Settings settings) {
super(settings);
diff --git a/core/src/main/java/org/elasticsearch/indices/cluster/IndicesClusterStateService.java b/core/src/main/java/org/elasticsearch/indices/cluster/IndicesClusterStateService.java
index c0bfedc47ca..b5644ac3bb0 100644
--- a/core/src/main/java/org/elasticsearch/indices/cluster/IndicesClusterStateService.java
+++ b/core/src/main/java/org/elasticsearch/indices/cluster/IndicesClusterStateService.java
@@ -82,7 +82,7 @@ import java.util.concurrent.TimeUnit;
/**
*
*/
-public class IndicesClusterStateService extends AbstractLifecycleComponent implements ClusterStateListener {
+public class IndicesClusterStateService extends AbstractLifecycleComponent implements ClusterStateListener {
final AllocatedIndices extends Shard, ? extends AllocatedIndex extends Shard>> indicesService;
private final ClusterService clusterService;
diff --git a/core/src/main/java/org/elasticsearch/indices/ttl/IndicesTTLService.java b/core/src/main/java/org/elasticsearch/indices/ttl/IndicesTTLService.java
index 8cc479aa4e7..b837839ce86 100644
--- a/core/src/main/java/org/elasticsearch/indices/ttl/IndicesTTLService.java
+++ b/core/src/main/java/org/elasticsearch/indices/ttl/IndicesTTLService.java
@@ -66,7 +66,7 @@ import java.util.concurrent.locks.ReentrantLock;
/**
* A node level service that delete expired docs on node primary shards.
*/
-public class IndicesTTLService extends AbstractLifecycleComponent {
+public class IndicesTTLService extends AbstractLifecycleComponent {
public static final Setting INDICES_TTL_INTERVAL_SETTING =
Setting.positiveTimeSetting("indices.ttl.interval", TimeValue.timeValueSeconds(60),
diff --git a/core/src/main/java/org/elasticsearch/monitor/MonitorService.java b/core/src/main/java/org/elasticsearch/monitor/MonitorService.java
index 6ae9e2a5b67..59434be7d93 100644
--- a/core/src/main/java/org/elasticsearch/monitor/MonitorService.java
+++ b/core/src/main/java/org/elasticsearch/monitor/MonitorService.java
@@ -31,7 +31,7 @@ import org.elasticsearch.threadpool.ThreadPool;
import java.io.IOException;
-public class MonitorService extends AbstractLifecycleComponent {
+public class MonitorService extends AbstractLifecycleComponent {
private final JvmGcMonitorService jvmGcMonitorService;
private final OsService osService;
diff --git a/core/src/main/java/org/elasticsearch/monitor/jvm/JvmGcMonitorService.java b/core/src/main/java/org/elasticsearch/monitor/jvm/JvmGcMonitorService.java
index 69ec81c38e9..4c89c6a2a50 100644
--- a/core/src/main/java/org/elasticsearch/monitor/jvm/JvmGcMonitorService.java
+++ b/core/src/main/java/org/elasticsearch/monitor/jvm/JvmGcMonitorService.java
@@ -40,7 +40,7 @@ import java.util.function.BiFunction;
import static java.util.Collections.unmodifiableMap;
-public class JvmGcMonitorService extends AbstractLifecycleComponent {
+public class JvmGcMonitorService extends AbstractLifecycleComponent {
private final ThreadPool threadPool;
private final boolean enabled;
diff --git a/core/src/main/java/org/elasticsearch/repositories/Repository.java b/core/src/main/java/org/elasticsearch/repositories/Repository.java
index 0cfe74a0e34..47a87edd7f9 100644
--- a/core/src/main/java/org/elasticsearch/repositories/Repository.java
+++ b/core/src/main/java/org/elasticsearch/repositories/Repository.java
@@ -47,7 +47,7 @@ import java.util.function.Predicate;
* with possible list of failures
*
*/
-public interface Repository extends LifecycleComponent {
+public interface Repository extends LifecycleComponent {
/**
* Reads snapshot description from repository.
diff --git a/core/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java b/core/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
index c1efcb7801c..6518bd1df56 100644
--- a/core/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
+++ b/core/src/main/java/org/elasticsearch/repositories/blobstore/BlobStoreRepository.java
@@ -115,7 +115,7 @@ import java.util.stream.Collectors;
* }
*
*/
-public abstract class BlobStoreRepository extends AbstractLifecycleComponent implements Repository, RateLimiterListener {
+public abstract class BlobStoreRepository extends AbstractLifecycleComponent implements Repository, RateLimiterListener {
private BlobContainer snapshotsBlobContainer;
diff --git a/core/src/main/java/org/elasticsearch/rest/RestController.java b/core/src/main/java/org/elasticsearch/rest/RestController.java
index 8059dfd7ea5..29dce98ca49 100644
--- a/core/src/main/java/org/elasticsearch/rest/RestController.java
+++ b/core/src/main/java/org/elasticsearch/rest/RestController.java
@@ -44,7 +44,7 @@ import static org.elasticsearch.rest.RestStatus.OK;
/**
*
*/
-public class RestController extends AbstractLifecycleComponent {
+public class RestController extends AbstractLifecycleComponent {
private final PathTrie getHandlers = new PathTrie<>(RestUtils.REST_DECODER);
private final PathTrie postHandlers = new PathTrie<>(RestUtils.REST_DECODER);
private final PathTrie putHandlers = new PathTrie<>(RestUtils.REST_DECODER);
diff --git a/core/src/main/java/org/elasticsearch/search/SearchService.java b/core/src/main/java/org/elasticsearch/search/SearchService.java
index bc77a01d072..ec75ae37254 100644
--- a/core/src/main/java/org/elasticsearch/search/SearchService.java
+++ b/core/src/main/java/org/elasticsearch/search/SearchService.java
@@ -105,7 +105,7 @@ import static org.elasticsearch.common.unit.TimeValue.timeValueMinutes;
/**
*
*/
-public class SearchService extends AbstractLifecycleComponent implements IndexEventListener {
+public class SearchService extends AbstractLifecycleComponent implements IndexEventListener {
// we can have 5 minutes here, since we make sure to clean with search requests and when shard/index closes
public static final Setting DEFAULT_KEEPALIVE_SETTING =
diff --git a/core/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java b/core/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java
index b9d8c729223..460eaf9f819 100644
--- a/core/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java
+++ b/core/src/main/java/org/elasticsearch/snapshots/SnapshotShardsService.java
@@ -75,7 +75,7 @@ import static org.elasticsearch.cluster.SnapshotsInProgress.completed;
* This service runs on data and master nodes and controls currently snapshotted shards on these nodes. It is responsible for
* starting and stopping shard level snapshots
*/
-public class SnapshotShardsService extends AbstractLifecycleComponent implements ClusterStateListener {
+public class SnapshotShardsService extends AbstractLifecycleComponent implements ClusterStateListener {
public static final String UPDATE_SNAPSHOT_ACTION_NAME = "internal:cluster/snapshot/update_snapshot";
diff --git a/core/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java b/core/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
index d6e610a184f..e242d1be732 100644
--- a/core/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
+++ b/core/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java
@@ -98,7 +98,7 @@ import static org.elasticsearch.cluster.SnapshotsInProgress.completed;
* notifies all {@link #snapshotCompletionListeners} that snapshot is completed, and finally calls {@link #removeSnapshotFromClusterState(Snapshot, SnapshotInfo, Throwable)} to remove snapshot from cluster state
*
*/
-public class SnapshotsService extends AbstractLifecycleComponent implements ClusterStateListener {
+public class SnapshotsService extends AbstractLifecycleComponent implements ClusterStateListener {
private final ClusterService clusterService;
diff --git a/core/src/main/java/org/elasticsearch/transport/TcpTransport.java b/core/src/main/java/org/elasticsearch/transport/TcpTransport.java
index f9b5eceb4b8..cd8063969d4 100644
--- a/core/src/main/java/org/elasticsearch/transport/TcpTransport.java
+++ b/core/src/main/java/org/elasticsearch/transport/TcpTransport.java
@@ -105,7 +105,7 @@ import static org.elasticsearch.common.util.concurrent.ConcurrentCollections.new
/**
*/
-public abstract class TcpTransport extends AbstractLifecycleComponent implements Transport {
+public abstract class TcpTransport extends AbstractLifecycleComponent implements Transport {
public static final String HTTP_SERVER_WORKER_THREAD_NAME_PREFIX = "http_server_worker";
public static final String HTTP_SERVER_BOSS_THREAD_NAME_PREFIX = "http_server_boss";
diff --git a/core/src/main/java/org/elasticsearch/transport/Transport.java b/core/src/main/java/org/elasticsearch/transport/Transport.java
index 754d2105e83..6e36363741d 100644
--- a/core/src/main/java/org/elasticsearch/transport/Transport.java
+++ b/core/src/main/java/org/elasticsearch/transport/Transport.java
@@ -35,7 +35,7 @@ import java.util.Map;
/**
*
*/
-public interface Transport extends LifecycleComponent {
+public interface Transport extends LifecycleComponent {
Setting TRANSPORT_TCP_COMPRESS = Setting.boolSetting("transport.tcp.compress", false, Property.NodeScope);
diff --git a/core/src/main/java/org/elasticsearch/transport/TransportService.java b/core/src/main/java/org/elasticsearch/transport/TransportService.java
index e2f3ab44eea..5a62c8bad31 100644
--- a/core/src/main/java/org/elasticsearch/transport/TransportService.java
+++ b/core/src/main/java/org/elasticsearch/transport/TransportService.java
@@ -69,7 +69,7 @@ import static org.elasticsearch.common.settings.Settings.Builder.EMPTY_SETTINGS;
/**
*
*/
-public class TransportService extends AbstractLifecycleComponent {
+public class TransportService extends AbstractLifecycleComponent {
public static final String DIRECT_RESPONSE_PROFILE = ".direct";
private static final String HANDSHAKE_ACTION_NAME = "internal:transport/handshake";
diff --git a/core/src/main/java/org/elasticsearch/transport/local/LocalTransport.java b/core/src/main/java/org/elasticsearch/transport/local/LocalTransport.java
index ebb29d6feae..930e3951098 100644
--- a/core/src/main/java/org/elasticsearch/transport/local/LocalTransport.java
+++ b/core/src/main/java/org/elasticsearch/transport/local/LocalTransport.java
@@ -73,7 +73,7 @@ import static org.elasticsearch.common.util.concurrent.ConcurrentCollections.new
/**
*
*/
-public class LocalTransport extends AbstractLifecycleComponent implements Transport {
+public class LocalTransport extends AbstractLifecycleComponent implements Transport {
public static final String LOCAL_TRANSPORT_THREAD_NAME_PREFIX = "local_transport";
final ThreadPool threadPool;
diff --git a/core/src/main/java/org/elasticsearch/tribe/TribeService.java b/core/src/main/java/org/elasticsearch/tribe/TribeService.java
index 259a9d443a3..5c7d6d93f7c 100644
--- a/core/src/main/java/org/elasticsearch/tribe/TribeService.java
+++ b/core/src/main/java/org/elasticsearch/tribe/TribeService.java
@@ -86,7 +86,7 @@ import static java.util.Collections.unmodifiableMap;
* in another cluster, the conflict one will be discarded. This happens because we need to have the correct index name
* to propagate to the relevant cluster.
*/
-public class TribeService extends AbstractLifecycleComponent {
+public class TribeService extends AbstractLifecycleComponent {
public static final ClusterBlock TRIBE_METADATA_BLOCK = new ClusterBlock(10, "tribe node, metadata not allowed", false, false,
RestStatus.BAD_REQUEST, EnumSet.of(ClusterBlockLevel.METADATA_READ, ClusterBlockLevel.METADATA_WRITE));
diff --git a/core/src/main/java/org/elasticsearch/watcher/ResourceWatcherService.java b/core/src/main/java/org/elasticsearch/watcher/ResourceWatcherService.java
index e66269484e0..f5c7ea56cae 100644
--- a/core/src/main/java/org/elasticsearch/watcher/ResourceWatcherService.java
+++ b/core/src/main/java/org/elasticsearch/watcher/ResourceWatcherService.java
@@ -40,7 +40,7 @@ import java.util.concurrent.ScheduledFuture;
* registered watcher periodically. The frequency of checks can be specified using {@code resource.reload.interval} setting, which
* defaults to {@code 60s}. The service can be disabled by setting {@code resource.reload.enabled} setting to {@code false}.
*/
-public class ResourceWatcherService extends AbstractLifecycleComponent {
+public class ResourceWatcherService extends AbstractLifecycleComponent {
public enum Frequency {
diff --git a/core/src/test/java/org/elasticsearch/client/transport/FailAndRetryMockTransport.java b/core/src/test/java/org/elasticsearch/client/transport/FailAndRetryMockTransport.java
index c085c3164a0..9d2c176dffb 100644
--- a/core/src/test/java/org/elasticsearch/client/transport/FailAndRetryMockTransport.java
+++ b/core/src/test/java/org/elasticsearch/client/transport/FailAndRetryMockTransport.java
@@ -187,19 +187,13 @@ abstract class FailAndRetryMockTransport imp
}
@Override
- public Transport start() {
- return null;
- }
+ public void start() {}
@Override
- public Transport stop() {
- return null;
- }
+ public void stop() {}
@Override
- public void close() {
-
- }
+ public void close() {}
@Override
public Map profileBoundAddresses() {
diff --git a/core/src/test/java/org/elasticsearch/cluster/NodeConnectionsServiceTests.java b/core/src/test/java/org/elasticsearch/cluster/NodeConnectionsServiceTests.java
index 5eb5a34c44f..95dd97b4702 100644
--- a/core/src/test/java/org/elasticsearch/cluster/NodeConnectionsServiceTests.java
+++ b/core/src/test/java/org/elasticsearch/cluster/NodeConnectionsServiceTests.java
@@ -253,18 +253,12 @@ public class NodeConnectionsServiceTests extends ESTestCase {
}
@Override
- public Transport start() {
- return null;
- }
+ public void start() {}
@Override
- public Transport stop() {
- return null;
- }
+ public void stop() {}
@Override
- public void close() {
-
- }
+ public void close() {}
}
}
diff --git a/core/src/test/java/org/elasticsearch/cluster/service/ClusterServiceIT.java b/core/src/test/java/org/elasticsearch/cluster/service/ClusterServiceIT.java
index 991f11a4493..7907ad3e63c 100644
--- a/core/src/test/java/org/elasticsearch/cluster/service/ClusterServiceIT.java
+++ b/core/src/test/java/org/elasticsearch/cluster/service/ClusterServiceIT.java
@@ -591,7 +591,7 @@ public class ClusterServiceIT extends ESIntegTestCase {
}
@Singleton
- public static class MasterAwareService extends AbstractLifecycleComponent implements LocalNodeMasterListener {
+ public static class MasterAwareService extends AbstractLifecycleComponent implements LocalNodeMasterListener {
private final ClusterService clusterService;
private volatile boolean master;
diff --git a/core/src/test/java/org/elasticsearch/common/network/NetworkModuleTests.java b/core/src/test/java/org/elasticsearch/common/network/NetworkModuleTests.java
index 245520d65f3..131636e2011 100644
--- a/core/src/test/java/org/elasticsearch/common/network/NetworkModuleTests.java
+++ b/core/src/test/java/org/elasticsearch/common/network/NetworkModuleTests.java
@@ -59,7 +59,7 @@ public class NetworkModuleTests extends ModuleTestCase {
}
}
- static class FakeHttpTransport extends AbstractLifecycleComponent implements HttpServerTransport {
+ static class FakeHttpTransport extends AbstractLifecycleComponent implements HttpServerTransport {
public FakeHttpTransport() {
super(null);
}
diff --git a/core/src/test/java/org/elasticsearch/http/HttpServerTests.java b/core/src/test/java/org/elasticsearch/http/HttpServerTests.java
index 9ed680a6fbe..9a93cb4d7ea 100644
--- a/core/src/test/java/org/elasticsearch/http/HttpServerTests.java
+++ b/core/src/test/java/org/elasticsearch/http/HttpServerTests.java
@@ -120,7 +120,7 @@ public class HttpServerTests extends ESTestCase {
assertEquals(0, inFlightRequestsBreaker.getUsed());
}
- private static final class TestHttpServerTransport extends AbstractLifecycleComponent implements
+ private static final class TestHttpServerTransport extends AbstractLifecycleComponent implements
HttpServerTransport {
public TestHttpServerTransport() {
diff --git a/core/src/test/java/org/elasticsearch/http/netty/NettyHttpServerPipeliningTests.java b/core/src/test/java/org/elasticsearch/http/netty/NettyHttpServerPipeliningTests.java
index 6fc9a4e674a..ef8621dfcd3 100644
--- a/core/src/test/java/org/elasticsearch/http/netty/NettyHttpServerPipeliningTests.java
+++ b/core/src/test/java/org/elasticsearch/http/netty/NettyHttpServerPipeliningTests.java
@@ -142,9 +142,9 @@ public class NettyHttpServerPipeliningTests extends ESTestCase {
}
@Override
- public HttpServerTransport stop() {
+ public void stop() {
executorService.shutdownNow();
- return super.stop();
+ super.stop();
}
}
diff --git a/core/src/test/java/org/elasticsearch/test/NoopDiscovery.java b/core/src/test/java/org/elasticsearch/test/NoopDiscovery.java
index 3193aaf458e..21c13816293 100644
--- a/core/src/test/java/org/elasticsearch/test/NoopDiscovery.java
+++ b/core/src/test/java/org/elasticsearch/test/NoopDiscovery.java
@@ -86,17 +86,11 @@ public class NoopDiscovery implements Discovery {
}
@Override
- public Discovery start() {
- return null;
- }
+ public void start() {}
@Override
- public Discovery stop() {
- return null;
- }
+ public void stop() {}
@Override
- public void close() {
-
- }
+ public void close() {}
}
diff --git a/plugins/discovery-azure-classic/src/main/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceImpl.java b/plugins/discovery-azure-classic/src/main/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceImpl.java
index 7d6f81ad0b6..2375db2502b 100644
--- a/plugins/discovery-azure-classic/src/main/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceImpl.java
+++ b/plugins/discovery-azure-classic/src/main/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceImpl.java
@@ -39,7 +39,7 @@ import java.util.ServiceLoader;
/**
*
*/
-public class AzureComputeServiceImpl extends AbstractLifecycleComponent
+public class AzureComputeServiceImpl extends AbstractLifecycleComponent
implements AzureComputeService {
private final ComputeManagementClient client;
diff --git a/plugins/discovery-azure-classic/src/test/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceAbstractMock.java b/plugins/discovery-azure-classic/src/test/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceAbstractMock.java
index 33f40a9159a..02de9db6d69 100644
--- a/plugins/discovery-azure-classic/src/test/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceAbstractMock.java
+++ b/plugins/discovery-azure-classic/src/test/java/org/elasticsearch/cloud/azure/classic/management/AzureComputeServiceAbstractMock.java
@@ -26,7 +26,7 @@ import org.elasticsearch.common.settings.Settings;
/**
*
*/
-public abstract class AzureComputeServiceAbstractMock extends AbstractLifecycleComponent
+public abstract class AzureComputeServiceAbstractMock extends AbstractLifecycleComponent
implements AzureComputeService {
protected AzureComputeServiceAbstractMock(Settings settings) {
diff --git a/plugins/discovery-ec2/src/main/java/org/elasticsearch/cloud/aws/AwsEc2ServiceImpl.java b/plugins/discovery-ec2/src/main/java/org/elasticsearch/cloud/aws/AwsEc2ServiceImpl.java
index 5ce110487c4..2fc82a01f09 100644
--- a/plugins/discovery-ec2/src/main/java/org/elasticsearch/cloud/aws/AwsEc2ServiceImpl.java
+++ b/plugins/discovery-ec2/src/main/java/org/elasticsearch/cloud/aws/AwsEc2ServiceImpl.java
@@ -49,7 +49,7 @@ import java.util.Random;
/**
*
*/
-public class AwsEc2ServiceImpl extends AbstractLifecycleComponent implements AwsEc2Service {
+public class AwsEc2ServiceImpl extends AbstractLifecycleComponent implements AwsEc2Service {
public static final String EC2_METADATA_URL = "http://169.254.169.254/latest/meta-data/";
diff --git a/plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/AwsEc2ServiceMock.java b/plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/AwsEc2ServiceMock.java
index f14a80f01cc..19a5c8d3b96 100644
--- a/plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/AwsEc2ServiceMock.java
+++ b/plugins/discovery-ec2/src/test/java/org/elasticsearch/discovery/ec2/AwsEc2ServiceMock.java
@@ -27,7 +27,7 @@ import org.elasticsearch.common.settings.Settings;
import java.util.List;
-public class AwsEc2ServiceMock extends AbstractLifecycleComponent implements AwsEc2Service {
+public class AwsEc2ServiceMock extends AbstractLifecycleComponent implements AwsEc2Service {
private int nodes;
private List> tagsList;
diff --git a/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeService.java b/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeService.java
index a6faa390e5d..00a44cd56af 100644
--- a/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeService.java
+++ b/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeService.java
@@ -31,7 +31,7 @@ import java.util.Collections;
import java.util.List;
import java.util.function.Function;
-public interface GceComputeService extends LifecycleComponent {
+public interface GceComputeService extends LifecycleComponent {
/**
* GCE API Version: Elasticsearch/GceCloud/1.0
diff --git a/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeServiceImpl.java b/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeServiceImpl.java
index 63a19919a7b..8d1090dd82c 100644
--- a/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeServiceImpl.java
+++ b/plugins/discovery-gce/src/main/java/org/elasticsearch/cloud/gce/GceComputeServiceImpl.java
@@ -56,7 +56,7 @@ import java.util.Collections;
import java.util.List;
import java.util.function.Function;
-public class GceComputeServiceImpl extends AbstractLifecycleComponent
+public class GceComputeServiceImpl extends AbstractLifecycleComponent
implements GceComputeService {
// all settings just used for testing - not registered by default
diff --git a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/blobstore/AzureBlobStore.java b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/blobstore/AzureBlobStore.java
index 2809b8588f1..e11797219ef 100644
--- a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/blobstore/AzureBlobStore.java
+++ b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/blobstore/AzureBlobStore.java
@@ -56,7 +56,8 @@ public class AzureBlobStore extends AbstractComponent implements BlobStore {
public AzureBlobStore(RepositoryName name, Settings settings, RepositorySettings repositorySettings,
AzureStorageService client) throws URISyntaxException, StorageException {
super(settings);
- this.client = client.start();
+ this.client = client;
+ client.start();
this.container = getValue(repositorySettings, Repository.CONTAINER_SETTING, Storage.CONTAINER_SETTING);
this.repositoryName = name.getName();
this.accountName = getValue(repositorySettings, Repository.ACCOUNT_SETTING, Storage.ACCOUNT_SETTING);
diff --git a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageService.java b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageService.java
index 13db36aeb5a..aa0c1c2cf83 100644
--- a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageService.java
+++ b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageService.java
@@ -86,5 +86,5 @@ public interface AzureStorageService {
void moveBlob(String account, LocationMode mode, String container, String sourceBlob, String targetBlob)
throws URISyntaxException, StorageException;
- AzureStorageService start();
+ void start();
}
diff --git a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceImpl.java b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceImpl.java
index 09dbc6520a1..80e62b90ad3 100644
--- a/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceImpl.java
+++ b/plugins/repository-azure/src/main/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceImpl.java
@@ -45,7 +45,7 @@ import java.net.URISyntaxException;
import java.util.HashMap;
import java.util.Map;
-public class AzureStorageServiceImpl extends AbstractLifecycleComponent
+public class AzureStorageServiceImpl extends AbstractLifecycleComponent
implements AzureStorageService {
final AzureStorageSettings primaryStorageSettings;
diff --git a/plugins/repository-azure/src/test/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceMock.java b/plugins/repository-azure/src/test/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceMock.java
index 8160c560325..36351b3db88 100644
--- a/plugins/repository-azure/src/test/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceMock.java
+++ b/plugins/repository-azure/src/test/java/org/elasticsearch/cloud/azure/storage/AzureStorageServiceMock.java
@@ -41,7 +41,7 @@ import java.util.concurrent.ConcurrentHashMap;
/**
* In memory storage for unit tests
*/
-public class AzureStorageServiceMock extends AbstractLifecycleComponent
+public class AzureStorageServiceMock extends AbstractLifecycleComponent
implements AzureStorageService {
protected Map blobs = new ConcurrentHashMap<>();
diff --git a/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/AwsS3Service.java b/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/AwsS3Service.java
index 15cd55c823d..752a2abc3ce 100644
--- a/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/AwsS3Service.java
+++ b/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/AwsS3Service.java
@@ -31,7 +31,7 @@ import java.util.function.Function;
/**
*
*/
-public interface AwsS3Service extends LifecycleComponent {
+public interface AwsS3Service extends LifecycleComponent {
// Global AWS settings (shared between discovery-ec2 and repository-s3)
// Each setting starting with `cloud.aws` also exists in discovery-ec2 project. Don't forget to update
diff --git a/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java b/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java
index 287973a3a90..1a0c2992b15 100644
--- a/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java
+++ b/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java
@@ -44,7 +44,7 @@ import java.util.Map;
/**
*
*/
-public class InternalAwsS3Service extends AbstractLifecycleComponent implements AwsS3Service {
+public class InternalAwsS3Service extends AbstractLifecycleComponent implements AwsS3Service {
/**
* (acceskey, endpoint) -> client
diff --git a/test/framework/src/main/java/org/elasticsearch/test/transport/CapturingTransport.java b/test/framework/src/main/java/org/elasticsearch/test/transport/CapturingTransport.java
index 94c30f496dd..f0f85b24f72 100644
--- a/test/framework/src/main/java/org/elasticsearch/test/transport/CapturingTransport.java
+++ b/test/framework/src/main/java/org/elasticsearch/test/transport/CapturingTransport.java
@@ -242,19 +242,13 @@ public class CapturingTransport implements Transport {
}
@Override
- public Transport start() {
- return null;
- }
+ public void start() {}
@Override
- public Transport stop() {
- return null;
- }
+ public void stop() {}
@Override
- public void close() {
-
- }
+ public void close() {}
@Override
public List getLocalAddresses() {
diff --git a/test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java b/test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java
index 7bc7f0d5254..41c27ecbf97 100644
--- a/test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java
+++ b/test/framework/src/main/java/org/elasticsearch/test/transport/MockTransportService.java
@@ -558,15 +558,13 @@ public class MockTransportService extends TransportService {
}
@Override
- public Transport start() {
+ public void start() {
transport.start();
- return this;
}
@Override
- public Transport stop() {
+ public void stop() {
transport.stop();
- return this;
}
@Override