honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12440 from cbuescher/feature/query-refactoring-constructorCleanup 

Extended SpanFirstQueryBuilderTest
This commit is contained in:
Christoph Büscher 2015-07-24 15:45:39 +02:00
parent 94d13c73c7 1c3e8e27bf
commit 8776463084
1 changed files with 50 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
core/src/test/java/org/elasticsearch/index/query/SpanFirstQueryBuilderTest.java
View File

@ -22,10 +22,15 @@ package org.elasticsearch.index.query;
import org.apache.lucene.search.Query; import org.apache.lucene.search.Query;
import org.apache.lucene.search.spans.SpanFirstQuery; import org.apache.lucene.search.spans.SpanFirstQuery;
import org.apache.lucene.search.spans.SpanQuery; import org.apache.lucene.search.spans.SpanQuery;
import org.elasticsearch.common.xcontent.XContentBuilder;
import org.elasticsearch.common.xcontent.XContentFactory;
import org.elasticsearch.common.xcontent.XContentParser;
import org.junit.Test; import org.junit.Test;
import java.io.IOException; import java.io.IOException;
import static org.elasticsearch.index.query.QueryBuilders.spanTermQuery;
public class SpanFirstQueryBuilderTest extends BaseQueryTestCase<SpanFirstQueryBuilder> { public class SpanFirstQueryBuilderTest extends BaseQueryTestCase<SpanFirstQueryBuilder> {
@Override @Override
@ -54,12 +59,55 @@ public class SpanFirstQueryBuilderTest extends BaseQueryTestCase<SpanFirstQueryB
} else { } else {
innerSpanQueryBuilder = new SpanTermQueryBuilder("name", "value"); innerSpanQueryBuilder = new SpanTermQueryBuilder("name", "value");
} }
int end = 10; int end = randomIntBetween(0, 10);
if (randomBoolean()) { if (randomBoolean()) {
end = -1; end = randomIntBetween(-10, -1);
totalExpectedErrors++; totalExpectedErrors++;
} }
SpanFirstQueryBuilder queryBuilder = new SpanFirstQueryBuilder(innerSpanQueryBuilder, end); SpanFirstQueryBuilder queryBuilder = new SpanFirstQueryBuilder(innerSpanQueryBuilder, end);
assertValidate(queryBuilder, totalExpectedErrors); assertValidate(queryBuilder, totalExpectedErrors);
} }
/**
* test exception on missing `end` and `match` parameter in parser
*/
@Test
public void testParseEnd() throws IOException {
XContentBuilder builder = XContentFactory.jsonBuilder();
builder.startObject();
builder.startObject(SpanFirstQueryBuilder.NAME);
builder.field("match");
spanTermQuery("description", "jumped").toXContent(builder, null);
builder.endObject();
builder.endObject();
QueryParseContext context = createContext();
XContentParser parser = XContentFactory.xContent(builder.string()).createParser(builder.string());
context.reset(parser);
assertQueryHeader(parser, SpanFirstQueryBuilder.NAME);
try {
new SpanFirstQueryParser().fromXContent(context);
fail("missing [end] parameter should raise exception");
} catch (QueryParsingException e) {
assertTrue(e.getMessage().contains("spanFirst must have [end] set"));
}
builder = XContentFactory.jsonBuilder();
builder.startObject();
builder.startObject(SpanFirstQueryBuilder.NAME);
builder.field("end", 10);
builder.endObject();
builder.endObject();
context = createContext();
parser = XContentFactory.xContent(builder.string()).createParser(builder.string());
context.reset(parser);
assertQueryHeader(parser, SpanFirstQueryBuilder.NAME);
try {
new SpanFirstQueryParser().fromXContent(context);
fail("missing [match] parameter should raise exception");
} catch (QueryParsingException e) {
assertTrue(e.getMessage().contains("spanFirst must have [match] span query clause"));
}
}
} }