more review comments

This commit is contained in:
Britta Weber 2015-07-30 17:47:21 +02:00
parent b86d07fc9a
commit 8a4957967b
2 changed files with 4 additions and 5 deletions

View File

@ -20,8 +20,9 @@
package org.elasticsearch.search.fetch;
/**
* This class stores if or if not a FetchSubPhase is supposed to execute.
* It be extended by FetchSubPhases to hold information the phase needs to execute on hits.
* All configuration and context needed by the FetchSubPhase to execute on hits.
* The only required information in this base class is whether or not the sub phase needs to be run at all.
* It can be extended by FetchSubPhases to hold information the phase needs to execute on hits.
* See {@link org.elasticsearch.search.fetch.FetchSubPhase.ContextFactory} and also {@link org.elasticsearch.search.fetch.fielddata.FieldDataFieldsContext} for an example.
*/
public class FetchSubPhaseContext {

View File

@ -137,9 +137,7 @@ public class FetchSubPhasePluginTests extends ElasticsearchIntegrationTest {
@Override
public Map<String, ? extends SearchParseElement> parseElements() {
ImmutableMap.Builder<String, SearchParseElement> parseElements = ImmutableMap.builder();
parseElements.put("term_vectors_fetch", new TermVectorsFetchParseElement());
return parseElements.build();
return ImmutableMap.of("term_vectors_fetch", new TermVectorsFetchParseElement());
}
@Override