From 8c8b1dc2cf5a480508f90e6e06fe1418a455e81c Mon Sep 17 00:00:00 2001
From: Jason Tedor <jason@tedor.me>
Date: Sat, 9 Dec 2017 09:12:40 -0500
Subject: [PATCH] Fix index with unknown setting test

This commit fixes the test of an index with an unknown setting. The
problem here is that we were manipulating the index state on disk, but a
cluster state update could arrive between us manipulating the index
state on disk and us restarting the node, leading to the index state
that we just intentionally broke being fixed. As such, after restart,
the index state would not be in the state that we expected it to be in
and the test would fail. To address this, we hook into the restart and
break the index state immediately before the node is started again.

Relates #26995
---
 .../admin/indices/create/CreateIndexIT.java   | 37 ++++++++++++++-----
 1 file changed, 27 insertions(+), 10 deletions(-)

diff --git a/core/src/test/java/org/elasticsearch/action/admin/indices/create/CreateIndexIT.java b/core/src/test/java/org/elasticsearch/action/admin/indices/create/CreateIndexIT.java
index 7477f11601f..3f99e437393 100644
--- a/core/src/test/java/org/elasticsearch/action/admin/indices/create/CreateIndexIT.java
+++ b/core/src/test/java/org/elasticsearch/action/admin/indices/create/CreateIndexIT.java
@@ -19,6 +19,7 @@
 
 package org.elasticsearch.action.admin.indices.create;
 
+import com.carrotsearch.hppc.cursors.ObjectCursor;
 import org.elasticsearch.ElasticsearchException;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.action.UnavailableShardsException;
@@ -30,6 +31,7 @@ import org.elasticsearch.action.support.IndicesOptions;
 import org.elasticsearch.cluster.ClusterState;
 import org.elasticsearch.cluster.metadata.IndexMetaData;
 import org.elasticsearch.cluster.metadata.MetaData;
+import org.elasticsearch.cluster.node.DiscoveryNode;
 import org.elasticsearch.common.collect.ImmutableOpenMap;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.unit.TimeValue;
@@ -39,8 +41,11 @@ import org.elasticsearch.index.query.RangeQueryBuilder;
 import org.elasticsearch.test.ESIntegTestCase;
 import org.elasticsearch.test.ESIntegTestCase.ClusterScope;
 import org.elasticsearch.test.ESIntegTestCase.Scope;
+import org.elasticsearch.test.InternalTestCluster;
 
 import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Set;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.BiFunction;
@@ -355,17 +360,29 @@ public class CreateIndexIT extends ESIntegTestCase {
         client().admin().indices().prepareCreate("test").setSettings(settings).get();
         ensureGreen("test");
         final ClusterState state = client().admin().cluster().prepareState().get().getState();
-        final IndexMetaData metaData = state.getMetaData().index("test");
-        for (final NodeEnvironment services : internalCluster().getInstances(NodeEnvironment.class)) {
-            final IndexMetaData brokenMetaData =
-                    IndexMetaData
-                            .builder(metaData)
-                            .settings(Settings.builder().put(metaData.getSettings()).put("index.foo", "true"))
-                            .build();
-            // so evil
-            IndexMetaData.FORMAT.write(brokenMetaData, services.indexPaths(brokenMetaData.getIndex()));
+
+        final Set<String> dataOrMasterNodeNames = new HashSet<>();
+        for (final ObjectCursor<DiscoveryNode> node : state.nodes().getMasterAndDataNodes().values()) {
+            assertTrue(dataOrMasterNodeNames.add(node.value.getName()));
         }
-        internalCluster().fullRestart();
+
+        final IndexMetaData metaData = state.getMetaData().index("test");
+        internalCluster().fullRestart(new InternalTestCluster.RestartCallback() {
+            @Override
+            public Settings onNodeStopped(String nodeName) throws Exception {
+                if (dataOrMasterNodeNames.contains(nodeName)) {
+                    final NodeEnvironment nodeEnvironment = internalCluster().getInstance(NodeEnvironment.class, nodeName);
+                    final IndexMetaData brokenMetaData =
+                            IndexMetaData
+                                    .builder(metaData)
+                                    .settings(Settings.builder().put(metaData.getSettings()).put("index.foo", true))
+                                    .build();
+                    // so evil
+                    IndexMetaData.FORMAT.write(brokenMetaData, nodeEnvironment.indexPaths(brokenMetaData.getIndex()));
+                }
+                return Settings.EMPTY;
+            }
+        });
         ensureGreen(metaData.getIndex().getName()); // we have to wait for the index to show up in the metadata or we will fail in a race
         final ClusterState stateAfterRestart = client().admin().cluster().prepareState().get().getState();