From 8d9e21ffaaab9a7ef1b6d5b7bf69c29f0728a6e8 Mon Sep 17 00:00:00 2001 From: Tim Vernum Date: Wed, 28 Nov 2018 01:10:14 +1100 Subject: [PATCH] Fix mutator in GetRolesRequestTests (#35932) There was no guarantee that the mutated object would not be the same as the original object (and was for seed 6A8C4CBF63B5AA63) Resolves #35947 --- .../elasticsearch/client/security/GetRolesRequestTests.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/rest-high-level/src/test/java/org/elasticsearch/client/security/GetRolesRequestTests.java b/client/rest-high-level/src/test/java/org/elasticsearch/client/security/GetRolesRequestTests.java index 4bf970d096b..3269fb3eb1e 100644 --- a/client/rest-high-level/src/test/java/org/elasticsearch/client/security/GetRolesRequestTests.java +++ b/client/rest-high-level/src/test/java/org/elasticsearch/client/security/GetRolesRequestTests.java @@ -47,6 +47,7 @@ public class GetRolesRequestTests extends ESTestCase { } private static GetRolesRequest mutateTestItem(GetRolesRequest original) { - return new GetRolesRequest(randomArray(0, 5, String[]::new, () -> randomAlphaOfLength(5))); + final int minRoles = original.getRoleNames().isEmpty() ? 1 : 0; + return new GetRolesRequest(randomArray(minRoles, 5, String[]::new, () -> randomAlphaOfLength(6))); } }