honeymoose/OpenSearch
1
0
Fork 0
mirror of https://github.com/honeymoose/OpenSearch.git synced 2025-02-17 18:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always Accumulate Transport Exceptions (elastic/x-pack-elasticsearch#1619)

Browse Source 
This is the x-pack side of the removal of `accumulateExceptions()` for both `TransportNodesAction` and `TransportTasksAction`.

There are occasional, random failures that occur during API calls that are silently ignored from the caller's perspective, which also leads to weird API responses that have no response and also no errors, which is obviously untrue.

Original commit: elastic/x-pack-elasticsearch@9b57321549
This commit is contained in:
Chris Earle 2017-06-02 10:01:21 -04:00 committed by GitHub
parent babe27afe0
commit 8e76265c26
8 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugin/src/main/java/org/elasticsearch/xpack/ml/action/CloseJobAction.java
View File

@ -29,7 +29,6 @@ import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.io.stream.Writeable;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.unit.TimeValue;
import org.elasticsearch.common.util.ArrayUtils;
import org.elasticsearch.common.util.concurrent.AbstractRunnable;
import org.elasticsearch.common.util.concurrent.AtomicArray;
import org.elasticsearch.common.xcontent.ObjectParser;
@ -388,11 +387,6 @@ public class CloseJobAction extends Action<CloseJobAction.Request, CloseJobActio
}, listener::onFailure));
}
@Override
protected boolean accumulateExceptions() {
return true;
}
@Override
protected Response newResponse(Request request, List<Response> tasks,
List<TaskOperationFailure> taskOperationFailures,

5
plugin/src/main/java/org/elasticsearch/xpack/ml/action/GetJobsStatsAction.java
View File

@ -401,11 +401,6 @@ public class GetJobsStatsAction extends Action<GetJobsStatsAction.Request, GetJo
return new QueryPage<>(in, Response.JobStats::new);
}
@Override
protected boolean accumulateExceptions() {
return true;
}
@Override
protected void taskOperation(Request request, OpenJobAction.JobTask task,
ActionListener<QueryPage<Response.JobStats>> listener) {

4
plugin/src/main/java/org/elasticsearch/xpack/ml/action/StopDatafeedAction.java
View File

@ -461,10 +461,6 @@ public class StopDatafeedAction
return new Response(in);
}
@Override
protected boolean accumulateExceptions() {
return true;
}
}
/**

5
plugin/src/main/java/org/elasticsearch/xpack/ml/action/TransportJobTaskAction.java
View File

@ -100,11 +100,6 @@ public abstract class TransportJobTaskAction<Request extends TransportJobTaskAct
}
}
@Override
protected boolean accumulateExceptions() {
return true;
}
public static class JobTaskRequest<R extends JobTaskRequest<R>> extends BaseTasksRequest<R> {
String jobId;

5
plugin/src/main/java/org/elasticsearch/xpack/security/action/realm/TransportClearRealmCacheAction.java
View File

@ -87,9 +87,4 @@ public class TransportClearRealmCacheAction extends TransportNodesAction<ClearRe
}
}
@Override
protected boolean accumulateExceptions() {
return false;
}
}

4
plugin/src/main/java/org/elasticsearch/xpack/security/action/role/TransportClearRolesCacheAction.java
View File

@ -61,8 +61,4 @@ public class TransportClearRolesCacheAction extends TransportNodesAction<ClearRo
return new ClearRolesCacheResponse.Node(clusterService.localNode());
}
@Override
protected boolean accumulateExceptions() {
return false;
}
}

5
plugin/src/main/java/org/elasticsearch/xpack/watcher/transport/actions/stats/TransportWatcherStatsAction.java
View File

@ -80,9 +80,4 @@ public class TransportWatcherStatsAction extends TransportNodesAction<WatcherSta
return statsResponse;
}
@Override
protected boolean accumulateExceptions() {
return false;
}
}

4
plugin/src/test/java/org/elasticsearch/xpack/persistent/TestPersistentTasksPlugin.java
View File

@ -532,10 +532,6 @@ public class TestPersistentTasksPlugin extends Plugin implements ActionPlugin {
listener.onResponse(new TestTaskResponse());
}
@Override
protected boolean accumulateExceptions() {
return false;
}
}