honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix tophints noise. 

previously this was done wrong, junit4 ant tasks were brought into
the test classpath. This created jar hell for tests, and also encouraged
people to use _internal_ stuff like its bundled guava in tests.

also the task was set to be lenient and ignore errors. And we were
passing in a messload of unnecessary classpaths to run this. It
only needs the module classpath: the explicit ant dependencies we declare.
This commit is contained in:
Robert Muir 2015-07-08 00:45:02 -04:00
parent fb62d945aa
commit 8f0b7164b7
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pom.xml
View File

@ -1264,19 +1264,8 @@ org.eclipse.jdt.ui.text.custom_code_templates=<?xml version\="1.0" encoding\="UT
<phase>test</phase>
<configuration>
<skip>${skip.unit.tests}</skip>
<!-- don't run if we skip the tests -->
<failOnError>false</failOnError>
<target>
<property name="runtime_classpath" refid="maven.runtime.classpath"/>
<property name="test_classpath" refid="maven.test.classpath"/>
<property name="plugin_classpath" refid="maven.plugin.classpath"/>
<taskdef resource="com/carrotsearch/junit4/antlib.xml">
<classpath>
<pathelement path="${plugin_classpath}"/>
<pathelement path="${runtime_classpath}"/>
<pathelement path="${test_classpath}"/>
</classpath>
</taskdef>
<taskdef resource="com/carrotsearch/junit4/antlib.xml" classpathref="maven.plugin.classpath"/>
<tophints max="${tests.topn}">
<file file="${basedir}/${execution.hint.file}"/>
</tophints>
@ -1287,6 +1276,13 @@ org.eclipse.jdt.ui.text.custom_code_templates=<?xml version\="1.0" encoding\="UT
</goals>
</execution>
</executions>
<dependencies>
<dependency>
<groupId>com.carrotsearch.randomizedtesting</groupId>
<artifactId>junit4-ant</artifactId>
<version>${testframework.version}</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<!-- We just declare which plugin version to use. Each project can have then its own settings -->