From 8fb016324415a80a0d39f90a4a89a0c65e79113e Mon Sep 17 00:00:00 2001 From: Shay Banon Date: Sat, 30 Jul 2011 09:43:58 +0300 Subject: [PATCH] log failure when executing multi_get --- .../action/bulk/TransportShardBulkAction.java | 8 ++------ .../action/get/TransportShardMultiGetAction.java | 1 + 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/modules/elasticsearch/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java b/modules/elasticsearch/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java index bb2e2ddceea..bff69888c22 100644 --- a/modules/elasticsearch/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java +++ b/modules/elasticsearch/src/main/java/org/elasticsearch/action/bulk/TransportShardBulkAction.java @@ -157,9 +157,7 @@ public class TransportShardBulkAction extends TransportShardReplicationOperation responses[i] = new BulkItemResponse(item.id(), indexRequest.opType().toString().toLowerCase(), new IndexResponse(indexRequest.index(), indexRequest.type(), indexRequest.id(), version)); } catch (Exception e) { - if (logger.isDebugEnabled()) { - logger.debug("[" + shardRequest.request.index() + "][" + shardRequest.shardId + "]" + ": Failed to execute bulk item (index) [" + indexRequest + "]", e); - } + logger.debug("[{}][{}] failed to bulk item (index) {}", e, shardRequest.request.index(), shardRequest.shardId, indexRequest); responses[i] = new BulkItemResponse(item.id(), indexRequest.opType().toString().toLowerCase(), new BulkItemResponse.Failure(indexRequest.index(), indexRequest.type(), indexRequest.id(), ExceptionsHelper.detailedMessage(e))); } @@ -175,9 +173,7 @@ public class TransportShardBulkAction extends TransportShardReplicationOperation responses[i] = new BulkItemResponse(item.id(), "delete", new DeleteResponse(deleteRequest.index(), deleteRequest.type(), deleteRequest.id(), delete.version(), delete.notFound())); } catch (Exception e) { - if (logger.isDebugEnabled()) { - logger.debug("[" + shardRequest.request.index() + "][" + shardRequest.shardId + "]" + ": Failed to execute bulk item (delete) [" + deleteRequest + "]", e); - } + logger.debug("[{}][{}] failed to bulk item (delete) {}", e, shardRequest.request.index(), shardRequest.shardId, deleteRequest); responses[i] = new BulkItemResponse(item.id(), "delete", new BulkItemResponse.Failure(deleteRequest.index(), deleteRequest.type(), deleteRequest.id(), ExceptionsHelper.detailedMessage(e))); } diff --git a/modules/elasticsearch/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java b/modules/elasticsearch/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java index 99c46e76922..f4ce59a9e7c 100644 --- a/modules/elasticsearch/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java +++ b/modules/elasticsearch/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java @@ -108,6 +108,7 @@ public class TransportShardMultiGetAction extends TransportShardSingleOperationA GetResponse getResponse = TransportGetAction.load(logger, scriptService, indexService, indexShard, request.index(), type, id, fields, request.realtime()); response.add(request.locations.get(i), getResponse); } catch (Exception e) { + logger.debug("[{}][{}] failed to execute multi_get for [{}]/[{}]", e, request.index(), shardId, type, id); response.add(request.locations.get(i), new MultiGetResponse.Failure(request.index(), type, id, ExceptionsHelper.detailedMessage(e))); } }