honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add TODO optimizations comments

This commit is contained in:
kimchy 2011-04-21 01:57:28 +03:00
parent 9c606c7b1d
commit 90b88fe4b7
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/elasticsearch/src/main/java/org/elasticsearch/index/search/UidFilter.java
View File

@ -51,6 +51,9 @@ public class UidFilter extends Filter {
Arrays.sort(uids); Arrays.sort(uids);
} }
// TODO Optimizations
// - If we have a single id, we can create a SingleIdDocIdSet to save on mem
// - We can use sorted int array DocIdSet to reserve memory compared to OpenBitSet in some cases
@Override public DocIdSet getDocIdSet(IndexReader reader) throws IOException { @Override public DocIdSet getDocIdSet(IndexReader reader) throws IOException {
BloomFilter filter = bloomCache.filter(reader, UidFieldMapper.NAME, true); BloomFilter filter = bloomCache.filter(reader, UidFieldMapper.NAME, true);
OpenBitSet set = null; OpenBitSet set = null;