honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

painless: optimize/simplify dynamic field and method access

This commit is contained in:
Robert Muir 2016-05-05 03:42:14 -04:00
parent 784c9e5fb9
commit 928e2b904d
1 changed files with 12 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
modules/lang-painless/src/main/java/org/elasticsearch/painless/Def.java
View File

@ -242,18 +242,16 @@ public class Def {
} }
public static Method getMethod(final Object owner, final String name, final Definition definition) { public static Method getMethod(final Object owner, final String name, final Definition definition) {
Struct struct = null;
Class<?> clazz = owner.getClass(); Class<?> clazz = owner.getClass();
Method method = null;
while (clazz != null) { while (clazz != null) {
struct = definition.classes.get(clazz); Struct struct = definition.classes.get(clazz);
if (struct != null) { if (struct != null) {
method = struct.methods.get(name); Method method = struct.methods.get(name);
if (method != null) { if (method != null) {
break; return method;
} }
} }
@ -261,45 +259,31 @@ public class Def {
struct = definition.classes.get(iface); struct = definition.classes.get(iface);
if (struct != null) { if (struct != null) {
method = struct.methods.get(name); Method method = struct.methods.get(name);
if (method != null) { if (method != null) {
break; return method;
} }
} }
} }
if (struct != null) {
method = struct.methods.get(name);
if (method != null) {
break;
}
}
clazz = clazz.getSuperclass(); clazz = clazz.getSuperclass();
} }
if (struct == null) { return null;
throw new IllegalArgumentException("Unable to find a dynamic struct for class [" + owner.getClass() + "].");
}
return method;
} }
public static Field getField(final Object owner, final String name, final Definition definition) { public static Field getField(final Object owner, final String name, final Definition definition) {
Struct struct = null;
Class<?> clazz = owner.getClass(); Class<?> clazz = owner.getClass();
Field field = null;
while (clazz != null) { while (clazz != null) {
struct = definition.classes.get(clazz); Struct struct = definition.classes.get(clazz);
if (struct != null) { if (struct != null) {
field = struct.members.get(name); Field field = struct.members.get(name);
if (field != null) { if (field != null) {
break; return field;
} }
} }
@ -307,30 +291,18 @@ public class Def {
struct = definition.classes.get(iface); struct = definition.classes.get(iface);
if (struct != null) { if (struct != null) {
field = struct.members.get(name); Field field = struct.members.get(name);
if (field != null) { if (field != null) {
break; return field;
} }
} }
} }
if (struct != null) {
field = struct.members.get(name);
if (field != null) {
break;
}
}
clazz = clazz.getSuperclass(); clazz = clazz.getSuperclass();
} }
if (struct == null) { return null;
throw new IllegalArgumentException("Unable to find a dynamic struct for class [" + owner.getClass() + "].");
}
return field;
} }
public static Transform getTransform(Class<?> fromClass, Class<?> toClass, final Definition definition) { public static Transform getTransform(Class<?> fromClass, Class<?> toClass, final Definition definition) {