diff --git a/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModel.java b/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModel.java index d798887c836..b244587c9b2 100644 --- a/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModel.java +++ b/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModel.java @@ -63,10 +63,6 @@ public abstract class MovAvgModel { return predictions; } - // nocommit - // I don't like that it creates a new queue here - // The alternative to this is to just use `values` directly, but that would "consume" values - // and potentially change state elsewhere. Maybe ok? Collection predictionBuffer = EvictingQueue.create(values.size()); predictionBuffer.addAll(values); diff --git a/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModelBuilder.java b/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModelBuilder.java index 96bc9427de3..a8f40d474ac 100644 --- a/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModelBuilder.java +++ b/src/main/java/org/elasticsearch/search/aggregations/reducers/movavg/models/MovAvgModelBuilder.java @@ -29,5 +29,4 @@ import java.io.IOException; * average models are used by the MovAvg reducer */ public interface MovAvgModelBuilder extends ToXContent { - public abstract XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException; }