From 95ebdbaddb2753712fe2059d58a2092846083c22 Mon Sep 17 00:00:00 2001
From: Jason Tedor <jason@tedor.me>
Date: Wed, 24 May 2017 11:55:32 -0400
Subject: [PATCH] Add BWC packaging distributions

Some packaging tests depend on snapshot versions of packaging
distributions yet the build does not use a repository that includes such
distributions. While we could add such a repository, a better strategy
is to follow our approach for other BWC tests where we depend on a
locally-compiled archive distribution. This commit adds a local
compilation of packaging artifacts and substitutes these anywhere that
we would otherwise depend on a snapshot of these artifacts.

Relates #24861
---
 build.gradle                               | 8 +++++---
 distribution/build.gradle                  | 2 +-
 distribution/{bwc-zip => bwc}/build.gradle | 9 +++++++--
 settings.gradle                            | 2 +-
 4 files changed, 14 insertions(+), 7 deletions(-)
 rename distribution/{bwc-zip => bwc}/build.gradle (86%)

diff --git a/build.gradle b/build.gradle
index c5bf39bc655..20467d842f5 100644
--- a/build.gradle
+++ b/build.gradle
@@ -96,7 +96,7 @@ if (currentVersion.bugfix == 0) {
   // If on a release branch, after the initial release of that branch, the bugfix version will
   // be bumped, and will be != 0. On master and N.x branches, we want to test against the
   // unreleased version of closest branch. So for those cases, the version includes -SNAPSHOT,
-  // and the bwc-zip distribution will checkout and build that version.
+  // and the bwc distribution will checkout and build that version.
   Version last = versions[-1]
   versions[-1] = new Version(last.major, last.minor, last.bugfix,
       true, last.unreleased)
@@ -173,8 +173,10 @@ subprojects {
   ]
   if (wireCompatVersions[-1].snapshot) {
     // if the most previous version is a snapshot, we need to connect that version to the
-    // bwc-zip project which will checkout and build that snapshot version
-    ext.projectSubstitutions["org.elasticsearch.distribution.zip:elasticsearch:${wireCompatVersions[-1]}"] = ':distribution:bwc-zip'
+    // bwc project which will checkout and build that snapshot version
+    ext.projectSubstitutions["org.elasticsearch.distribution.deb:elasticsearch:${wireCompatVersions[-1]}"] = ':distribution:bwc'
+    ext.projectSubstitutions["org.elasticsearch.distribution.rpm:elasticsearch:${wireCompatVersions[-1]}"] = ':distribution:bwc'
+    ext.projectSubstitutions["org.elasticsearch.distribution.zip:elasticsearch:${wireCompatVersions[-1]}"] = ':distribution:bwc'
   }
   project.afterEvaluate {
     configurations.all {
diff --git a/distribution/build.gradle b/distribution/build.gradle
index f78ec0bce61..253af219843 100644
--- a/distribution/build.gradle
+++ b/distribution/build.gradle
@@ -41,7 +41,7 @@ buildscript {
 }
 
 Collection distributions = project.subprojects.findAll {
-   it.path.contains(':tools') == false && it.name != 'bwc-zip' }
+   it.path.contains(':tools') == false && it.name != 'bwc' }
 
 /*****************************************************************************
  *                                Notice file                                *
diff --git a/distribution/bwc-zip/build.gradle b/distribution/bwc/build.gradle
similarity index 86%
rename from distribution/bwc-zip/build.gradle
rename to distribution/bwc/build.gradle
index 22eb03b805b..e31d0949bdf 100644
--- a/distribution/bwc-zip/build.gradle
+++ b/distribution/bwc/build.gradle
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import java.util.regex.Matcher
+
 import org.elasticsearch.gradle.LoggedExec
 
 /**
@@ -81,14 +81,19 @@ if (bwcVersion.endsWith('-SNAPSHOT')) {
     commandLine = ['git', 'checkout', "upstream/${bwcBranch}"]
   }
 
+  File bwcDeb = file("${checkoutDir}/distribution/zip/build/distributions/elasticsearch-${bwcVersion}.deb")
+  File bwcRpm = file("${checkoutDir}/distribution/zip/build/distributions/elasticsearch-${bwcVersion}.rpm")
   File bwcZip = file("${checkoutDir}/distribution/zip/build/distributions/elasticsearch-${bwcVersion}.zip")
   task buildBwcVersion(type: GradleBuild) {
     dependsOn checkoutBwcBranch
     dir = checkoutDir
-    tasks = [':distribution:zip:assemble']
+    tasks = [':distribution:deb:assemble', ':distribution:rpm:assemble', ':distribution:zip:assemble']
   }
 
+
   artifacts {
+    'default' file: bwcDeb, name: 'elasticsearch', type: 'deb', builtBy: buildBwcVersion
+    'default' file: bwcRpm, name: 'elasticsearch', type: 'rpm', builtBy: buildBwcVersion
     'default' file: bwcZip, name: 'elasticsearch', type: 'zip', builtBy: buildBwcVersion
   }
 }
diff --git a/settings.gradle b/settings.gradle
index 7977686a247..e9046f0a3de 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -15,7 +15,7 @@ List projects = [
   'client:benchmark',
   'benchmarks',
   'distribution:integ-test-zip',
-  'distribution:bwc-zip',
+  'distribution:bwc',
   'distribution:zip',
   'distribution:tar',
   'distribution:deb',